Re: [PATCH v4 2/2] arm64: dts: qcom: Add support for Acer Swift Go Pro AI (SFA14-11)

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Medium] dts: qcom: incorrect audio routing for Right Woofer to WSA_SPK2 OUT
--

commit 3b512df8c5cf84f3c49842cc54b1c1d65850a946
Author: Kaipeng Zeng <kaipeng94@gmail.com>

arm64: dts: qcom: Add support for Acer Swift Go Pro AI (SFA14-11)

Introduce device tree for the Acer Swift Go Pro AI (SFA14-11).
It is a laptop based on the Qualcomm Snapdragon X Elite (X1E78100) SoC.
This device tree implementation references nodes from the x1-crd.dtsi.

> diff --git a/arch/arm64/boot/dts/qcom/x1e78100-acer-sfa14-11.dts b/arch/arm64/boot/dts/qcom/x1e78100-acer-sfa14-11.dts
> new file mode 100644
> index 0000000000000..dafe7f08fa958
> --- /dev/null
> +++ b/arch/arm64/boot/dts/qcom/x1e78100-acer-sfa14-11.dts

[ ... ]

> +	sound {
> +		compatible = "qcom,x1e80100-sndcard";
> +		model = "X1E78100-ACER-Swift-Go-SFA14-11";
> +		audio-routing = "WooferLeft IN", "WSA WSA_SPK1 OUT",
> +				"TweeterLeft IN", "WSA WSA_SPK2 OUT",
> +				"WooferRight IN", "WSA2 WSA_SPK2 OUT",
> +				"TweeterRight IN", "WSA2 WSA_SPK2 OUT",

[Severity: Medium]
Does this code incorrectly map both the Right Woofer and Right Tweeter to the
same macro output (WSA2 WSA_SPK2 OUT)?

Since the Right Woofer expects audio data on SoundWire ports 1, 2, and 3
(corresponding to INT0/SPK1), routing it to INT1/SPK2 could mean it will be
starved of audio data and remain silent.

Should "WooferRight IN" be routed to "WSA2 WSA_SPK1 OUT" instead?

> +				"IN1_HPHL", "HPHL_OUT",
> +				"IN2_HPHR", "HPHR_OUT",

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20261006085425.40450-1-kaipeng94@gmail.com?part=2