From: sashiko-bot@kernel.org
To: "James Clark" <james.clark@linaro.org>
Cc: linux-perf-users@vger.kernel.org
Subject: Re: [PATCH 1/2] perf timechart: Fix task row type narrowing in goto_task()
Date: Tue, 06 Oct 2026 13:07:11 +0000 [thread overview]
Message-ID: <20261006130712.04F701F000FF@smtp.kernel.org> (raw)
In-Reply-To: <20261006-james-perf-timechart-mypy-v1-1-e2c7edf4dd31@linaro.org>
> Mypy cannot narrow Row to TaskRow or IoRow when the class passed to
> isinstance() comes from a loop variable, causing the perf build to fail
> with:
>
> python/ttimechart.py:1686: error: "Row" has no attribute "task" [attr-defined]
>
> Check against TaskRow and IoRow explicitly so mypy can verify access to
> the task attribute. The tasks and I/O views contain TaskRow and IoRow
> instances respectively, so task navigation behaves as before.
>
> Fixes: e7a72d691980 ("perf timechart: Add an interactive --tui mode")
> Assisted-by: Codex:GPT-6.1-Sol
> Signed-off-by: James Clark <james.clark@linaro.org>
Sashiko has reviewed this patch and found no issues. It looks great!
--
Sashiko AI review · https://sashiko.dev/#/patchset/20261006-james-perf-timechart-mypy-v1-0-e2c7edf4dd31@linaro.org?part=1
next prev parent reply other threads:[~2026-10-06 13:07 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-10-06 13:03 [PATCH 0/2] perf timechart/treport: Fix mypy errors James Clark
2026-10-06 13:03 ` [PATCH 1/2] perf timechart: Fix task row type narrowing in goto_task() James Clark
2026-10-06 13:07 ` sashiko-bot [this message]
2026-10-06 13:03 ` [PATCH 2/2] perf treport: Fix profile builder type narrowing in progress callback James Clark
2026-10-06 13:06 ` sashiko-bot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20261006130712.04F701F000FF@smtp.kernel.org \
--to=sashiko-bot@kernel.org \
--cc=james.clark@linaro.org \
--cc=linux-perf-users@vger.kernel.org \
--cc=sashiko-reviews@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.