From: Benjamin Coddington <ben.coddington@hammerspace.com>
To: kernel test robot <lkp@intel.com>
Cc: oe-kbuild-all@lists.linux.dev, Chuck Lever <cel@kernel.org>
Subject: Re: [cel:nfsd-testing 295/295] fs/lockd/svcsubs.c:428:5-24: WARNING: atomic_dec_and_test variation before object free at line 429.
Date: Tue, 6 Oct 2026 10:15:08 -0400 [thread overview]
Message-ID: <20261006141508.692417-1-ben.coddington@hammerspace.com> (raw)
In-Reply-To: <202610052357.ZfzEOheQ-lkp@intel.com>
From: Benjamin Coddington <bcodding@hammerspace.com>
On 5 Oct 2026, at 18:00, kernel test robot wrote:
> cocci warnings: (new ones prefixed by >>)
>>> fs/lockd/svcsubs.c:428:5-24: WARNING: atomic_dec_and_test variation before object free at line 429.
This is atomic_as_refcounter.cocci suggesting refcount_t, which doesn't
fit f_count. The count rests at zero while locks hold the nlm_file in
the table, and nlm_lookup_file() and nlm_traverse_files() increment it
from zero, which refcount_t would WARN on. Whether to free is decided by
nlm_file_inuse() under nlm_file_mutex, not by the decrement. The commit
message notes why it is an atomic_t rather than a refcount_t.
No change planned.
Ben
prev parent reply other threads:[~2026-10-06 14:15 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-10-05 22:00 [cel:nfsd-testing 295/295] fs/lockd/svcsubs.c:428:5-24: WARNING: atomic_dec_and_test variation before object free at line 429 kernel test robot
2026-10-06 14:15 ` Benjamin Coddington [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20261006141508.692417-1-ben.coddington@hammerspace.com \
--to=ben.coddington@hammerspace.com \
--cc=cel@kernel.org \
--cc=lkp@intel.com \
--cc=oe-kbuild-all@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.