From: Simon Horman <horms@kernel.org>
To: Jamal Hadi Salim <jhs@mojatatu.com>
Cc: netdev@vger.kernel.org, "Jiri Pirko" <jiri@resnulli.us>,
"David S . Miller" <davem@davemloft.net>,
"Eric Dumazet" <edumazet@google.com>,
"Jakub Kicinski" <kuba@kernel.org>,
"Paolo Abeni" <pabeni@redhat.com>,
"Victor Nogueira" <victor@mojatatu.com>,
"Toke Høiland-Jørgensen" <toke@toke.dk>,
moeller0@gmx.de, cake@lists.bufferbloat.net,
Sashiko <sashiko-bot@kernel.org>
Subject: Re: [PATCH net-next v4] net/sched: cap the accounted backlog before it can wrap
Date: Tue, 6 Oct 2026 16:30:43 +0100 [thread overview]
Message-ID: <20261006153043.GM83879@horms.kernel.org> (raw)
In-Reply-To: <QDISC-BA27.v4.20261001193440@mojatatu.com>
On Fri, Oct 02, 2026 at 03:44:31AM -0400, Jamal Hadi Salim wrote:
...
> diff --git a/net/sched/sch_cake.c b/net/sched/sch_cake.c
...
> @@ -1712,18 +1738,24 @@ static struct cake_tin_data *cake_select_tin(struct Qdisc *sch,
> return &qd->tins[tin];
> }
>
> -static u32 cake_classify(struct Qdisc *sch, struct cake_tin_data **t,
> - struct sk_buff *skb, int flow_mode, int *qerr)
> +/* Run the optional external classifier. Returns true when the packet was
> + * consumed by a terminal TC action (reason in *qerr); else *flow/*host
FYI:
W=1 builds complain that the line above has a '/*' embedded in a comment.
This is likely why Sashiko NIPA didn't run for this series.
...
next prev parent reply other threads:[~2026-10-06 15:30 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-10-02 7:44 [PATCH net-next v4] net/sched: cap the accounted backlog before it can wrap Jamal Hadi Salim
2026-10-06 15:30 ` Simon Horman [this message]
2026-10-07 10:13 ` Jamal Hadi Salim
2026-10-09 10:35 ` Simon Horman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20261006153043.GM83879@horms.kernel.org \
--to=horms@kernel.org \
--cc=cake@lists.bufferbloat.net \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=jhs@mojatatu.com \
--cc=jiri@resnulli.us \
--cc=kuba@kernel.org \
--cc=moeller0@gmx.de \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=sashiko-bot@kernel.org \
--cc=toke@toke.dk \
--cc=victor@mojatatu.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.