Re: [PATCH v1 1/7] regulator: dt-bindings: ti,lp872x: Convert to DT schema

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Critical] dt-bindings: ti,lp872x: ABI breakage by renaming ti,dvs-gpio
--

commit c03dfe1db500df8cb1f0e6fb4b50fc47567114c6
Author: Svyatoslav Ryhel <clamor95@gmail.com>

regulator: dt-bindings: ti,lp872x: Convert to DT schema

Convert TI LP872x regulator binding from text to DT schema.

> diff --git a/Documentation/devicetree/bindings/regulator/lp872x.txt b/Documentation/devicetree/bindings/regulator/lp872x.txt
> deleted file mode 100644
> index ab895cd1cac1a..0000000000000
> --- a/Documentation/devicetree/bindings/regulator/lp872x.txt
> +++ /dev/null
> @@ -1,161 +0,0 @@
[ ... ]
> -Optional properties:
> -  - ti,general-config: the value of LP872X_GENERAL_CFG register (u8)
[ ... ]
> -  - ti,update-config: define it when LP872X_GENERAL_CFG register should be set
> -  - ti,dvs-gpio: GPIO specifier for external DVS pin control of LP872x devices.
> -  - ti,dvs-vsel: DVS selector. 0 = SEL_V1, 1 = SEL_V2.
> -  - ti,dvs-state: initial DVS pin state. 0 = DVS_LOW, 1 = DVS_HIGH.
[ ... ]
> diff --git a/Documentation/devicetree/bindings/regulator/ti,lp8720.yaml b/Documentation/devicetree/bindings/regulator/ti,lp8720.yaml
> new file mode 100644
> index 0000000000000..f2384749314f1
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/regulator/ti,lp8720.yaml
> @@ -0,0 +1,232 @@
[ ... ]
> +  enable-gpios:
> +    description: GPIO specifier for EN pin control.
> +    maxItems: 1
> +
> +  dvs-gpios:
> +    description: GPIO specifier for external DVS pin control.

[Severity: Critical]
Does renaming ti,dvs-gpio to dvs-gpios cause a regression for existing
device trees?

The original text binding specifies ti,dvs-gpio for DVS pin control, but the
new YAML schema renames it to dvs-gpios and uses additionalProperties: false.
Existing valid device trees using ti,dvs-gpio will fail schema validation.

Furthermore, looking at lp872x_init_dvs() in drivers/regulator/lp872x.c,
when the driver is updated to use devm_gpiod_get_optional(dev, "dvs", ...)
instead of the legacy ti,dvs connection ID, it will only look for dvs-gpios
or dvs-gpio. The driver will silently ignore the legacy ti,dvs-gpio property,
breaking DVS functionality for existing hardware unless explicit fallback
logic is provided.

Should the schema retain ti,dvs-gpio as a deprecated property or support
both names to maintain backward compatibility?

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20261006154431.318936-1-clamor95@gmail.com?part=1