From: Jakub Kicinski <kuba@kernel.org>
To: <han.junyang@zte.com.cn>
Cc: <andrew+netdev@lunn.ch>, <davem@davemloft.net>,
<edumazet@google.com>, <pabeni@redhat.com>, <horms@kernel.org>,
<linux-kernel@vger.kernel.org>, <netdev@vger.kernel.org>,
<ran.ming@zte.com.cn>, <han.chengfei@zte.com.cn>,
<zhang.yanze@zte.com.cn>
Subject: Re: [PATCH net-next v4 1/3] dinghai: add firmware version check and RISC-V readiness polling
Date: Tue, 6 Oct 2026 17:27:25 -0700 [thread overview]
Message-ID: <20261006172725.4c1e89d2@kernel.org> (raw)
In-Reply-To: <202609282024273579VUWteKdnnbvWlyjERLQ-@zte.com.cn>
On Mon, 28 Sep 2026 20:24:27 +0800 (CST) han.junyang@zte.com.cn wrote:
> +struct zxdh_fw_compat {
> + u8 module_id;
> + u8 major;
> + u8 fw_minor;
> + u8 drv_minor;
> + u16 patch;
> + u16 rsv;
> +} __packed;
Why is this __packed? Please don't sprinkle packed annotations
unnecessarily, they lower code efficiency.
TBH the AI review for this patch looks like all false positives / nit
picks. We do trust PCIe devices a little. The AI review on patch 2
seems to have found real bugs.
next prev parent reply other threads:[~2026-10-07 0:27 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-09-28 12:20 [PATCH net-next v4 0/3] dinghai: firmware handshake, MSI-X pools and async event queues han.junyang
2026-09-28 12:24 ` [PATCH net-next v4 1/3] dinghai: add firmware version check and RISC-V readiness polling han.junyang
2026-10-01 13:06 ` Simon Horman
2026-10-07 0:27 ` Jakub Kicinski [this message]
2026-09-28 12:27 ` [PATCH net-next v4 2/3] dinghai: add MSI-X interrupt pools han.junyang
2026-09-28 12:33 ` [PATCH net-next v4 3/3] dinghai: add async event queue for firmware notifications han.junyang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20261006172725.4c1e89d2@kernel.org \
--to=kuba@kernel.org \
--cc=andrew+netdev@lunn.ch \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=han.chengfei@zte.com.cn \
--cc=han.junyang@zte.com.cn \
--cc=horms@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=ran.ming@zte.com.cn \
--cc=zhang.yanze@zte.com.cn \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.