All of lore.kernel.org
 help / color / mirror / Atom feed
From: Kees Cook <kees@kernel.org>
To: Ard Biesheuvel <ardb@kernel.org>
Cc: Kees Cook <kees@kernel.org>,
	Ilias Apalodimas <ilias.apalodimas@linaro.org>,
	linux-efi@vger.kernel.org, linux-kernel@vger.kernel.org,
	linux-hardening@vger.kernel.org
Subject: [PATCH v1 1/3] efi/libstub: Declare the x86 stub's assembly entry points
Date: Tue,  6 Oct 2026 13:42:21 -0700	[thread overview]
Message-ID: <20261006204224.1536491-1-kees@kernel.org> (raw)
In-Reply-To: <20261006204210.i.137-kees@kernel.org>

efi_stub_entry() and efi_handover_entry() are entered from efi-mixed.S
and, through the efi32_stub_entry() and efi64_stub_entry() aliases, by
boot loaders using the EFI handover protocol, but have no prototypes.
Declare them in x86-stub.h, as asmlinkage, so that the stub can be built
with the kernel's -Wmissing-prototypes.

Assisted-by: LLM
Signed-off-by: Kees Cook <kees@kernel.org>
---
 drivers/firmware/efi/libstub/x86-stub.h | 9 +++++++++
 1 file changed, 9 insertions(+)

diff --git a/drivers/firmware/efi/libstub/x86-stub.h b/drivers/firmware/efi/libstub/x86-stub.h
index 1c20e99a6494..cc2474c0f95b 100644
--- a/drivers/firmware/efi/libstub/x86-stub.h
+++ b/drivers/firmware/efi/libstub/x86-stub.h
@@ -8,6 +8,15 @@ extern const u16 trampoline_ljmp_imm_offset;
 efi_status_t efi_adjust_memory_range_protection(unsigned long start,
 						unsigned long size);
 
+struct boot_params;
+
+asmlinkage void __noreturn efi_stub_entry(efi_handle_t handle,
+					  efi_system_table_t *sys_table_arg,
+					  struct boot_params *boot_params);
+asmlinkage void efi_handover_entry(efi_handle_t handle,
+				   efi_system_table_t *sys_table_arg,
+				   struct boot_params *boot_params);
+
 #ifdef CONFIG_X86_64
 efi_status_t efi_setup_5level_paging(void);
 void efi_5level_switch(void);
-- 
2.55.0


  reply	other threads:[~2026-10-06 20:42 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-10-06 20:42 [PATCH v1 0/3] efi/libstub: Build the x86 stub from KBUILD_CFLAGS Kees Cook
2026-10-06 20:42 ` Kees Cook [this message]
2026-10-06 20:42 ` [PATCH v1 2/3] " Kees Cook
2026-10-07  9:20   ` Nathan Chancellor
2026-10-06 20:42 ` [PATCH v1 3/3] efi/libstub: Disable kernel stack erasing in the common flags Kees Cook
2026-10-07  9:21   ` Nathan Chancellor
2026-10-08 14:43 ` [PATCH v1 0/3] efi/libstub: Build the x86 stub from KBUILD_CFLAGS Ard Biesheuvel

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20261006204224.1536491-1-kees@kernel.org \
    --to=kees@kernel.org \
    --cc=ardb@kernel.org \
    --cc=ilias.apalodimas@linaro.org \
    --cc=linux-efi@vger.kernel.org \
    --cc=linux-hardening@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.