Re: [PATCH v10 6/9] dt-bindings: clock: nxp,imx95-blk-ctl: Add ldb child node

[Conor Dooley <conor@kernel.org>]

[-- Attachment #1: Type: text/plain, Size: 1605 bytes --]

On Wed, Oct 07, 2026 at 04:57:45PM +0300, Laurentiu Palcu wrote:
> Hi Conor,
> 
> On Wed, Oct 07, 2026 at 02:12:52PM +0100, Conor Dooley wrote:
> > On Tue, Oct 06, 2026 at 12:22:01PM +0000, Laurentiu Palcu wrote:
> > > Since the BLK CTL registers, like the LVDS CSR, can be used to control the
> > > LVDS Display Bridge controllers, add 'ldb' child node to handle
> > > these use cases.
> > > 
> > > Signed-off-by: Laurentiu Palcu <laurentiu.palcu@oss.nxp.com>
> > > ---
> > >  .../bindings/clock/nxp,imx95-blk-ctl.yaml          | 24 +++++++++++++++++++++-
> > >  1 file changed, 23 insertions(+), 1 deletion(-)
> > > 
> > > diff --git a/Documentation/devicetree/bindings/clock/nxp,imx95-blk-ctl.yaml b/Documentation/devicetree/bindings/clock/nxp,imx95-blk-ctl.yaml
> > > index fbbf1b3f17904..97fe816a38f94 100644
> > > --- a/Documentation/devicetree/bindings/clock/nxp,imx95-blk-ctl.yaml
> > > +++ b/Documentation/devicetree/bindings/clock/nxp,imx95-blk-ctl.yaml
> > > @@ -51,6 +51,10 @@ patternProperties:
> > >      $ref: /schemas/media/fsl,imx95-csi-formatter.yaml#
> > >      unevaluatedProperties: false
> > >  
> > > +  '^ldb@[0-9a-f]+$':
> > > +    type: object
> > > +    $ref: /schemas/display/bridge/fsl,ldb.yaml#
> > 
> > The class of device is bridge, why not use that here?
> 
> I'm sorry, your question is a bit vague... Are you referring to renaming
> the pattern to '^bridge@[0-9a-f]+$'? If yes, I don't have strong
> opinions against it. I can do it in the next iteration.

Yes, sorry.
That'd be great.

Thanks,
Conor.

pw-bot: changes-requested


[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]