From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by smtp.lore.kernel.org (Postfix) with ESMTP id DF719CA5FF1 for ; Wed, 7 Oct 2026 08:12:12 +0000 (UTC) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id C546742EBA; Wed, 7 Oct 2026 10:11:39 +0200 (CEST) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by mails.dpdk.org (Postfix) with ESMTP id 8882B42EBA for ; Wed, 7 Oct 2026 10:11:38 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1791360698; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=LmM70JCODERRQTnJNLUmCTyuDR2Anbfx7GLqnPuyQJA=; b=h4+cldTDm2/0auNYTEIZ4a3oT6FJbehP13a+iPejITk5wKhoqtJ5VNUjeHbLa2TJIAxCZ7 tZ103rVeBlQSCbypv0pFJ0zeH7NOoR3hD7e559d3wp5u6Z11+Hwva8X8EgpVxmeUDLrr+2 k2sTrrYy46YYsC3Gs7D/K0Ykad2iFFg= Received: from mx-prod-mc-06.mail-002.prod.us-west-2.aws.redhat.com (ec2-35-165-154-97.us-west-2.compute.amazonaws.com [35.165.154.97]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-663-mXJIzaA1MoiiWSOf80xeug-1; Wed, 07 Oct 2026 04:11:35 -0400 X-MC-Unique: mXJIzaA1MoiiWSOf80xeug-1 X-Mimecast-MFC-AGG-ID: mXJIzaA1MoiiWSOf80xeug_1791360694 Received: from mx-prod-int-06.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-06.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.93]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-06.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id DA5641800DBB; Wed, 7 Oct 2026 08:11:33 +0000 (UTC) Received: from dmarchan.redhat.corp (headnet03.pony-001.prod.iad2.dc.redhat.com [10.2.32.114]) by mx-prod-int-06.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTP id 24BCB180057E; Wed, 7 Oct 2026 08:11:31 +0000 (UTC) From: David Marchand To: dev@dpdk.org Cc: Anatoly Burakov , Maxime Coquelin , Chenbo Xia , Matan Azrad , Viacheslav Ovsiienko Subject: [RESEND][PATCH v19 16/26] vhost: remove group-related API from driver Date: Wed, 7 Oct 2026 10:10:13 +0200 Message-ID: <20261007081026.574382-17-david.marchand@redhat.com> In-Reply-To: <20261007081026.574382-1-david.marchand@redhat.com> References: <20261007081026.574382-1-david.marchand@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 3.4.1 on 10.30.177.93 X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: Kuj9EnzWbwqsRtowf3NxBPW0J0VeXsemLUm-JhXrANk_1791360694 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: 8bit content-type: text/plain; charset="US-ASCII"; x-default=true X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org From: Anatoly Burakov The vDPA driver API has "get_vfio_group_fd" in its ops structure, but no driver is using it any more, as better API's were added and implemented. Remove this API from vDPA ops structure. Signed-off-by: Anatoly Burakov --- Changes since v18: - squashed vdpa/mlx5 update, --- doc/guides/prog_guide/vhost_lib.rst | 4 ---- doc/guides/rel_notes/deprecation.rst | 4 ---- doc/guides/rel_notes/release_26_11.rst | 3 +++ drivers/vdpa/mlx5/mlx5_vdpa.c | 1 - lib/vhost/vdpa_driver.h | 3 --- 5 files changed, 3 insertions(+), 12 deletions(-) diff --git a/doc/guides/prog_guide/vhost_lib.rst b/doc/guides/prog_guide/vhost_lib.rst index 345a621716..99355b8afd 100644 --- a/doc/guides/prog_guide/vhost_lib.rst +++ b/doc/guides/prog_guide/vhost_lib.rst @@ -471,10 +471,6 @@ Finally, a set of device ops is defined for device specific operations: Called to allow the device to respond to RARP sending. -* ``get_vfio_group_fd`` - - Called to get the VFIO group fd of the device. - * ``get_vfio_device_fd`` Called to get the VFIO device fd of the device. diff --git a/doc/guides/rel_notes/deprecation.rst b/doc/guides/rel_notes/deprecation.rst index fad4ffc72c..49ee85fa4e 100644 --- a/doc/guides/rel_notes/deprecation.rst +++ b/doc/guides/rel_notes/deprecation.rst @@ -29,10 +29,6 @@ Deprecation Notices Use the ``-S `` parameter instead to specify the cores to be used for background services in DPDK. -* vdpa: The vDPA driver API will no longer offer ``get_vfio_group_fd`` - as part of its internal API. All drivers will be adjusted - to use the new unified VFIO container device assignment API. - * rte_smp_*mb: These APIs provide full barrier functionality. However, many use cases do not require full barriers. To support such use cases, DPDK has adopted atomic operations from diff --git a/doc/guides/rel_notes/release_26_11.rst b/doc/guides/rel_notes/release_26_11.rst index b33d904c9b..25e864cf53 100644 --- a/doc/guides/rel_notes/release_26_11.rst +++ b/doc/guides/rel_notes/release_26_11.rst @@ -344,6 +344,9 @@ API Changes ``rte_reorder_seqn``, ``rte_reorder_drain_up_to_seqn``, ``rte_reorder_min_seqn_set`` and ``rte_reorder_memory_footprint_get``. +* vhost: Removed ``get_vfio_group_fd`` from ``struct rte_vdpa_dev_ops``. + vDPA drivers should now use the VFIO container device assignment API. + * telemetry: Promoted the following API from experimental to stable: * ``rte_tel_data_add_array_uint_hex`` diff --git a/drivers/vdpa/mlx5/mlx5_vdpa.c b/drivers/vdpa/mlx5/mlx5_vdpa.c index 11708e2005..1bb5de51b6 100644 --- a/drivers/vdpa/mlx5/mlx5_vdpa.c +++ b/drivers/vdpa/mlx5/mlx5_vdpa.c @@ -523,7 +523,6 @@ static struct rte_vdpa_dev_ops mlx5_vdpa_ops = { .set_vring_state = mlx5_vdpa_set_vring_state, .set_features = mlx5_vdpa_features_set, .migration_done = NULL, - .get_vfio_group_fd = NULL, .get_vfio_device_fd = mlx5_vdpa_get_device_fd, .get_notify_area = mlx5_vdpa_get_notify_area, .get_stats_names = mlx5_vdpa_get_stats_names, diff --git a/lib/vhost/vdpa_driver.h b/lib/vhost/vdpa_driver.h index 42392a0d14..c7b9be09fb 100644 --- a/lib/vhost/vdpa_driver.h +++ b/lib/vhost/vdpa_driver.h @@ -50,9 +50,6 @@ struct rte_vdpa_dev_ops { /** Destination operations when migration done */ int (*migration_done)(int vid); - /** Get the vfio group fd */ - int (*get_vfio_group_fd)(int vid); - /** Get the vfio device fd */ int (*get_vfio_device_fd)(int vid); -- 2.54.0