From: Joonhoe Kim <26rote@gmail.com>
To: robin.clark@oss.qualcomm.com, lumag@kernel.org
Cc: abhinav.kumar@linux.dev, jesszhan0024@gmail.com, sean@poorly.run,
marijn.suijten@somainline.org, airlied@gmail.com,
simona@ffwll.ch, yongxing.mou@oss.qualcomm.com,
yuanjie.yang@oss.qualcomm.com, linux-arm-msm@vger.kernel.org,
dri-devel@lists.freedesktop.org, freedreno@lists.freedesktop.org,
linux-kernel@vger.kernel.org
Subject: [PATCH] drm/msm/dpu: add the SSPP rec0/rec1 blocks to the snapshot
Date: Wed, 7 Oct 2026 21:39:45 +0900 [thread overview]
Message-ID: <20261007123945.1694-1-26rote@gmail.com> (raw)
On DPU 13 the SSPP block is only 0x84 long and the fetch registers
(source address, size, format, multirect) live in the rec0/rec1
sub-blocks at 0x1000 and 0x3000. The snapshot dumps the SSPP block and
its scaler and CSC sub-blocks, but not rec0/rec1, so the plane fetch
state is missing from the devcoredump and from debugfs dri/N/kms.
Add the rec0/rec1 sub-blocks to the snapshot.
Tested on a Lenovo Legion Tab Y700 gen 5 (SM8850).
Fixes: 688c7734002a ("drm/msm/dpu: Add Kaanapali SSPP sub-block support")
Assisted-by: LLM
Signed-off-by: Joonhoe Kim <26rote@gmail.com>
---
drivers/gpu/drm/msm/disp/dpu1/dpu_kms.c | 14 ++++++++++++++
1 file changed, 14 insertions(+)
diff --git a/drivers/gpu/drm/msm/disp/dpu1/dpu_kms.c b/drivers/gpu/drm/msm/disp/dpu1/dpu_kms.c
index da3556eb6ecc..dba8a07d34bb 100644
--- a/drivers/gpu/drm/msm/disp/dpu1/dpu_kms.c
+++ b/drivers/gpu/drm/msm/disp/dpu1/dpu_kms.c
@@ -1006,6 +1006,20 @@ static void dpu_kms_mdp_snapshot(struct msm_disp_state *disp_state, struct msm_k
base + cat->sspp[i].sblk->csc_blk.base,
"%s_%s", cat->sspp[i].name,
cat->sspp[i].sblk->csc_blk.name);
+
+ if (cat->sspp[i].sblk && cat->sspp[i].sblk->sspp_rec0_blk.len > 0)
+ msm_disp_snapshot_add_block(disp_state,
+ cat->sspp[i].sblk->sspp_rec0_blk.len,
+ base + cat->sspp[i].sblk->sspp_rec0_blk.base,
+ "%s_%s", cat->sspp[i].name,
+ cat->sspp[i].sblk->sspp_rec0_blk.name);
+
+ if (cat->sspp[i].sblk && cat->sspp[i].sblk->sspp_rec1_blk.len > 0)
+ msm_disp_snapshot_add_block(disp_state,
+ cat->sspp[i].sblk->sspp_rec1_blk.len,
+ base + cat->sspp[i].sblk->sspp_rec1_blk.base,
+ "%s_%s", cat->sspp[i].name,
+ cat->sspp[i].sblk->sspp_rec1_blk.name);
}
/* dump LM sub-blocks HW regs info */
base-commit: 6375e61c01e93e35ee7acd336a689ac1fae4b509
--
2.43.0
next reply other threads:[~2026-10-07 13:51 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-10-07 12:39 Joonhoe Kim [this message]
2026-10-07 13:41 ` [PATCH] drm/msm/dpu: add the SSPP rec0/rec1 blocks to the snapshot Dmitry Baryshkov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20261007123945.1694-1-26rote@gmail.com \
--to=26rote@gmail.com \
--cc=abhinav.kumar@linux.dev \
--cc=airlied@gmail.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=freedreno@lists.freedesktop.org \
--cc=jesszhan0024@gmail.com \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=lumag@kernel.org \
--cc=marijn.suijten@somainline.org \
--cc=robin.clark@oss.qualcomm.com \
--cc=sean@poorly.run \
--cc=simona@ffwll.ch \
--cc=yongxing.mou@oss.qualcomm.com \
--cc=yuanjie.yang@oss.qualcomm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.