From: Cezary Rojewski <cezary.rojewski@intel.com>
To: broonie@kernel.org, linux-sound@vger.kernel.org
Cc: tiwai@suse.com, perex@perex.cz, amade@asmblr.net,
linux-kernel@vger.kernel.org, kuninori.morimoto.gx@renesas.com,
Cezary Rojewski <cezary.rojewski@intel.com>
Subject: [PATCH 4/7] ASoC: topology-test: Switch to snd_snd_component_new()
Date: Wed, 7 Oct 2026 15:33:50 +0200 [thread overview]
Message-ID: <20261007133353.455185-5-cezary.rojewski@intel.com> (raw)
In-Reply-To: <20261007133353.455185-1-cezary.rojewski@intel.com>
snd_soc_component_alloc() leaves the component object in uninitialized
state. Switch to the constructor function to retrieve and operate on
object in sane state.
Cc: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>
Signed-off-by: Cezary Rojewski <cezary.rojewski@intel.com>
---
sound/soc/soc-topology-test.c | 66 +++++++++++++++++------------------
1 file changed, 33 insertions(+), 33 deletions(-)
diff --git a/sound/soc/soc-topology-test.c b/sound/soc/soc-topology-test.c
index 346a52d3006a..bcfb52061133 100644
--- a/sound/soc/soc-topology-test.c
+++ b/sound/soc/soc-topology-test.c
@@ -246,8 +246,8 @@ static void snd_soc_tplg_test_load_with_null_comp(struct kunit *test)
kunit_comp->card.num_links = ARRAY_SIZE(kunit_dai_links);
kunit_comp->card.fully_routed = true;
- component = snd_soc_component_alloc(test_dev);
- KUNIT_ASSERT_NOT_NULL(test, component);
+ component = snd_soc_component_new(test_dev, NULL, &test_component_null_comp);
+ KUNIT_ASSERT_NOT_ERR_OR_NULL(test, component);
snd_soc_component_set_priv(component, kunit_comp);
@@ -256,7 +256,7 @@ static void snd_soc_tplg_test_load_with_null_comp(struct kunit *test)
if (ret != 0 && ret != -EPROBE_DEFER)
KUNIT_FAIL(test, "Failed to register card");
- ret = snd_soc_register_component(component, &test_component_null_comp, NULL, 0);
+ ret = snd_soc_component_register(component, NULL, 0);
KUNIT_EXPECT_EQ(test, 0, ret);
/* cleanup */
@@ -291,8 +291,8 @@ static void snd_soc_tplg_test_load_with_null_ops(struct kunit *test)
kunit_comp->card.num_links = ARRAY_SIZE(kunit_dai_links);
kunit_comp->card.fully_routed = true;
- component = snd_soc_component_alloc(test_dev);
- KUNIT_ASSERT_NOT_NULL(test, component);
+ component = snd_soc_component_new(test_dev, NULL, &test_component);
+ KUNIT_ASSERT_NOT_ERR_OR_NULL(test, component);
snd_soc_component_set_priv(component, kunit_comp);
@@ -301,7 +301,7 @@ static void snd_soc_tplg_test_load_with_null_ops(struct kunit *test)
if (ret != 0 && ret != -EPROBE_DEFER)
KUNIT_FAIL(test, "Failed to register card");
- ret = snd_soc_register_component(component, &test_component, NULL, 0);
+ ret = snd_soc_component_register(component, NULL, 0);
KUNIT_EXPECT_EQ(test, 0, ret);
/* cleanup */
@@ -355,8 +355,8 @@ static void snd_soc_tplg_test_load_with_null_fw(struct kunit *test)
kunit_comp->card.num_links = ARRAY_SIZE(kunit_dai_links);
kunit_comp->card.fully_routed = true;
- component = snd_soc_component_alloc(test_dev);
- KUNIT_ASSERT_NOT_NULL(test, component);
+ component = snd_soc_component_new(test_dev, NULL, &test_component_null_fw);
+ KUNIT_ASSERT_NOT_ERR_OR_NULL(test, component);
snd_soc_component_set_priv(component, kunit_comp);
@@ -365,7 +365,7 @@ static void snd_soc_tplg_test_load_with_null_fw(struct kunit *test)
if (ret != 0 && ret != -EPROBE_DEFER)
KUNIT_FAIL(test, "Failed to register card");
- ret = snd_soc_register_component(component, &test_component_null_fw, NULL, 0);
+ ret = snd_soc_component_register(component, NULL, 0);
KUNIT_EXPECT_EQ(test, 0, ret);
/* cleanup */
@@ -406,8 +406,8 @@ static void snd_soc_tplg_test_load_empty_tplg(struct kunit *test)
kunit_comp->card.num_links = ARRAY_SIZE(kunit_dai_links);
kunit_comp->card.fully_routed = true;
- component = snd_soc_component_alloc(test_dev);
- KUNIT_ASSERT_NOT_NULL(test, component);
+ component = snd_soc_component_new(test_dev, NULL, &test_component);
+ KUNIT_ASSERT_NOT_ERR_OR_NULL(test, component);
snd_soc_component_set_priv(component, kunit_comp);
@@ -416,7 +416,7 @@ static void snd_soc_tplg_test_load_empty_tplg(struct kunit *test)
if (ret != 0 && ret != -EPROBE_DEFER)
KUNIT_FAIL(test, "Failed to register card");
- ret = snd_soc_register_component(component, &test_component, NULL, 0);
+ ret = snd_soc_component_register(component, NULL, 0);
KUNIT_EXPECT_EQ(test, 0, ret);
/* cleanup */
@@ -464,8 +464,8 @@ static void snd_soc_tplg_test_load_empty_tplg_bad_magic(struct kunit *test)
kunit_comp->card.num_links = ARRAY_SIZE(kunit_dai_links);
kunit_comp->card.fully_routed = true;
- component = snd_soc_component_alloc(test_dev);
- KUNIT_ASSERT_NOT_NULL(test, component);
+ component = snd_soc_component_new(test_dev, NULL, &test_component);
+ KUNIT_ASSERT_NOT_ERR_OR_NULL(test, component);
snd_soc_component_set_priv(component, kunit_comp);
@@ -474,7 +474,7 @@ static void snd_soc_tplg_test_load_empty_tplg_bad_magic(struct kunit *test)
if (ret != 0 && ret != -EPROBE_DEFER)
KUNIT_FAIL(test, "Failed to register card");
- ret = snd_soc_register_component(component, &test_component, NULL, 0);
+ ret = snd_soc_component_register(component, NULL, 0);
KUNIT_EXPECT_EQ(test, 0, ret);
/* cleanup */
@@ -522,8 +522,8 @@ static void snd_soc_tplg_test_load_empty_tplg_bad_abi(struct kunit *test)
kunit_comp->card.num_links = ARRAY_SIZE(kunit_dai_links);
kunit_comp->card.fully_routed = true;
- component = snd_soc_component_alloc(test_dev);
- KUNIT_ASSERT_NOT_NULL(test, component);
+ component = snd_soc_component_new(test_dev, NULL, &test_component);
+ KUNIT_ASSERT_NOT_ERR_OR_NULL(test, component);
snd_soc_component_set_priv(component, kunit_comp);
@@ -532,7 +532,7 @@ static void snd_soc_tplg_test_load_empty_tplg_bad_abi(struct kunit *test)
if (ret != 0 && ret != -EPROBE_DEFER)
KUNIT_FAIL(test, "Failed to register card");
- ret = snd_soc_register_component(component, &test_component, NULL, 0);
+ ret = snd_soc_component_register(component, NULL, 0);
KUNIT_EXPECT_EQ(test, 0, ret);
/* cleanup */
@@ -580,8 +580,8 @@ static void snd_soc_tplg_test_load_empty_tplg_bad_size(struct kunit *test)
kunit_comp->card.num_links = ARRAY_SIZE(kunit_dai_links);
kunit_comp->card.fully_routed = true;
- component = snd_soc_component_alloc(test_dev);
- KUNIT_ASSERT_NOT_NULL(test, component);
+ component = snd_soc_component_new(test_dev, NULL, &test_component);
+ KUNIT_ASSERT_NOT_ERR_OR_NULL(test, component);
snd_soc_component_set_priv(component, kunit_comp);
@@ -590,7 +590,7 @@ static void snd_soc_tplg_test_load_empty_tplg_bad_size(struct kunit *test)
if (ret != 0 && ret != -EPROBE_DEFER)
KUNIT_FAIL(test, "Failed to register card");
- ret = snd_soc_register_component(component, &test_component, NULL, 0);
+ ret = snd_soc_component_register(component, NULL, 0);
KUNIT_EXPECT_EQ(test, 0, ret);
/* cleanup */
@@ -639,8 +639,8 @@ static void snd_soc_tplg_test_load_empty_tplg_bad_payload_size(struct kunit *tes
kunit_comp->card.num_links = ARRAY_SIZE(kunit_dai_links);
kunit_comp->card.fully_routed = true;
- component = snd_soc_component_alloc(test_dev);
- KUNIT_ASSERT_NOT_NULL(test, component);
+ component = snd_soc_component_new(test_dev, NULL, &test_component);
+ KUNIT_ASSERT_NOT_ERR_OR_NULL(test, component);
snd_soc_component_set_priv(component, kunit_comp);
@@ -649,7 +649,7 @@ static void snd_soc_tplg_test_load_empty_tplg_bad_payload_size(struct kunit *tes
if (ret != 0 && ret != -EPROBE_DEFER)
KUNIT_FAIL(test, "Failed to register card");
- ret = snd_soc_register_component(component, &test_component, NULL, 0);
+ ret = snd_soc_component_register(component, NULL, 0);
KUNIT_EXPECT_EQ(test, 0, ret);
/* cleanup */
@@ -690,8 +690,8 @@ static void snd_soc_tplg_test_load_pcm_tplg(struct kunit *test)
kunit_comp->card.num_links = ARRAY_SIZE(kunit_dai_links);
kunit_comp->card.fully_routed = true;
- component = snd_soc_component_alloc(test_dev);
- KUNIT_ASSERT_NOT_NULL(test, component);
+ component = snd_soc_component_new(test_dev, NULL, &test_component);
+ KUNIT_ASSERT_NOT_ERR_OR_NULL(test, component);
snd_soc_component_set_priv(component, kunit_comp);
@@ -700,7 +700,7 @@ static void snd_soc_tplg_test_load_pcm_tplg(struct kunit *test)
if (ret != 0 && ret != -EPROBE_DEFER)
KUNIT_FAIL(test, "Failed to register card");
- ret = snd_soc_register_component(component, &test_component, NULL, 0);
+ ret = snd_soc_component_register(component, NULL, 0);
KUNIT_EXPECT_EQ(test, 0, ret);
snd_soc_unregister_component(test_dev);
@@ -743,8 +743,8 @@ static void snd_soc_tplg_test_load_pcm_tplg_reload_comp(struct kunit *test)
kunit_comp->card.num_links = ARRAY_SIZE(kunit_dai_links);
kunit_comp->card.fully_routed = true;
- component = snd_soc_component_alloc(test_dev);
- KUNIT_ASSERT_NOT_NULL(test, component);
+ component = snd_soc_component_new(test_dev, NULL, &test_component);
+ KUNIT_ASSERT_NOT_ERR_OR_NULL(test, component);
snd_soc_component_set_priv(component, kunit_comp);
@@ -755,7 +755,7 @@ static void snd_soc_tplg_test_load_pcm_tplg_reload_comp(struct kunit *test)
for (i = 0; i < 100; i++) {
- ret = snd_soc_register_component(component, &test_component, NULL, 0);
+ ret = snd_soc_component_register(component, NULL, 0);
KUNIT_EXPECT_EQ(test, 0, ret);
snd_soc_unregister_component(test_dev);
@@ -799,13 +799,13 @@ static void snd_soc_tplg_test_load_pcm_tplg_reload_card(struct kunit *test)
kunit_comp->card.num_links = ARRAY_SIZE(kunit_dai_links);
kunit_comp->card.fully_routed = true;
- component = snd_soc_component_alloc(test_dev);
- KUNIT_ASSERT_NOT_NULL(test, component);
+ component = snd_soc_component_new(test_dev, NULL, &test_component);
+ KUNIT_ASSERT_NOT_ERR_OR_NULL(test, component);
snd_soc_component_set_priv(component, kunit_comp);
/* run test */
- ret = snd_soc_register_component(component, &test_component, NULL, 0);
+ ret = snd_soc_component_register(component, NULL, 0);
KUNIT_EXPECT_EQ(test, 0, ret);
for (i = 0; i < 100; i++) {
--
2.34.1
next prev parent reply other threads:[~2026-10-07 13:28 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-10-07 13:33 [PATCH 0/7] ASoC: core: Create new components in sane state Cezary Rojewski
2026-10-07 13:33 ` [PATCH 1/7] ASoC: core: Add component constructor Cezary Rojewski
2026-10-07 13:33 ` [PATCH 2/7] ASoC: core: Rename and export soc_component_add() Cezary Rojewski
2026-10-07 13:33 ` [PATCH 3/7] ASoC: dmaengine: Switch to snd_snd_component_new() Cezary Rojewski
2026-10-07 13:33 ` Cezary Rojewski [this message]
2026-10-07 13:33 ` [PATCH 5/7] ASoC: Intel: catpt: " Cezary Rojewski
2026-10-07 13:33 ` [PATCH 6/7] ASoC: Intel: avs: " Cezary Rojewski
2026-10-07 13:33 ` [PATCH 7/7] ASoC: core: Remove unused component-register members Cezary Rojewski
2026-10-12 22:58 ` [PATCH 0/7] ASoC: core: Create new components in sane state Mark Brown
2026-10-12 23:52 ` Kuninori Morimoto
2026-10-13 10:53 ` Mark Brown
2026-10-13 11:24 ` Cezary Rojewski
2026-10-13 12:44 ` Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20261007133353.455185-5-cezary.rojewski@intel.com \
--to=cezary.rojewski@intel.com \
--cc=amade@asmblr.net \
--cc=broonie@kernel.org \
--cc=kuninori.morimoto.gx@renesas.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-sound@vger.kernel.org \
--cc=perex@perex.cz \
--cc=tiwai@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.