From: Simon Horman <horms@kernel.org>
To: Sang-Hoon Choi <csh0052@gmail.com>
Cc: Edward Cree <ecree.xilinx@gmail.com>,
netdev@vger.kernel.org, linux-net-drivers@amd.com,
Alejandro Lucero <alejandro.lucero-palau@amd.com>,
Changyul Lee <lcy8047@gmail.com>
Subject: Re: [PATCH net] sfc: handle rhashtable walk errors in mport lookup
Date: Wed, 7 Oct 2026 15:44:59 +0100 [thread overview]
Message-ID: <20261007144459.GS83879@horms.kernel.org> (raw)
In-Reply-To: <20261003.final089.e0910b3ffb849fe4@gmail.com>
On Fri, Oct 02, 2026 at 07:47:40PM +0000, Sang-Hoon Choi wrote:
> rhashtable_walk_next() can return ERR_PTR(-EAGAIN) when the table is
> resized. efx_mae_lookup_mport() currently dereferences that value as an
> mport descriptor.
>
> Skip error values and continue the walk, as the other rhashtable walkers
> in this driver already do.
>
> Fixes: 5227adff37af ("sfc: add mport lookup based on driver's mport data")
> Reported-by: Changyul Lee <lcy8047@gmail.com>
> Assisted-by: LLM
> Signed-off-by: Sang-Hoon Choi <csh0052@gmail.com>
> ---
> Compile-tested the affected object with x86_64 allmodconfig
> and W=1 (GCC 13.3.0). Base: mainline 3b7cab693ba2bab63774bf5b988e8a61b2ef0f32.
> No hardware testing or runtime failure reproduction was performed.
Reviewed-by: Simon Horman <horms@kernel.org>
next prev parent reply other threads:[~2026-10-07 14:45 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-10-02 19:47 [PATCH net] sfc: handle rhashtable walk errors in mport lookup Sang-Hoon Choi
2026-10-07 14:44 ` Simon Horman [this message]
2026-10-07 23:50 ` patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20261007144459.GS83879@horms.kernel.org \
--to=horms@kernel.org \
--cc=alejandro.lucero-palau@amd.com \
--cc=csh0052@gmail.com \
--cc=ecree.xilinx@gmail.com \
--cc=lcy8047@gmail.com \
--cc=linux-net-drivers@amd.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.