From: Simon Horman <horms@kernel.org>
To: iugfdin <iugfdin@proton.me>
Cc: netdev@vger.kernel.org, Heiner Kallweit <hkallweit1@gmail.com>,
nic_swsd@realtek.com, Andrew Lunn <andrew+netdev@lunn.ch>,
"David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@kernel.org>,
Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>
Subject: Re: [PATCH net 2/2] r8169: flush pending transmit packets when an skb is dropped
Date: Wed, 7 Oct 2026 16:34:52 +0100 [thread overview]
Message-ID: <20261007153452.GW83879@horms.kernel.org> (raw)
In-Reply-To: <179098478410.1174319.17923728268629391314.r8169-2@proton.me>
On Sat, Oct 03, 2026 at 12:08:01AM +0000, iugfdin wrote:
> rtl8169_start_xmit() can defer a transmit poll when xmit_more is set.
> If a later skb fails preparation or DMA mapping, the shared error
> path drops it without issuing that deferred poll. If the failed skb
> ends the batch, previously committed packets can remain pending
> until another packet or recovery path kicks the device.
>
> Issue a transmit poll after cleaning up the failed skb so earlier
> packets can make progress. The failed skb still does not advance
> the producer index or contribute to BQL accounting.
>
> Fixes: ef14358546b1 ("r8169: make use of xmit_more")
> Assisted-by: LLM
> Signed-off-by: iugfdin <iugfdin@proton.me>
> ---
> Tested with W=1 driver-target builds on net under x86-64
> allmodconfig and allyesconfig, and source-executing ASan/UBSan
> checks with modeled kernel/DMA/MMIO boundaries. No physical
> Realtek NIC was available; this is not an on-device test claim.
Reviewed-by: Simon Horman <horms@kernel.org>
next prev parent reply other threads:[~2026-10-07 15:34 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-10-03 0:07 [PATCH net 0/2] r8169: fix checksum eligibility and failed TX batch progress iugfdin
2026-10-03 0:07 ` [PATCH net 1/2] r8169: preserve checksum offload when packet padding is unnecessary iugfdin
2026-10-07 15:34 ` Simon Horman
2026-10-08 0:27 ` Jakub Kicinski
2026-10-03 0:08 ` [PATCH net 2/2] r8169: flush pending transmit packets when an skb is dropped iugfdin
2026-10-07 15:34 ` Simon Horman [this message]
2026-10-11 12:30 ` [PATCH net 0/2] r8169: fix checksum eligibility and failed TX batch progress Geert Uytterhoeven
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20261007153452.GW83879@horms.kernel.org \
--to=horms@kernel.org \
--cc=andrew+netdev@lunn.ch \
--cc=davem@davemloft.net \
--cc=edumazet@kernel.org \
--cc=hkallweit1@gmail.com \
--cc=iugfdin@proton.me \
--cc=kuba@kernel.org \
--cc=netdev@vger.kernel.org \
--cc=nic_swsd@realtek.com \
--cc=pabeni@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.