From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id AE17DCA6004 for ; Wed, 7 Oct 2026 21:14:25 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 30CB110E6CC; Wed, 7 Oct 2026 21:14:25 +0000 (UTC) Authentication-Results: gabe.freedesktop.org; dkim=pass (2048-bit key; unprotected) header.d=intel.com header.i=@intel.com header.b="C5umtd/S"; dkim-atps=neutral Received: from mgamail.intel.com (mgamail.intel.com [192.198.163.9]) by gabe.freedesktop.org (Postfix) with ESMTPS id A2B1710E6CC for ; Wed, 7 Oct 2026 21:14:23 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1791407663; x=1822943663; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=5IWEmCANRkoEzQuHlYJV+ArVg3BfHzvO4+BC8XXI8zg=; b=C5umtd/SI7MJbgrK5O5hVMQYKVwFCuN6DGnw/m2gdDWE5a1YnUwt3DQB +L5nt22TSayVurm5Op9ltRj2lzmK3W2TufeI6no0AIjR6ZGTkt1KLpPYA vr3LODWIll0o9GPey4yLiyagCm9ERR7WBs29KqIlxpFaWxYiPfVwY20mz gq2PkpzUQo7mRn3xZZoCRdtyYEnOwelhhXMVKlGniIzXHIXaTkDVZBVW+ yFqUz+9NFKfjmo6GId5tgIl7fjfx9UOcGgA+oTSrunBWPcefr4jYfc1fO o7Mx4OQ/WS8dez4S6FLBKZ7UKch24Cd14Ms6HrIt9DLocyp5AOzFM4Ohm g==; X-CSE-ConnectionGUID: 3I0BRkxDRmy25XxXaKwwlg== X-CSE-MsgGUID: xvGOrNF2QB+T0MmPc6/xUw== X-IronPort-AV: E=McAfee;i="6800,10657,11928"; a="77153" X-IronPort-AV: E=Sophos;i="6.27,145,1787036400"; d="scan'208";a="77153" Received: from fmviesa001.fm.intel.com ([10.60.135.141]) by fmvoesa103.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 07 Oct 2026 14:14:23 -0700 X-CSE-ConnectionGUID: k9qjtvYnQaOzCDQTInxOcQ== X-CSE-MsgGUID: wllTmn0yThygrZf2YYHz8g== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.27,145,1787036400"; d="scan'208";a="305526778" Received: from dbhadane-mobl1.iind.intel.com ([10.190.239.58]) by fmviesa001.fm.intel.com with ESMTP; 07 Oct 2026 14:14:22 -0700 From: Dnyaneshwar Bhadane To: intel-xe@lists.freedesktop.org Cc: mallesh.koujalagi@intel.com, Dnyaneshwar Bhadane Subject: [PATCH v5 02/12] drm/xe/ggtt: Report GGTT errors using structured logging Date: Thu, 8 Oct 2026 02:44:07 +0530 Message-ID: <20261007211417.2093611-3-dnyaneshwar.bhadane@intel.com> X-Mailer: git-send-email 2.54.0 In-Reply-To: <20261007211417.2093611-1-dnyaneshwar.bhadane@intel.com> References: <20261007211417.2093611-1-dnyaneshwar.bhadane@intel.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-BeenThere: intel-xe@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Intel Xe graphics driver List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-xe-bounces@lists.freedesktop.org Sender: "Intel-xe" Replace xe_tile_err() calls with xe_log_err_fatal() using the GGTT component tag in GGTT initialization error paths. Signed-off-by: Dnyaneshwar Bhadane Reviewed-by: Mallesh Koujalagi --- drivers/gpu/drm/xe/xe_ggtt.c | 9 ++++++--- 1 file changed, 6 insertions(+), 3 deletions(-) diff --git a/drivers/gpu/drm/xe/xe_ggtt.c b/drivers/gpu/drm/xe/xe_ggtt.c index 63e8bf193605..773777afc68a 100644 --- a/drivers/gpu/drm/xe/xe_ggtt.c +++ b/drivers/gpu/drm/xe/xe_ggtt.c @@ -23,6 +23,7 @@ #include "xe_gt.h" #include "xe_gt_printk.h" #include "xe_gt_types.h" +#include "xe_log.h" #include "xe_map.h" #include "xe_mmio.h" #include "xe_pat.h" @@ -403,7 +404,8 @@ int xe_ggtt_init_early(struct xe_ggtt *ggtt) else gsm_size = probe_gsm_size(pdev); if (gsm_size == 0) { - xe_tile_err(ggtt->tile, "Hardware reported no preallocated GSM\n"); + xe_log_err_fatal(ggtt->tile, GGTT, -ENOMEM, + "Hardware reported no preallocated GSM\n"); return -ENOMEM; } ggtt_start = wopcm; @@ -414,8 +416,9 @@ int xe_ggtt_init_early(struct xe_ggtt *ggtt) if (ggtt_start < wopcm || ggtt_start + ggtt_size > GUC_GGTT_TOP) { - xe_tile_err(ggtt->tile, "Invalid GGTT configuration: %#llx-%#llx\n", - ggtt_start, ggtt_start + ggtt_size - 1); + xe_log_err_fatal(ggtt->tile, GGTT, -ERANGE, + "Invalid GGTT configuration: %#llx-%#llx\n", + ggtt_start, ggtt_start + ggtt_size - 1); return -ERANGE; } } -- 2.54.0