From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 8BF97CA6004 for ; Wed, 7 Oct 2026 21:14:29 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 3C57B10F7D5; Wed, 7 Oct 2026 21:14:29 +0000 (UTC) Authentication-Results: gabe.freedesktop.org; dkim=pass (2048-bit key; unprotected) header.d=intel.com header.i=@intel.com header.b="nZWDK3as"; dkim-atps=neutral Received: from mgamail.intel.com (mgamail.intel.com [192.198.163.9]) by gabe.freedesktop.org (Postfix) with ESMTPS id 6403E10F7D5 for ; Wed, 7 Oct 2026 21:14:27 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1791407667; x=1822943667; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=phfzyIYq6ZAqs9QKmkI5dAX4m/+4pGPL5oC5zP6jDqk=; b=nZWDK3asVz51EFIZ656vvFoN5ySHGdifHDgU6KUp3Q8EQsYy8Pmcmlxr HloXrYZYiFRigw4wzDTF1VWmbjBD9oAAKvuZPj1KbE8OCXWf7SHxzmik+ krkKtY19K9X5eJV5ACMLefX1751wS4cZnC9Gwz8vZ1pSU0JTCctk2ttVd eq1xUPUDR5UJeSwbxC+Qmr6HUk9W6gN5L9S1zuGDSMA6UkleM3YAXjE7V vHCO4b6dMnzEQJNL/kwqXNjuHtDzlLfP0grMXYBExGTIjBXocF9czgWNh hdv3eqxj8dJjjkKh75NVY1pKP0EY0oikf693IPGD4LnQ6f4ThqAfRJdgj w==; X-CSE-ConnectionGUID: 2Cz8K1WTQb28P3IJY55HKw== X-CSE-MsgGUID: 39b9+F4eRcqKTji2xQ+Ixw== X-IronPort-AV: E=McAfee;i="6800,10657,11928"; a="77160" X-IronPort-AV: E=Sophos;i="6.27,145,1787036400"; d="scan'208";a="77160" Received: from fmviesa001.fm.intel.com ([10.60.135.141]) by fmvoesa103.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 07 Oct 2026 14:14:27 -0700 X-CSE-ConnectionGUID: V+QN+GQlQ72S1mnVqfiOfA== X-CSE-MsgGUID: bCI05ixaQoe2iTFBC6racg== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.27,145,1787036400"; d="scan'208";a="305526810" Received: from dbhadane-mobl1.iind.intel.com ([10.190.239.58]) by fmviesa001.fm.intel.com with ESMTP; 07 Oct 2026 14:14:26 -0700 From: Dnyaneshwar Bhadane To: intel-xe@lists.freedesktop.org Cc: mallesh.koujalagi@intel.com, Dnyaneshwar Bhadane Subject: [PATCH v5 05/12] drm/xe/memirq: Report errors using structured xe_log API Date: Thu, 8 Oct 2026 02:44:10 +0530 Message-ID: <20261007211417.2093611-6-dnyaneshwar.bhadane@intel.com> X-Mailer: git-send-email 2.54.0 In-Reply-To: <20261007211417.2093611-1-dnyaneshwar.bhadane@intel.com> References: <20261007211417.2093611-1-dnyaneshwar.bhadane@intel.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-BeenThere: intel-xe@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Intel Xe graphics driver List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-xe-bounces@lists.freedesktop.org Sender: "Intel-xe" Replace memirq_err() calls with xe_log_err() using the MEMIRQ component tag for memory-based IRQ failures v2: - No need to log ERR_PTR(err) explicitly (Mallesh) - Using tile instead of xe for more local log location(sashiko bot) Signed-off-by: Dnyaneshwar Bhadane Reviewed-by: Mallesh Koujalagi --- drivers/gpu/drm/xe/xe_memirq.c | 7 ++++--- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/drivers/gpu/drm/xe/xe_memirq.c b/drivers/gpu/drm/xe/xe_memirq.c index 9dfe965cb46e..32b9f87a10ec 100644 --- a/drivers/gpu/drm/xe/xe_memirq.c +++ b/drivers/gpu/drm/xe/xe_memirq.c @@ -15,6 +15,7 @@ #include "xe_gt.h" #include "xe_guc.h" #include "xe_hw_engine.h" +#include "xe_log.h" #include "xe_memirq.h" #include "xe_tile_printk.h" @@ -232,7 +233,7 @@ static int memirq_alloc_pages(struct xe_memirq *memirq) return 0; out: - memirq_err(memirq, "Failed to allocate memirq page (%pe)\n", ERR_PTR(err)); + xe_log_err(tile, MEMIRQ, err, "Failed to allocate memirq page\n"); return err; } @@ -370,8 +371,8 @@ int xe_memirq_init_guc(struct xe_memirq *memirq, struct xe_guc *guc) return 0; failed: - memirq_err(memirq, "Failed to setup report pages in %s (%pe)\n", - guc_name(guc), ERR_PTR(err)); + xe_log_err(memirq_to_tile(memirq), MEMIRQ, err, + "Failed to setup report pages in %s\n", guc_name(guc)); return err; } -- 2.54.0