[PATCH 1/5] drm/i915/gmbus: Stop frobbing with pin direction in .getsda()/.getscl()

[Ville Syrjala <ville.syrjala@linux.intel.com>]

From: Ville Syrjälä <ville.syrjala@linux.intel.com>

i2c .getscl() and .getsda() are just supposed to report the state
of the pin without changing its state in any way. So nuke the
bogus register writes from there that configure the pin as an
input (ie. tri-state the pin).

Given how i2c works the pin will already be tri-stated when
.getsda()/.getscl() are called so these writes are in fact
redundant. And even if that weren't the case the input bit
does appear to reflect the state of the pin, even when driven
as an output.

Signed-off-by: Ville Syrjälä <ville.syrjala@linux.intel.com>
---
 drivers/gpu/drm/i915/display/intel_gmbus.c | 8 --------
 1 file changed, 8 deletions(-)

diff --git a/drivers/gpu/drm/i915/display/intel_gmbus.c b/drivers/gpu/drm/i915/display/intel_gmbus.c
index 13bc6ab6b2f6..d23422e12aa4 100644
--- a/drivers/gpu/drm/i915/display/intel_gmbus.c
+++ b/drivers/gpu/drm/i915/display/intel_gmbus.c
@@ -269,10 +269,6 @@ static int get_clock(void *data)
 {
 	struct intel_gmbus *bus = data;
 	struct intel_display *display = bus->display;
-	u32 reserved = get_reserved(bus);
-
-	intel_de_write_fw(display, bus->gpio_reg, reserved | GPIO_CLOCK_DIR_MASK);
-	intel_de_write_fw(display, bus->gpio_reg, reserved);
 
 	return (intel_de_read_fw(display, bus->gpio_reg) & GPIO_CLOCK_VAL_IN) != 0;
 }
@@ -281,10 +277,6 @@ static int get_data(void *data)
 {
 	struct intel_gmbus *bus = data;
 	struct intel_display *display = bus->display;
-	u32 reserved = get_reserved(bus);
-
-	intel_de_write_fw(display, bus->gpio_reg, reserved | GPIO_DATA_DIR_MASK);
-	intel_de_write_fw(display, bus->gpio_reg, reserved);
 
 	return (intel_de_read_fw(display, bus->gpio_reg) & GPIO_DATA_VAL_IN) != 0;
 }
-- 
2.55.0