From: David Yang <mmyangfl@gmail.com>
To: netdev@vger.kernel.org
Cc: David Yang <mmyangfl@gmail.com>,
Parthiban Veerasooran <parthiban.veerasooran@microchip.com>,
Andrew Lunn <andrew+netdev@lunn.ch>,
"David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@kernel.org>,
Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
Nicolai Buchwitz <nb@tipi-net.de>,
Maxime Chevallier <maxime.chevallier@bootlin.com>,
Jacob Keller <jacob.e.keller@intel.com>,
linux-kernel@vger.kernel.org
Subject: [PATCH net 10/10] microchip: lan865x: move setting of netops to fix crash
Date: Thu, 8 Oct 2026 10:26:52 +0800 [thread overview]
Message-ID: <20261008022656.3592191-11-mmyangfl@gmail.com> (raw)
In-Reply-To: <20261008022656.3592191-1-mmyangfl@gmail.com>
lan865x_probe() assigns netdev_ops only after oa_tc6_init(), which
connects the internal MAC-PHY through phy_connect_direct().
phy_attach_direct() -> phy_link_topo_add_phy() reads dev->netdev_ops
through netdev_need_ops_lock() since the commit in question, so probing
crashes with a NULL pointer dereference when CONFIG_NET_SHAPER is
enabled.
Assign netdev_ops before the PHY attach, as was done for emac in commit
7c9f391ec89c ("net: emac: move setting of netops to fix crash").
Fixes: ded86da4bbb7 ("net: ethtool: relax ethnl_req_get_phydev() locking assertion")
Signed-off-by: David Yang <mmyangfl@gmail.com>
---
drivers/net/ethernet/microchip/lan865x/lan865x.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/drivers/net/ethernet/microchip/lan865x/lan865x.c b/drivers/net/ethernet/microchip/lan865x/lan865x.c
index 26a2761332a5..633d00857774 100644
--- a/drivers/net/ethernet/microchip/lan865x/lan865x.c
+++ b/drivers/net/ethernet/microchip/lan865x/lan865x.c
@@ -346,6 +346,8 @@ static int lan865x_probe(struct spi_device *spi)
spi_set_drvdata(spi, priv);
INIT_WORK(&priv->multicast_work, lan865x_multicast_work_handler);
+ netdev->netdev_ops = &lan865x_netdev_ops;
+
priv->tc6 = oa_tc6_init(spi, netdev, NULL);
if (!priv->tc6) {
ret = -ENODEV;
@@ -397,7 +399,6 @@ static int lan865x_probe(struct spi_device *spi)
netdev->if_port = IF_PORT_10BASET;
netdev->irq = spi->irq;
- netdev->netdev_ops = &lan865x_netdev_ops;
netdev->ethtool_ops = &lan865x_ethtool_ops;
ret = register_netdev(netdev);
--
2.53.0
next prev parent reply other threads:[~2026-10-08 2:29 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-10-08 2:26 [PATCH net 00/10] net: Move setting of netops to fix crash David Yang
2026-10-08 2:26 ` [PATCH net 01/10] net: hisilicon: hisi_femac: " David Yang
2026-10-08 8:29 ` Maxime Chevallier
2026-10-08 11:51 ` Jijie Shao
2026-10-08 2:26 ` [PATCH net 02/10] net: hisilicon: hip04_eth: " David Yang
2026-10-08 8:30 ` Maxime Chevallier
2026-10-08 2:26 ` [PATCH net 03/10] net: ethernet: actions: " David Yang
2026-10-08 8:30 ` Maxime Chevallier
2026-10-08 2:26 ` [PATCH net 04/10] net: ethernet: adi: " David Yang
2026-10-08 8:30 ` Maxime Chevallier
2026-10-09 13:03 ` Regus, Ciprian
2026-10-08 2:26 ` [PATCH net 05/10] net: mv643xx: move " David Yang
2026-10-13 10:00 ` Daniel Machon
2026-10-08 2:26 ` [PATCH net 06/10] net: au1000: " David Yang
2026-10-08 8:31 ` Maxime Chevallier
2026-10-08 2:26 ` [PATCH net 07/10] net: ethoc: " David Yang
2026-10-08 8:31 ` Maxime Chevallier
2026-10-13 10:00 ` Daniel Machon
2026-10-08 2:26 ` [PATCH net 08/10] net: ethernet: aeroflex: " David Yang
2026-10-08 8:31 ` Maxime Chevallier
2026-10-09 14:34 ` Andreas Larsson
2026-10-08 2:26 ` [PATCH net 09/10] net: ti: icssm-prueth: Move " David Yang
2026-10-08 8:32 ` Maxime Chevallier
2026-10-08 2:26 ` David Yang [this message]
2026-10-08 8:32 ` [PATCH net 10/10] microchip: lan865x: move " Maxime Chevallier
2026-10-08 12:10 ` [PATCH net 00/10] net: Move " Jijie Shao
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20261008022656.3592191-11-mmyangfl@gmail.com \
--to=mmyangfl@gmail.com \
--cc=andrew+netdev@lunn.ch \
--cc=davem@davemloft.net \
--cc=edumazet@kernel.org \
--cc=jacob.e.keller@intel.com \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=maxime.chevallier@bootlin.com \
--cc=nb@tipi-net.de \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=parthiban.veerasooran@microchip.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.