All of lore.kernel.org
 help / color / mirror / Atom feed
From: Joshua Crofts <joshua.crofts1@gmail.com>
To: Alexis Bouzigues via B4 Relay
	<devnull+BouziguesAlexis.JohnDeere.com@kernel.org>
Cc: BouziguesAlexis@JohnDeere.com,
	"Jonathan Cameron" <jic23@kernel.org>,
	"Lucas Stankus" <lucas.p.stankus@gmail.com>,
	"Nuno Sá" <nuno.sa@analog.com>,
	"Michael Hennerich" <Michael.Hennerich@analog.com>,
	"David Lechner" <dlechner@baylibre.com>,
	"Andy Shevchenko" <andy@kernel.org>,
	"Lothar Rubusch" <l.rubusch@gmail.com>,
	linux@analog.com, linux-iio@vger.kernel.org,
	linux-kernel@vger.kernel.org, stable@vger.kernel.org
Subject: Re: [PATCH] iio: accel: adxl313: add missing buffer selections in Kconfig
Date: Thu, 8 Oct 2026 09:41:19 +0200	[thread overview]
Message-ID: <20261008094119.00003007@gmail.com> (raw)
In-Reply-To: <20261006-fix-adxl313-buffer-deps-review-v1-1-386006c407be@JohnDeere.com>

On Tue, 06 Oct 2026 19:08:58 -0500
Alexis Bouzigues via B4 Relay <devnull+BouziguesAlexis.JohnDeere.com@kernel.org> wrote:

> From: Alexis Bouzigues <BouziguesAlexis@JohnDeere.com>
> 
> The FIFO support added to the ADXL313 core uses
> devm_iio_kfifo_buffer_setup() and iio_push_to_buffers(), but its Kconfig
> entry does not select the required buffer support. Enabling either
> frontend without IIO_BUFFER or IIO_KFIFO_BUF causes undefined references
> to devm_iio_kfifo_buffer_setup_ext() and iio_push_to_buffers().
> 
> Select IIO_BUFFER and IIO_KFIFO_BUF from the shared ADXL313 core symbol
> so both the I2C and SPI frontends have the required dependencies.
> 
> Fixes: ff8093fa6ba4 ("iio: accel: adxl313: add buffered FIFO watermark with interrupt handling")
> Cc: stable@vger.kernel.org
> Assisted-by: LLM
> Signed-off-by: Alexis Bouzigues <BouziguesAlexis@JohnDeere.com>
> ---

Tested-by: Joshua Crofts <joshua.crofts1@gmail.com>
Reviewed-by: Joshua Crofts <joshua.crofts1@gmail.com>

If you're doing the same change for multiple drivers, please send it
as a series, it will make reviewing easier.

-- 
Kind regards,
Joshua Crofts

  reply	other threads:[~2026-10-08  7:41 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-10-07  0:08 [PATCH] iio: accel: adxl313: add missing buffer selections in Kconfig Alexis Bouzigues
2026-10-07  0:08 ` Alexis Bouzigues via B4 Relay
2026-10-08  7:41 ` Joshua Crofts [this message]
2026-10-12 14:30 ` Nuno Sá

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20261008094119.00003007@gmail.com \
    --to=joshua.crofts1@gmail.com \
    --cc=BouziguesAlexis@JohnDeere.com \
    --cc=Michael.Hennerich@analog.com \
    --cc=andy@kernel.org \
    --cc=devnull+BouziguesAlexis.JohnDeere.com@kernel.org \
    --cc=dlechner@baylibre.com \
    --cc=jic23@kernel.org \
    --cc=l.rubusch@gmail.com \
    --cc=linux-iio@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux@analog.com \
    --cc=lucas.p.stankus@gmail.com \
    --cc=nuno.sa@analog.com \
    --cc=stable@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.