From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-dy1-f174.google.com (mail-dy1-f174.google.com [74.125.82.174]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id A8025496D2A for ; Thu, 8 Oct 2026 10:41:50 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=74.125.82.174 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1791456111; cv=none; b=pzjd8mzgvzwG73Op2jV3dCnOhfeKKGz/gkG85p5lVx6nnsKkuOGwzw5xPZsMl/NzGF05d4ciPouXu5utguWhOTdtM8Vp7x/04JAHISIu7XSLAcoATg+uMyTseRlaoZGNUwxEa1V/eQfGiRZcdcDQGMXR/YpXTJfNW199XkYmdTs= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1791456111; c=relaxed/simple; bh=71PUR7K91ZyD69iBNYAlBARrgyC4DA7DjLeiH7sGXns=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=FyqheP9wxG0ojbFEbXiN5FzuxdeeazaB0i+9SYpiyKaAsLu6l0ykbSJeD8Zmnzz9NNf/1gviJQrReWalNKN9/N+6P8Pmde1VmRpMxtHWgw9SBgBEPvg67AkeTe4U+DMSksyWAcpuDxFQE0riD7XttVlnLjPAn5IoXL4ia5xSVmM= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=C8WUGbGK; arc=none smtp.client-ip=74.125.82.174 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="C8WUGbGK" Received: by mail-dy1-f174.google.com with SMTP id 5a478bee46e88-3115c4451c8so4254012eec.1 for ; Thu, 08 Oct 2026 03:41:50 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1791456110; x=1792060910; darn=lists.linux.dev; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to:content-type; bh=dx+SAHqrRwjwnSaJfYRo4lbib/UhuPNUGHZg46FBeBY=; b=C8WUGbGKfhdsaW9AT0i5NJAn6t1kaXY73RoiTFsOiDOHN1dbadI4J08885jn4mvsAQ jB2s/hnxi9Y0O6rB5okjZ/4QrPU6zEI/81u5zVA+HjALxZqrQtmig2/3ZSvm4Qd8SHEb e161e+kEN2JqAkh2oGmQbxneNFVpHDySPHtPoutaMqll1xZs/sH6gQ3dXJkWpvdJRPVv Bbmw8w3IxjFpHwyoYKTz5RO4CgFMZJgZpUexn0HRD+0BJlrlsl8HdUG2U4yessdtUopZ GkeDLhTrgDAZkkJjeYLKdNY23Kql1RsXh6cdIM0WEWDuIouGWM2U3OWPCQSt0GjQ2tiY Ix9A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20260707; t=1791456110; x=1792060910; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to:content-type; bh=dx+SAHqrRwjwnSaJfYRo4lbib/UhuPNUGHZg46FBeBY=; b=2rSZHiWXPPsj6RP5eFg524n9Pj3/Thll/rJB0PvY8/tUYap/ZhDVPzjN1H14vZ0LxS LI7fABzV8Qy3ziDxczrckMcU5AmQhpfk60pgSzoVu4vGocQbTX+en0VSqQuY2SEIVce7 5cs1y5lcKTTUDyLkzbZHPAQX1vN5o9tphrJ2gX0XVCSEpgCK+d7v70gX/rtzjPa8+s+J DOHuTAEXrDi66XZoVeM2aJxXBv8lbovZyjgaW6Rit0SfWNc0p9HXMDNxhcqo5cCOD90N TVIE4kVMQksL9XyQs4l8acWycFH+vdBKXsquKYEnWEHShzaoPMdFx3H2PJPwUtT9VRqq RLFw== X-Forwarded-Encrypted: i=1; AKwUvBzT0kkmKy2e736K+vNE4KdxUc9CEh6G78Sjf4dVubySPKzB4GBohfUmCV3dyP79EGcBZvlwVQ==@lists.linux.dev X-Gm-Message-State: AFq9FYIgSFK1HRQcRtUT/lPjXxpT80xaFny/Fne/7EhpM+g7TPNZxpGW e0hjaz5LCwnZDJLVDKCZ5nx7bK/NNlBP0xMji1uN8ptFRusg8XhE9TKq X-Gm-Gg: AYBFou16fkC9al0E9QFSi2NAPxozcGyTP/BC+OJZlpWVxaCh7a9spw6riiJ/9F3f8Sv 8Vpibw52/zMf5PINbnUcxgw/9AQyRH4qfPltsZbAbbQGYRY2aEn+0BwQ/sMmMMEfOHcR5k2Dk00 zT0qYoenE7G/NQpvNTXoklIfF2XN0Hz/j/2Nd9FfK+favrBRb6X0xgwK+CKndqdZdApwZkUFwT7 x1PHeZ00jkoCsKEDxBWuDbAsUPQYaVNxDLz8gqEQBIr9ZKEX1TsPBIWwCv5opJN/52reLNxvsuX e9rgNOtAwiDpBAZDOmwEmN03eET/Il2m6RYDrLaeRRvxgjZGMbNmgFrYMMggAaLm/G5AEXdHLpu RAjY7MviuftXQuTvY9ehSt22XmABf/i2CTnbINvFouXPsz+2eWg9immRvOxFx2CpyPmPbVNi9Tv ugxQqlN/wpYtHJ7K+ND6HDpJAZuYWbQmjBk3BRVFOSEEbGIm1Z7RCvxAaw3Szw5GWhr2SFc5nLe Fy9/sl64qJiuHPx+IoxWmE06s+USBptvQlXOBVKbY4qYcdGUGbdpEFIa+6wZ3PHB0As0x5Fdmem OpejtKOwBR2+7g== X-Received: by 2002:a05:693c:87dc:10b0:353:58f7:9b41 with SMTP id 5a478bee46e88-35358f79b75mr44405eec.11.1791456109537; Thu, 08 Oct 2026 03:41:49 -0700 (PDT) Received: from phuc-desktop.. ([183.91.15.56]) by smtp.gmail.com with ESMTPSA id 5a478bee46e88-3517810b895sm7496369eec.17.2026.10.08.03.41.36 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 08 Oct 2026 03:41:48 -0700 (PDT) From: phucduc.bui@gmail.com To: Vijendar Mukunda , Venkata Prasad Potturu , Liam Girdwood , Mark Brown , Jaroslav Kysela , Takashi Iwai , povik+lin@cutebit.org, Claudiu Beznea , Andrei Simion , Nicolas Ferre , Alexandre Belloni , David Rhodes , Richard Fitzgerald , Shengjiu Wang , Xiubo Li , Fabio Estevam , Nicolin Chen , Frank Li , Sascha Hauer , Pengutronix Kernel Team , Cezary Rojewski , Peter Ujfalusi , Bard Liao , Kai Vehmanen , Pierre-Louis Bossart , Kuninori Morimoto , Geert Uytterhoeven , Magnus Damm , Biju Das , Lad Prabhakar , Heiko Stuebner Cc: Kees Cook , Syed Saba Kareem , wangdicheng , Chris Bainbridge , Linus Walleij , Charles Keepax , Neo Chang , Krzysztof Kozlowski , u.kleine-koenig@baylibre.com, Pengpeng Hou , Cristian Ciocaltea , Hemanth Selam , Md Shofiqul Islam , Bjorn Helgaas , Zain Aboobacker , Sang-Heon Jeon , Ajit Kumar Pandey , Ravulapati Vishnu vardhan rao , Bo Shen , Vinod Koul , linux-sound@vger.kernel.org, asahi@lists.linux.dev, linux-arm-kernel@lists.infradead.org, patches@opensource.cirrus.com, linuxppc-dev@lists.ozlabs.org, imx@lists.linux.dev, linux-rockchip@lists.infradead.org, linux-renesas-soc@vger.kernel.org, linux-kernel@vger.kernel.org, bui duc phuc Subject: [PATCH 11/24] ASoC: codecs: nau8325: Ensure the DAI is marked as started on success Date: Thu, 8 Oct 2026 17:38:18 +0700 Message-ID: <20261008103831.542533-12-phucduc.bui@gmail.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20261008103831.542533-1-phucduc.bui@gmail.com> References: <20261008103831.542533-1-phucduc.bui@gmail.com> Precedence: bulk X-Mailing-List: asahi@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit From: bui duc phuc snd_pcm_hw_constraint_minmax() may return 1, which is then returned from nau8325_dai_startup(). ASoC only marks the DAI as started when .startup() returns 0. This currently has no functional impact, as nau8325_dai_ops has no .shutdown() callback. Still, return 0 explicitly on success to match what ASoC expects and ensure the DAI is correctly marked as started. Signed-off-by: bui duc phuc --- sound/soc/codecs/nau8325.c | 11 ++++++++--- 1 file changed, 8 insertions(+), 3 deletions(-) diff --git a/sound/soc/codecs/nau8325.c b/sound/soc/codecs/nau8325.c index 2c95ed00a681..0902a7d7730d 100644 --- a/sound/soc/codecs/nau8325.c +++ b/sound/soc/codecs/nau8325.c @@ -489,14 +489,19 @@ static int nau8325_dai_startup(struct snd_pcm_substream *substream, struct snd_soc_component *component = dai->component; struct nau8325 *nau8325 = snd_soc_component_get_drvdata(component); const struct nau8325_osr_attr *osr; + int ret; osr = nau8325_get_osr(nau8325); if (!osr || !osr->osr) return -EINVAL; - return snd_pcm_hw_constraint_minmax(substream->runtime, - SNDRV_PCM_HW_PARAM_RATE, - 0, CLK_DA_AD_MAX / osr->osr); + ret = snd_pcm_hw_constraint_minmax(substream->runtime, + SNDRV_PCM_HW_PARAM_RATE, + 0, CLK_DA_AD_MAX / osr->osr); + if (ret < 0) + return ret; + + return 0; } static int nau8325_hw_params(struct snd_pcm_substream *substream, -- 2.43.0 From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id CBF82CA6007 for ; Thu, 8 Oct 2026 10:41:54 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-ID:Date:Subject:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=FCVzGpMhNgAY5twpN3sKZSN5/XUC5Z8jegtLY3C8G6k=; b=klXiQgKUIe5Axk /jiG1iSGjHP9cHkIDvZSn+RD2CtVjgeW5h5yGonr7ep+eQludKt7oZG2f9DfhDuyUlju2Lk4HUDrM Rd8ir4hTtbjFQ0oZLKTllV2j3NQOJp2QtbLQWLuCUkfXqL2Wzvd58lFWTI3mmVmzalUolI6x9rJ73 6PB6EZTZKfg4q7CJCh8GVWs3Te3oaz0JpYANCltk2Jqz8FHyHnN8qST8bxWkDYpCzZBURJBdOtrhI aCC2cWBKtTk9u9PNnxTjHcrIjwYATlN83CV0qkjAc/o4R3k0RCPr87hVZUq0RJxeWUOZxOb5JLpuy IvwYN36AkMcpxNefIjKg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.99.1 #2 (Red Hat Linux)) id 1xElZQ-00000004ABC-32nF; Thu, 08 Oct 2026 10:41:52 +0000 Received: from mail-dy1-x1336.google.com ([2607:f8b0:4864:20::1336]) by bombadil.infradead.org with esmtps (Exim 4.99.1 #2 (Red Hat Linux)) id 1xElZO-00000004A9f-1ufd for linux-rockchip@lists.infradead.org; Thu, 08 Oct 2026 10:41:51 +0000 Received: by mail-dy1-x1336.google.com with SMTP id 5a478bee46e88-3518cbe59b0so250847eec.0 for ; Thu, 08 Oct 2026 03:41:50 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1791456110; x=1792060910; darn=lists.infradead.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to:content-type; bh=dx+SAHqrRwjwnSaJfYRo4lbib/UhuPNUGHZg46FBeBY=; b=At4eH4Jy3f0MacDcMPXKB8lSWL3tI70vXE6Y1EduWN1wQpZqZqJmYQx7XCxxrFTcIW e4y01lrrsL7jZCIk7PPRqvjgWmGQGBaVkm2zKQ3Aip3212XsenGWODUKXxSFx9n0oRGY b3VY69AoCOVXe5IHrDJaJtMAPgNETsxVuw29Z9NK9ogPIgQwo4N0gAeJDwOM73BfAmG1 qkoZYzvPg10VN2VnmCEqHPRKSp4gyKn/aYc/PXmkUZ5sHlNiHr4ZhnxfITMmcpaqa0Hg cuEG/VsbM6yOr4EmWMEqi+X7TEduBq9JRL73lxDaHt9Y0ENzjBhiDcvBxPbCJze2rvpm 2Eog== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20260707; t=1791456110; x=1792060910; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to:content-type; bh=dx+SAHqrRwjwnSaJfYRo4lbib/UhuPNUGHZg46FBeBY=; b=IQlavV3zd4Edjk7VCXXUNkRqcWhvXrDVpPLJ5FuI+Ig/vlsLXhMX3mDEeYB4ycS8Zc Dhi6dRwAEEv/8Reup6nHiCFOjAlCTOOzjp1AxDe5IEMk64srUFI+fZ8M6MWtN/4gY60x 8WVG1t27erzLWhpF11RL3+9b4V7XzCXh3cDlLdiGD+zxo91h9UA+uTdAH6GzncE+V/Iv /tJ+g8PzC7OOacvtaaJnGg/500FKPasimkwo8D8fFAEDt2D+8PW+kR7VLMdAOyYQVZZ0 BKxHXBgfLhmqCbMm1Sft8A8rnq18rXNGXXFAloXfvRu8W+NYmnjbKuld5gtW4oijXH6g tR9g== X-Forwarded-Encrypted: i=1; AKwUvBwG4vcpnZT9sIBywSPR5J4BNKlfvaykaFcTNXu1QjyZF3uZ7FpsRfzsL9ir6TuF0DkelU96iEQQFqg05DN7bA==@lists.infradead.org X-Gm-Message-State: AFq9FYLKQzgerQxcUq+7YlxjElsDh/stTqbYchgx/GXEtUhRd5VFrYTb 1D1wc7A0a8vjbvNTQPDwA2OIsCTn+wy/NeVGpnG/etSSXVUJ1NkUXk73 X-Gm-Gg: AYBFou0yrFz3ziVDWYc/98ds9js3uk7SVGA6Y3e54Ol91FH0Lp49Rm1/L8Yefu500BY 3pT3JgRLDnYsntsLy9knKooJmDmwhXyWSRGPIBMLH8ISCBg+SVq90KWpM6afBPDwIkgvKgiVhIo +FH+PeFJJX3F/btGp4s1x7GXmLHCEO3zlMZe6qPmxLvyVygKSgriZZZp9RPns8JksfwjNRrQILV XoDe1E2JdbXXlTmHB7MEaXjkxIpPW1f2XkY+PMmmaQiCOmzCp5JYN7Z2jlvpA13uh0nb4VkU67M NbtXssXdwvh/uOLciCwKu9r94a5Wh29P17AUlFrGcdAJj1LoYa+JqzVxO0Q7cZOkOOgyr5BsHJD 9MUrFfd3AXYsj7vlpxxNh1iU7tC70XXDkjI3QYSjFgV6CsuDDqsGJ8L2doxXJ3KMxlCImNEGLyW rR8yiGsAl1KOQXQ5+Qri1V/oKJgJe4cX8tJoHjANZ2aS8eoK6k7l6ho2yhwbLrMtRE2MHwkaBjl tzINnkLgev61ctGzKtPWuF0cKsnvEwlFR0ixVIFKZBVUQMP/99ajAs2oYLxQwizX0zE0fqBWn7R iQ9LbulWsHMUoA== X-Received: by 2002:a05:693c:87dc:10b0:353:58f7:9b41 with SMTP id 5a478bee46e88-35358f79b75mr44405eec.11.1791456109537; Thu, 08 Oct 2026 03:41:49 -0700 (PDT) Received: from phuc-desktop.. ([183.91.15.56]) by smtp.gmail.com with ESMTPSA id 5a478bee46e88-3517810b895sm7496369eec.17.2026.10.08.03.41.36 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 08 Oct 2026 03:41:48 -0700 (PDT) From: phucduc.bui@gmail.com To: Vijendar Mukunda , Venkata Prasad Potturu , Liam Girdwood , Mark Brown , Jaroslav Kysela , Takashi Iwai , povik+lin@cutebit.org, Claudiu Beznea , Andrei Simion , Nicolas Ferre , Alexandre Belloni , David Rhodes , Richard Fitzgerald , Shengjiu Wang , Xiubo Li , Fabio Estevam , Nicolin Chen , Frank Li , Sascha Hauer , Pengutronix Kernel Team , Cezary Rojewski , Peter Ujfalusi , Bard Liao , Kai Vehmanen , Pierre-Louis Bossart , Kuninori Morimoto , Geert Uytterhoeven , Magnus Damm , Biju Das , Lad Prabhakar , Heiko Stuebner Subject: [PATCH 11/24] ASoC: codecs: nau8325: Ensure the DAI is marked as started on success Date: Thu, 8 Oct 2026 17:38:18 +0700 Message-ID: <20261008103831.542533-12-phucduc.bui@gmail.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20261008103831.542533-1-phucduc.bui@gmail.com> References: <20261008103831.542533-1-phucduc.bui@gmail.com> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.9.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20261008_034150_499457_7046E722 X-CRM114-Status: GOOD ( 13.23 ) X-BeenThere: linux-rockchip@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Upstream kernel work for Rockchip platforms List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: imx@lists.linux.dev, wangdicheng , Kees Cook , Sang-Heon Jeon , Pengpeng Hou , Bo Shen , Neo Chang , linux-rockchip@lists.infradead.org, bui duc phuc , Chris Bainbridge , Charles Keepax , linux-sound@vger.kernel.org, Ravulapati Vishnu vardhan rao , u.kleine-koenig@baylibre.com, Zain Aboobacker , Bjorn Helgaas , Md Shofiqul Islam , linux-arm-kernel@lists.infradead.org, Krzysztof Kozlowski , Ajit Kumar Pandey , patches@opensource.cirrus.com, Linus Walleij , linux-kernel@vger.kernel.org, linux-renesas-soc@vger.kernel.org, Vinod Koul , asahi@lists.linux.dev, Hemanth Selam , linuxppc-dev@lists.ozlabs.org, Syed Saba Kareem Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "Linux-rockchip" Errors-To: linux-rockchip-bounces+linux-rockchip=archiver.kernel.org@lists.infradead.org From: bui duc phuc snd_pcm_hw_constraint_minmax() may return 1, which is then returned from nau8325_dai_startup(). ASoC only marks the DAI as started when .startup() returns 0. This currently has no functional impact, as nau8325_dai_ops has no .shutdown() callback. Still, return 0 explicitly on success to match what ASoC expects and ensure the DAI is correctly marked as started. Signed-off-by: bui duc phuc --- sound/soc/codecs/nau8325.c | 11 ++++++++--- 1 file changed, 8 insertions(+), 3 deletions(-) diff --git a/sound/soc/codecs/nau8325.c b/sound/soc/codecs/nau8325.c index 2c95ed00a681..0902a7d7730d 100644 --- a/sound/soc/codecs/nau8325.c +++ b/sound/soc/codecs/nau8325.c @@ -489,14 +489,19 @@ static int nau8325_dai_startup(struct snd_pcm_substream *substream, struct snd_soc_component *component = dai->component; struct nau8325 *nau8325 = snd_soc_component_get_drvdata(component); const struct nau8325_osr_attr *osr; + int ret; osr = nau8325_get_osr(nau8325); if (!osr || !osr->osr) return -EINVAL; - return snd_pcm_hw_constraint_minmax(substream->runtime, - SNDRV_PCM_HW_PARAM_RATE, - 0, CLK_DA_AD_MAX / osr->osr); + ret = snd_pcm_hw_constraint_minmax(substream->runtime, + SNDRV_PCM_HW_PARAM_RATE, + 0, CLK_DA_AD_MAX / osr->osr); + if (ret < 0) + return ret; + + return 0; } static int nau8325_hw_params(struct snd_pcm_substream *substream, -- 2.43.0 _______________________________________________ Linux-rockchip mailing list Linux-rockchip@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-rockchip