From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-dy1-f172.google.com (mail-dy1-f172.google.com [74.125.82.172]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 44C25497382 for ; Thu, 8 Oct 2026 10:43:07 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=74.125.82.172 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1791456188; cv=none; b=WJdSzx2xqjhFo0cwvTD4b93QJOxaC8P17s0GY1yyowx8dRegV1bFAYJHpO13D8o5F+Qf6/ErejpDwXuI8+QC534YzA76CItTENOI3PaeUbygVuBvdSyK4koXhKqOViiHLJg3RBWb9AXX5iP7N/P7tenlts+QnuwyezdWsSP+C9g= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1791456188; c=relaxed/simple; bh=4NCY4WcF1QlkYiyC8+OHrV0PoUi/1+lM3FPBnwvgx8U=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=OAl3waJPKZ8GiDTIIrbCkm987q/S82tv/CNWGRt8b2FMjXG9gLFUvGqSz0QoIYW5yPV30smtjqGF+UonLLMBigfy1DfNDIKszTSRURkHaSxNKUGkD4KzuvE6Ce5j6/JUMtubHANccXUrI2bHD8Y3uyierURuYVYhWkgoSAWIFR4= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=Ul64DrsI; arc=none smtp.client-ip=74.125.82.172 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="Ul64DrsI" Received: by mail-dy1-f172.google.com with SMTP id 5a478bee46e88-34ca2d54925so7790499eec.0 for ; Thu, 08 Oct 2026 03:43:07 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1791456186; x=1792060986; darn=lists.linux.dev; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to:content-type; bh=T/ErUb+BYhJoBzVefBGuzS4rmfVbIr3TqgsBxZ+R3Yg=; b=Ul64DrsIVffM+ulPY4Fzsbjbf1Uv5yW0fFiv9Qnq4kxZRGG1+u2NzBB/FNnizNSliI 8VKswpdgZQEyGgrYR0osj5R4pX/SKbWjZ0EvqWqYb9ii6RV1EKi+nRpqmWZ97O5aPXsY prSntx5p29mSG9MtVpgf4yM8kZT8D0HzNYQ1ytxDorRXQCBWiwgtYlJWGy6KKeRpOf+S eUHquokCckVaHbJWyfzc3SgLCHmIgjxIt9V3kiCeWUUpdnMnYTjhrQ5RMNQYSWi8lTtC ICHl8Swc5rHIbI7j0lp0c5J/KPh1VlzigwzHW35a1xPd7FmfqlOk2ngyk2EaUYNU2w4e v7Hw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20260707; t=1791456186; x=1792060986; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to:content-type; bh=T/ErUb+BYhJoBzVefBGuzS4rmfVbIr3TqgsBxZ+R3Yg=; b=IEwSmPnFJeVnHhokUpIRWVEZh0TWB5P+aNhyfButBO+tjgg5WjLfKXc0jQJU3C/ycR SJ+7LQuu5fTRXTyeP7JzEXw6QdThs1+0XSgxvgIlaOKvCFDgnJQ4ndWcjbs9P/ZA+VG1 L6Nc0EGOlZBP7gfaAexyC64TMrrWU+0dtJsaS1Dg0TJTJFDKFXDQ2wKejnUfOCJZZVe7 S1IwsVQDNs6mgw/CM+Yz6UrBVCzaceG2W8cHQg0Q43RJ1wtkSqdSTa66AXH4v6T7O+w6 Q/UzKDdfogrRZe3rg3Ei5op3X2t7TDw7O24roUdmjbsQhCeWm62UEJMwsZPhx7G5Ua+Q xDhg== X-Forwarded-Encrypted: i=1; AKwUvBz+55EvREwu1jXMqXppVToVzZCfDvt7gamNJ7/c+Ni2TZ+uzy4mIsQZwrSBv+F68T0wkeqRzA==@lists.linux.dev X-Gm-Message-State: AFuF++na0wtvyRnh3B+KHsJBgDts1he/iSSGpJ2qT5X+zadDOJBaLrmH EzMimHt6HbNhmY5axWVD2O0BpHA/c/kz3u7qHRQpovVZ6GXpFQ+qmxW3 X-Gm-Gg: AYBFou2Si6kyK9gGx59o+xQ6fOgQFwOAqOnzo8qvFiMknmkizX2i97cmj5lz+X/FNQs lOON9VWXLDFBo0OBDbWwwBAFnFXxKFZamJQluHKCp97heUUkSmFK0rHKWLHTTtEO79mXPrIZMmV SGIOcuqWS9y4ZeNMTYA56Qadm2oGc9X+4ydrmiS70FyR65DdvZH79lrsa2HB9O6xOSDQfmnS1zY FrryxZhxDB7oJ6u4yMUwj7EcmZXJazzuZKnkpcDp/FtRrDqsRDeAS/5MJdAPH6ZCroHsfe/OiEn kYHPnbeok9xUgFqeKAetQZuJ0LCI9iFDS5FIoOdBQKsQIbxAxUUpZHupe1Rufuu8UULvZxr0sru mZuU2cXq1x5mFqBy7WSCcbK25nLfWpExMupRqiQUd19EuRHO5fyz+1icPZrBnRvw3uf4kSffP84 JUzuYssYjdMO/28wB1LgE1Jb7fiQSM5Bav/mviQliMjIjyaFdGlUMGXC+VvyT4Uf8fRjeUd78br tOcIS8rk0ifXQIS5G6VX/t5RBZdLWjRgwNcOkzhEsW70czlRabIOLxOIKyVnJDf5BiAqqXB5amU aLpeMgvMgk/foNgANKC+Wn6e X-Received: by 2002:a05:693c:88c6:10b0:328:3944:ee53 with SMTP id 5a478bee46e88-3515da28859mr6108352eec.2.1791456186115; Thu, 08 Oct 2026 03:43:06 -0700 (PDT) Received: from phuc-desktop.. ([183.91.15.56]) by smtp.gmail.com with ESMTPSA id 5a478bee46e88-3517810b895sm7496369eec.17.2026.10.08.03.42.52 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 08 Oct 2026 03:43:05 -0700 (PDT) From: phucduc.bui@gmail.com To: Vijendar Mukunda , Venkata Prasad Potturu , Liam Girdwood , Mark Brown , Jaroslav Kysela , Takashi Iwai , povik+lin@cutebit.org, Claudiu Beznea , Andrei Simion , Nicolas Ferre , Alexandre Belloni , David Rhodes , Richard Fitzgerald , Shengjiu Wang , Xiubo Li , Fabio Estevam , Nicolin Chen , Frank Li , Sascha Hauer , Pengutronix Kernel Team , Cezary Rojewski , Peter Ujfalusi , Bard Liao , Kai Vehmanen , Pierre-Louis Bossart , Kuninori Morimoto , Geert Uytterhoeven , Magnus Damm , Biju Das , Lad Prabhakar , Heiko Stuebner Cc: Kees Cook , Syed Saba Kareem , wangdicheng , Chris Bainbridge , Linus Walleij , Charles Keepax , Neo Chang , Krzysztof Kozlowski , u.kleine-koenig@baylibre.com, Pengpeng Hou , Cristian Ciocaltea , Hemanth Selam , Md Shofiqul Islam , Bjorn Helgaas , Zain Aboobacker , Sang-Heon Jeon , Ajit Kumar Pandey , Ravulapati Vishnu vardhan rao , Bo Shen , Vinod Koul , linux-sound@vger.kernel.org, asahi@lists.linux.dev, linux-arm-kernel@lists.infradead.org, patches@opensource.cirrus.com, linuxppc-dev@lists.ozlabs.org, imx@lists.linux.dev, linux-rockchip@lists.infradead.org, linux-renesas-soc@vger.kernel.org, linux-kernel@vger.kernel.org, bui duc phuc Subject: [PATCH 16/24] ASoC: codecs: wm8580: Ensure the DAI is marked as started on success Date: Thu, 8 Oct 2026 17:38:23 +0700 Message-ID: <20261008103831.542533-17-phucduc.bui@gmail.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20261008103831.542533-1-phucduc.bui@gmail.com> References: <20261008103831.542533-1-phucduc.bui@gmail.com> Precedence: bulk X-Mailing-List: asahi@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit From: bui duc phuc snd_pcm_hw_constraint_minmax() may return 1, which is then returned from wm8580_playback_startup(). ASoC only marks the DAI as started when .startup() returns 0. This currently has no functional impact, as wm8580_dai_ops_playback has no .shutdown() callback. Still, return 0 explicitly on success to match what ASoC expects and ensure the DAI is correctly marked as started. Signed-off-by: bui duc phuc --- sound/soc/codecs/wm8580.c | 10 ++++++++-- 1 file changed, 8 insertions(+), 2 deletions(-) diff --git a/sound/soc/codecs/wm8580.c b/sound/soc/codecs/wm8580.c index 9bc5d1e795dc..5343d445c322 100644 --- a/sound/soc/codecs/wm8580.c +++ b/sound/soc/codecs/wm8580.c @@ -852,9 +852,15 @@ static int wm8580_playback_startup(struct snd_pcm_substream *substream, { struct snd_soc_component *component = dai->component; struct wm8580_priv *wm8580 = snd_soc_component_get_drvdata(component); + int ret; - return snd_pcm_hw_constraint_minmax(substream->runtime, - SNDRV_PCM_HW_PARAM_CHANNELS, 1, wm8580->drvdata->num_dacs * 2); + ret = snd_pcm_hw_constraint_minmax(substream->runtime, + SNDRV_PCM_HW_PARAM_CHANNELS, 1, + wm8580->drvdata->num_dacs * 2); + if (ret < 0) + return ret; + + return 0; } #define WM8580_FORMATS (SNDRV_PCM_FMTBIT_S16_LE | SNDRV_PCM_FMTBIT_S20_3LE |\ -- 2.43.0 From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id C2BA0CA6007 for ; Thu, 8 Oct 2026 10:43:11 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-ID:Date:Subject:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=9bxmyjKimx8WcsYzMvCTuMYWE2JtpNi6pnVb0sRWt00=; b=iOiemGGIkaNgi4 5PmUBlOOgW/CLKL7CNeVOKuBqa/rKhSissuAYmrG1585pkYOpcMk1vU7AWpevj4kCMokXPrK+ABGd Ts7nn+aEVD1vULGhCbzadmgDOIyceYyASWvZVmEoRurW5nTfE0wekwPo/Xt98kywXuHwabkQ7TwGr 1ilBqUKd57dfPwBSJsIwbS27nOff/B2xc/TIHS0G9FziGTt5ub/Lz+D8A3QaYTF5t/4V8yaQseii6 ocL+H1lBeEM6/c1p4ODz0L+/OFrBgJo1TNdb6dTAJYX5KvQrB7Lc9Jn9EyHOQdMNd6GG+UYaBLAkx TnDldGuE6WtaDKsd8b1A==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.99.1 #2 (Red Hat Linux)) id 1xElaf-00000004Al7-2tuu; Thu, 08 Oct 2026 10:43:09 +0000 Received: from mail-dy1-x132a.google.com ([2607:f8b0:4864:20::132a]) by bombadil.infradead.org with esmtps (Exim 4.99.1 #2 (Red Hat Linux)) id 1xElad-00000004AjD-0RDo for linux-rockchip@lists.infradead.org; Thu, 08 Oct 2026 10:43:08 +0000 Received: by mail-dy1-x132a.google.com with SMTP id 5a478bee46e88-34ca2d54925so7790489eec.0 for ; Thu, 08 Oct 2026 03:43:06 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1791456186; x=1792060986; darn=lists.infradead.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to:content-type; bh=T/ErUb+BYhJoBzVefBGuzS4rmfVbIr3TqgsBxZ+R3Yg=; b=nx9UKR/3bc+SElBV/YB637R9F8Z4d50cVvZNYstX80p8LKK43XGCnG/pvd/r5H8QmV xDvPjey4jWVUdhT3wEbHwb+86Gdh47RVHtOy+4BmUuWg1muF0BB3c+H2rGW8nbtYTwEY qf6UaMBeQE2yJHiEikZZNaN5WperL8x24/OSn0MkFFbT3EtJmMBNfRMegKylvTDB0jw8 rjkxAqUi9H+9lfAoCy26kZwAOP5S5kUmFcR3VDBkBZc2Y0cmeCa3+lYtYqoYL7D37O+I wQWbl/Rm/bqjzQWLkEZ/KvGJgQzPZbhLYCrLBrRzlT6Yci8i4MGaNIL590REk6NfG6W/ TESw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20260707; t=1791456186; x=1792060986; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to:content-type; bh=T/ErUb+BYhJoBzVefBGuzS4rmfVbIr3TqgsBxZ+R3Yg=; b=y9auiPEGQCLRT7djAnbAfDhtomspyF19xO1GnSEGgjOnUY3kuvjMvHEHqmyANe5NbV QxKINVQ+1vZNbKWXyiDSwmrZK0Lf6EBHOTLAVfwxds6WDdQ0si3k4WVUuaPghAt3DARC etN+5+Ervn8Xj4+Woce3BO19CgxrPA3HZQTXT0fUiq+VqnX+Nwf6/9EzhOaGz5pGHp1s +Ta+jtHizk0tBXzDViV+Ef1dLdz07qVxNV+7PPHgIvKON/NYUQbHaJFMJq1nA1hBSgZ1 XJrLS/FkuAn4ZfgRtgSnDr5IIaw9TjvzycGi06Mi66zoSeg4pYL1sHL7+y56KevHYkbH bOow== X-Forwarded-Encrypted: i=1; AKwUvBwrXvg34MZxdqlBSBtjVemZsHOfVLaTbV2HhUmgLV6gpcsp/ACtnnoPO0gYnrh7tO3MneK4PtWNbW5DkqmuqQ==@lists.infradead.org X-Gm-Message-State: AFuF++nE5JG0tNRuxqYezTmRxj5mtPcJmnQ9EBpGFJWVWrwr+TahP03B ssaO2FMltOQZiwKbPjTVsRqg390exjR/WeoO1Y98Q7Qv6qLUAfGEKf2n X-Gm-Gg: AYBFou3DTwX4Eo0EKagEkBurSM4Zxqb8TcCmaNUXb1IsOLG8//M49FGRdVkAv+i9Xad fB+6+mHOFc4G19k7p4PMPmSQQOoWz6kA454vzcIoOl2N/1yiJfQt7WHd/JX7wbmYyfHMb2WPtca Bo5aX1Gdva+zFrvnOp5zL7ANtrq8Wz0eJqu/MilMkEZIsg+LJ+v3irq7kS3WrX7Hd2ykFr4azIo Rp2JpX8FpkdoVT+OJ8IqJdgUzSmGNd78NsGXgU5FBXMB02b9nrpcNn700zYR4sSkO+0XqycUtmp 1Jm/h7CRK6HTqX76KA+zMiQvQhHSzsdHtjv6TBYn6ELy1NyzENGeBC9SAzaLdSJzgqU9x8WT+Qg rcnvcTYcfnX5WsTRIXSB9kCtmIjTBVxzWyg8TjdujjmIMhI9+y3TWzUktzB/WvwhdOYmh0HqHEW fvQyW+T7XoHgrZsoRniU5RVk9V2VrOAvwkCFdIswjbPzzPtpfZDbYzcQmxnenoWFU7rC91S4tvE CQVzPuWHZZcmhfbzaYC5fpLX3ZQvhvGcoyISEWXDPcs5ePaosQkl03psyDfaAAksnS/ZcZUidDJ GKaObrckQAMh5cmAaQBXNyTk X-Received: by 2002:a05:693c:88c6:10b0:328:3944:ee53 with SMTP id 5a478bee46e88-3515da28859mr6108352eec.2.1791456186115; Thu, 08 Oct 2026 03:43:06 -0700 (PDT) Received: from phuc-desktop.. ([183.91.15.56]) by smtp.gmail.com with ESMTPSA id 5a478bee46e88-3517810b895sm7496369eec.17.2026.10.08.03.42.52 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 08 Oct 2026 03:43:05 -0700 (PDT) From: phucduc.bui@gmail.com To: Vijendar Mukunda , Venkata Prasad Potturu , Liam Girdwood , Mark Brown , Jaroslav Kysela , Takashi Iwai , povik+lin@cutebit.org, Claudiu Beznea , Andrei Simion , Nicolas Ferre , Alexandre Belloni , David Rhodes , Richard Fitzgerald , Shengjiu Wang , Xiubo Li , Fabio Estevam , Nicolin Chen , Frank Li , Sascha Hauer , Pengutronix Kernel Team , Cezary Rojewski , Peter Ujfalusi , Bard Liao , Kai Vehmanen , Pierre-Louis Bossart , Kuninori Morimoto , Geert Uytterhoeven , Magnus Damm , Biju Das , Lad Prabhakar , Heiko Stuebner Subject: [PATCH 16/24] ASoC: codecs: wm8580: Ensure the DAI is marked as started on success Date: Thu, 8 Oct 2026 17:38:23 +0700 Message-ID: <20261008103831.542533-17-phucduc.bui@gmail.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20261008103831.542533-1-phucduc.bui@gmail.com> References: <20261008103831.542533-1-phucduc.bui@gmail.com> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.9.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20261008_034307_148896_4618AF2F X-CRM114-Status: GOOD ( 13.50 ) X-BeenThere: linux-rockchip@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Upstream kernel work for Rockchip platforms List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: imx@lists.linux.dev, wangdicheng , Kees Cook , Sang-Heon Jeon , Pengpeng Hou , Bo Shen , Neo Chang , linux-rockchip@lists.infradead.org, bui duc phuc , Chris Bainbridge , Charles Keepax , linux-sound@vger.kernel.org, Ravulapati Vishnu vardhan rao , u.kleine-koenig@baylibre.com, Zain Aboobacker , Bjorn Helgaas , Md Shofiqul Islam , linux-arm-kernel@lists.infradead.org, Krzysztof Kozlowski , Ajit Kumar Pandey , patches@opensource.cirrus.com, Linus Walleij , linux-kernel@vger.kernel.org, linux-renesas-soc@vger.kernel.org, Vinod Koul , asahi@lists.linux.dev, Hemanth Selam , linuxppc-dev@lists.ozlabs.org, Syed Saba Kareem Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "Linux-rockchip" Errors-To: linux-rockchip-bounces+linux-rockchip=archiver.kernel.org@lists.infradead.org From: bui duc phuc snd_pcm_hw_constraint_minmax() may return 1, which is then returned from wm8580_playback_startup(). ASoC only marks the DAI as started when .startup() returns 0. This currently has no functional impact, as wm8580_dai_ops_playback has no .shutdown() callback. Still, return 0 explicitly on success to match what ASoC expects and ensure the DAI is correctly marked as started. Signed-off-by: bui duc phuc --- sound/soc/codecs/wm8580.c | 10 ++++++++-- 1 file changed, 8 insertions(+), 2 deletions(-) diff --git a/sound/soc/codecs/wm8580.c b/sound/soc/codecs/wm8580.c index 9bc5d1e795dc..5343d445c322 100644 --- a/sound/soc/codecs/wm8580.c +++ b/sound/soc/codecs/wm8580.c @@ -852,9 +852,15 @@ static int wm8580_playback_startup(struct snd_pcm_substream *substream, { struct snd_soc_component *component = dai->component; struct wm8580_priv *wm8580 = snd_soc_component_get_drvdata(component); + int ret; - return snd_pcm_hw_constraint_minmax(substream->runtime, - SNDRV_PCM_HW_PARAM_CHANNELS, 1, wm8580->drvdata->num_dacs * 2); + ret = snd_pcm_hw_constraint_minmax(substream->runtime, + SNDRV_PCM_HW_PARAM_CHANNELS, 1, + wm8580->drvdata->num_dacs * 2); + if (ret < 0) + return ret; + + return 0; } #define WM8580_FORMATS (SNDRV_PCM_FMTBIT_S16_LE | SNDRV_PCM_FMTBIT_S20_3LE |\ -- 2.43.0 _______________________________________________ Linux-rockchip mailing list Linux-rockchip@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-rockchip