From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-dy1-f175.google.com (mail-dy1-f175.google.com [74.125.82.175]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 74C2147607E for ; Thu, 8 Oct 2026 10:44:56 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=74.125.82.175 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1791456297; cv=none; b=Z//CjtGrkzYlWrFC1ZU4StXv3RDS/goya0eZTtjeCenswfB7/QjrB8SMMyq8OQbbBYDBK23V6kEwxjl+0IGWodw1blZ1zBkmbt29XfqemX1D/+OOjMxH2+zOjB03ADlwxCGN/G1cPX1hK897Wrt4AaVKOFvP0D+BHD4s1GyByxk= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1791456297; c=relaxed/simple; bh=f8CcWoO4sZy/Z9AND7TTLaeemfCybBHCm1tDpN4e8XU=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=cafTZ363D1c5TUKKys11YUwpIEkz9Gh3k2ZEOQvFFU1l3QHsilOfJFbehOxnqx+hjUUp+YLTcwxAe+whuxTfbrlvSo9ScvsOxqU71eXqvr/8v67pVx4x0+9pZbZ1WWVieOUV9mOxNMUU2YNKxg8i/LAAx3I3NuCvROTciYyOuUA= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=C1rdV4xC; arc=none smtp.client-ip=74.125.82.175 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="C1rdV4xC" Received: by mail-dy1-f175.google.com with SMTP id 5a478bee46e88-3514b90bb89so4403801eec.1 for ; Thu, 08 Oct 2026 03:44:56 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1791456295; x=1792061095; darn=lists.linux.dev; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to:content-type; bh=vuCt8LfoeVxeGP9EXdKyFEToJzhlOF5O+NhVLwPyMgM=; b=C1rdV4xCXbItL9ZbzC+rGj/8XgL7kALBpaujJlzqhifHXF0oh2Z9+fhJsEQeSkUA5c D7HGO53SSjIk3jyUZVDkXzcCVSFZo6p3ZMe44ImKAj8aYvovHFuKTwiVCx6b+xnNRxjr tGziuIQaqTPkXOsEef0STSP1+B8fu5CxidSk/RKLpUGNV1Ia+0UbExXzawSq5CN1C1QK SxiW0jTMwNm2K+8/UQw+yWxPrujcPdfysNG6eu1+RILiCFM085xY9WgfqwYuxVw+cNpR ysn7MdDZhJeC7DnuCTNO02/HTeiLmOGapQtKGvdp1rzFG95hI1yw+/v9XsypcWpmj/3b D60A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20260707; t=1791456295; x=1792061095; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to:content-type; bh=vuCt8LfoeVxeGP9EXdKyFEToJzhlOF5O+NhVLwPyMgM=; b=0XTf5htJJhWzpm5TSeI6X5dcHzUaPcObaWrrsQOnLaw5yZ925JowqwV5WSLpvIxW7p U9KuTgxcxJPu0n83ykpITeOLLvR7rKXB4xxXC2VYWuAIFwYbQUdOV/9GmNQIcGPGXSsB wMz2zxAYeed5QLQdCk0s0rXzfxRSeM01DyoUPs81E0wL4uWpcurgBn3X+/fWHh5fntqt hfnB/9hSX9E9d0HplWaqjUbODe3TjbDyjnpbetZ8oMzJ2G3hHEVcxJrVFev6t7uqz6D1 S3EW0nXNSdT79SvtkVdt9btYSTfj2ZycSMN/XvWLUSamktAbhMkl2oOncZRtMRkC4rYA oOgw== X-Forwarded-Encrypted: i=1; AKwUvByaXqeC3H44vK/x1XfcAcDzCm7jKVcO2+Pep4xDFRlv9sO6q5rbGAj12xv8dO2Hu+m5JhM=@lists.linux.dev X-Gm-Message-State: AFuF++nhDaPytEKJt3cKh9vsqcokThnNlwHbezSlci5Ks8+O2Y73zYp8 qWRAzQ43zU35QBa6wPJq0DXIXZFlxfTKQLpdZoXDx/BmAieq1EMjkPUN X-Gm-Gg: AYBFou1ecSfil3+hse0y43fBqhuYo93CW01x0fnen4N0IfxpxLv/V/2ppx/s6G4syvU bOAyVivefDWu0/vu9OnlTHR4EjuH4pe0MJLrrRj7AdPs/C42ZlTr+Jcm2x1G89G03QQ+0X5l0qz lSqT1Q5i3n5aFcd1//UOt763hsW1uyw96j/MQbaLy7LRxB8LdB++BZH1KpL8MGTkZmUkwOL+N+d /AyB6YzJByWmNwmQOKxNQ8SxK/pc5+8d16qyW4QYyI954HM23b3vGT1c8C/ZNDGS3uv/bacFzPG 51ueXCUjIZqpTzikJxTEHN5fBQ8RBA+VagZ4/q6Qn7KZ6iljE0sv9hxv/oVqYpvUfwZVTaQ0BLH 4H421rZ/TrC/QBPKDwuqP5xZ38HAezkmlyo3Q7ltBfdq+ZADyEp5greST4CCuuqH8/wud/G+jmj fPScAClqKSlmQ4U8XyhHrNZCBz7N0wjXT+/+5Isi8fhRmGTHqznwD+4kGYWl9VGPl1jqkGr12sv 7TTjR3C8pQPuEW0P8kNqFlQETY05smq6bAs92i0N79LVBhpK3J17rvmGM1JfWmMqdJjM/pVu3aW bdEs9eBRmlu3JQ== X-Received: by 2002:a05:693c:88c6:10b0:328:3944:ee53 with SMTP id 5a478bee46e88-3515da28859mr6112721eec.2.1791456295330; Thu, 08 Oct 2026 03:44:55 -0700 (PDT) Received: from phuc-desktop.. ([183.91.15.56]) by smtp.gmail.com with ESMTPSA id 5a478bee46e88-3517810b895sm7496369eec.17.2026.10.08.03.44.42 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 08 Oct 2026 03:44:54 -0700 (PDT) From: phucduc.bui@gmail.com To: Vijendar Mukunda , Venkata Prasad Potturu , Liam Girdwood , Mark Brown , Jaroslav Kysela , Takashi Iwai , povik+lin@cutebit.org, Claudiu Beznea , Andrei Simion , Nicolas Ferre , Alexandre Belloni , David Rhodes , Richard Fitzgerald , Shengjiu Wang , Xiubo Li , Fabio Estevam , Nicolin Chen , Frank Li , Sascha Hauer , Pengutronix Kernel Team , Cezary Rojewski , Peter Ujfalusi , Bard Liao , Kai Vehmanen , Pierre-Louis Bossart , Kuninori Morimoto , Geert Uytterhoeven , Magnus Damm , Biju Das , Lad Prabhakar , Heiko Stuebner Cc: Kees Cook , Syed Saba Kareem , wangdicheng , Chris Bainbridge , Linus Walleij , Charles Keepax , Neo Chang , Krzysztof Kozlowski , u.kleine-koenig@baylibre.com, Pengpeng Hou , Cristian Ciocaltea , Hemanth Selam , Md Shofiqul Islam , Bjorn Helgaas , Zain Aboobacker , Sang-Heon Jeon , Ajit Kumar Pandey , Ravulapati Vishnu vardhan rao , Bo Shen , Vinod Koul , linux-sound@vger.kernel.org, asahi@lists.linux.dev, linux-arm-kernel@lists.infradead.org, patches@opensource.cirrus.com, linuxppc-dev@lists.ozlabs.org, imx@lists.linux.dev, linux-rockchip@lists.infradead.org, linux-renesas-soc@vger.kernel.org, linux-kernel@vger.kernel.org, bui duc phuc Subject: [PATCH 23/24] ASoC: rockchip: rk3399_gru_sound: Mark the link as started on success Date: Thu, 8 Oct 2026 17:38:30 +0700 Message-ID: <20261008103831.542533-24-phucduc.bui@gmail.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20261008103831.542533-1-phucduc.bui@gmail.com> References: <20261008103831.542533-1-phucduc.bui@gmail.com> Precedence: bulk X-Mailing-List: imx@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit From: bui duc phuc snd_pcm_hw_constraint_minmax() may return 1, which is then returned from rockchip_sound_startup(). ASoC only marks the DAI link as started when .startup() returns 0. This currently has no functional impact, as there is no .shutdown() callback in the relevant snd_soc_ops. Still, return 0 explicitly on success to match what ASoC expects and ensure the DAI link is correctly marked as started. Signed-off-by: bui duc phuc --- sound/soc/rockchip/rk3399_gru_sound.c | 9 +++++++-- 1 file changed, 7 insertions(+), 2 deletions(-) diff --git a/sound/soc/rockchip/rk3399_gru_sound.c b/sound/soc/rockchip/rk3399_gru_sound.c index 04e7bed8275d..0ec80a4b8c59 100644 --- a/sound/soc/rockchip/rk3399_gru_sound.c +++ b/sound/soc/rockchip/rk3399_gru_sound.c @@ -258,10 +258,15 @@ static int rockchip_sound_dmic_hw_params(struct snd_pcm_substream *substream, static int rockchip_sound_startup(struct snd_pcm_substream *substream) { struct snd_pcm_runtime *runtime = substream->runtime; + int ret; runtime->hw.formats = SNDRV_PCM_FMTBIT_S16_LE; - return snd_pcm_hw_constraint_minmax(runtime, SNDRV_PCM_HW_PARAM_RATE, - 8000, 96000); + ret = snd_pcm_hw_constraint_minmax(runtime, SNDRV_PCM_HW_PARAM_RATE, + 8000, 96000); + if (ret < 0) + return ret; + + return 0; } static const struct snd_soc_ops rockchip_sound_max98357a_ops = { -- 2.43.0 From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 992A6CA6007 for ; Thu, 8 Oct 2026 10:45:00 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-ID:Date:Subject:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=CpZNiWAkqQ6ytOATA9FI33clbcyFc/mmw7Z71onsw+g=; b=rdrPLfBeBG2Ied 9xM7DpoE0lIxQ8DwWhBPjxBK8Q5AqJ11dLbslL9q6+6bIQFTCBmIog5iOteJS/cG9P5FYG2BPURmn x7gulqwpMcyE+nikl3HkJr7kBjXuQcN6j7Ft+KtMWl/Yu/V1fzJnt4GN+95bKPWIZ+W6tuMdsaNAr nDRSkcywmyp601Ye6Y6w9m935rtbXIfse0zSkBV9UWjUJVPIL93o6xQ5lCqmzyu2iIIRJ2F4lt3X+ VcLrzseSIUcXUxHkOZCG1iMsFlv7k5oLHvwK07cD0pf8od/r7WLq28xjTCBh4hCqbsYEREA/vro2P 5+ozk9q+l+56I5V4L02w==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.99.1 #2 (Red Hat Linux)) id 1xElcQ-00000004BXY-1xMA; Thu, 08 Oct 2026 10:44:58 +0000 Received: from mail-dy1-x1330.google.com ([2607:f8b0:4864:20::1330]) by bombadil.infradead.org with esmtps (Exim 4.99.1 #2 (Red Hat Linux)) id 1xElcO-00000004BWL-18j6 for linux-rockchip@lists.infradead.org; Thu, 08 Oct 2026 10:44:57 +0000 Received: by mail-dy1-x1330.google.com with SMTP id 5a478bee46e88-34ca2d54925so7792315eec.0 for ; Thu, 08 Oct 2026 03:44:56 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1791456295; x=1792061095; darn=lists.infradead.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to:content-type; bh=vuCt8LfoeVxeGP9EXdKyFEToJzhlOF5O+NhVLwPyMgM=; b=D2liA3Ulgmx8buHWzpFIZLHlDYJBUbPlcxeWF3ocZeT8Nom+3T7WvZFSJrmota4/Em FnA6TCyzP31/nQB/FCyp67OAjbiHO5YtdVqM05OTM9UvsfyG99GvttAHtC3JuNMgzymd 2fjWqz3aeNc4D9H5zfOjLvgeAzmxs7VH2EXhqSGcq0MBmMU/00EQeLy4fzwO3AgSU57w R+3YB6LCVK7S2M2NHNlV81wBPwzJaoLjV6ZfO4QBCMhjwg2u8CECzUY/Q9xPy1L6JiVh sPe5CeEOjdx4tvMz94CwZqKr6i1pME6REE6F39rZ/wRSCCvwGQiHa+Kl3t2lGdwNQbJ8 JnVw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20260707; t=1791456295; x=1792061095; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to:content-type; bh=vuCt8LfoeVxeGP9EXdKyFEToJzhlOF5O+NhVLwPyMgM=; b=F+V1hr7ALmjmRoe2cU9KMTIuO2s6KZmow10IAAMwQve5gFUhY60qTm47L4TV7yzIIC cyUIyDAyOAU98DNB5D26jJ+7i5N2Kx9rHaLo5aVJvH8Ahpn0BmJb1r7eY21yCn7hTFsU 5yIm5cVMZ++EOF6aw0j66VSxVAbMoPXEQjNCFr21nQCKPV8WdUJw598S2wgPlKzbd3UE NsH+oFVHsS/1V41XIueMo463+vJNuzbCsTojadG/PZ2HjG/VvvVm467GZgoGbYfWrlXb byHz54hDk5QtYMhKYXLqi1GIg2P43fz2tLrcZrxg4zdqTptbZKW+6fLN2CFRHhkjNElY ClPw== X-Forwarded-Encrypted: i=1; AKwUvBw4STs4LnUBLBtPLXZKhgptWQQcSBI9lwiJ0cfLCSRiR06SdQVeYvNO3nOjvllfzQgD+4R0G1AFV59zJ8fuXA==@lists.infradead.org X-Gm-Message-State: AFuF++kFhdia19v64fsk33vwaDE7BjWAFhkeSS8C3Rm+qJqhTD7gPPZN LFbWyvgMTCbCChQY+lWAmIRm8CZ2uhxLQtuYeGPqqeg6pG063FoqmPe/ X-Gm-Gg: AYBFou1BgxrLoIxx9oxq0MBtukcg1eNsT0EeesIEqISdqjYLk0vAcVihnPuAGu3CzaE /PUOdITUcu2+hegIHUuCHDJucj9iQY3cuECXwZVfFbSlNBNppwvSnpZdrxrpl+B8Fbd/gigCWoZ 44BdFoDZ2MoB8befkakMiKjBFQGZuS45FiUFTOb6il7ySEi1pi+iORQlBgryvpYR3Clg0qS4GJr FhoIxI+OXF1qwblP5KQg5+pF+5w2zYbGZI1qdrlDjVg/0LjlWGt0AEtknrIfP7z2QUdF1SFk/SA Aek5oIk2WxMMQLRvWtHyBGfJe3TmXlxu+TcMWJY1bvcWCYe20m1avSYz6Lo7jppboQIecMizWWE tkDt5nGEhH8ZSlKkMKKYxmGTslCcfR5kgT2v+rxEIDMsUSysnZG4mpltuVd9QnOE+wC1Q0eT/Sx s4O7aMZSpaDv0VBV0BFnvlzfXswXLtk1kkH2UkfxRUnhmQDy0k5nnrcDG4TwCU7RPVthOYozRzK +tMSQxFjDMxnRCPbLUTJR3sdb+cjO509NvYUC5WvSLcYizvsG+CyxrDkB9/uzHIjMy46rFuVKmJ KZkhJ34xekRxoQ== X-Received: by 2002:a05:693c:88c6:10b0:328:3944:ee53 with SMTP id 5a478bee46e88-3515da28859mr6112721eec.2.1791456295330; Thu, 08 Oct 2026 03:44:55 -0700 (PDT) Received: from phuc-desktop.. ([183.91.15.56]) by smtp.gmail.com with ESMTPSA id 5a478bee46e88-3517810b895sm7496369eec.17.2026.10.08.03.44.42 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 08 Oct 2026 03:44:54 -0700 (PDT) From: phucduc.bui@gmail.com To: Vijendar Mukunda , Venkata Prasad Potturu , Liam Girdwood , Mark Brown , Jaroslav Kysela , Takashi Iwai , povik+lin@cutebit.org, Claudiu Beznea , Andrei Simion , Nicolas Ferre , Alexandre Belloni , David Rhodes , Richard Fitzgerald , Shengjiu Wang , Xiubo Li , Fabio Estevam , Nicolin Chen , Frank Li , Sascha Hauer , Pengutronix Kernel Team , Cezary Rojewski , Peter Ujfalusi , Bard Liao , Kai Vehmanen , Pierre-Louis Bossart , Kuninori Morimoto , Geert Uytterhoeven , Magnus Damm , Biju Das , Lad Prabhakar , Heiko Stuebner Subject: [PATCH 23/24] ASoC: rockchip: rk3399_gru_sound: Mark the link as started on success Date: Thu, 8 Oct 2026 17:38:30 +0700 Message-ID: <20261008103831.542533-24-phucduc.bui@gmail.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20261008103831.542533-1-phucduc.bui@gmail.com> References: <20261008103831.542533-1-phucduc.bui@gmail.com> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.9.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20261008_034456_319825_7E849419 X-CRM114-Status: GOOD ( 13.07 ) X-BeenThere: linux-rockchip@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Upstream kernel work for Rockchip platforms List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: imx@lists.linux.dev, wangdicheng , Kees Cook , Sang-Heon Jeon , Pengpeng Hou , Bo Shen , Neo Chang , linux-rockchip@lists.infradead.org, bui duc phuc , Chris Bainbridge , Charles Keepax , linux-sound@vger.kernel.org, Ravulapati Vishnu vardhan rao , u.kleine-koenig@baylibre.com, Zain Aboobacker , Bjorn Helgaas , Md Shofiqul Islam , linux-arm-kernel@lists.infradead.org, Krzysztof Kozlowski , Ajit Kumar Pandey , patches@opensource.cirrus.com, Linus Walleij , linux-kernel@vger.kernel.org, linux-renesas-soc@vger.kernel.org, Vinod Koul , asahi@lists.linux.dev, Hemanth Selam , linuxppc-dev@lists.ozlabs.org, Syed Saba Kareem Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "Linux-rockchip" Errors-To: linux-rockchip-bounces+linux-rockchip=archiver.kernel.org@lists.infradead.org From: bui duc phuc snd_pcm_hw_constraint_minmax() may return 1, which is then returned from rockchip_sound_startup(). ASoC only marks the DAI link as started when .startup() returns 0. This currently has no functional impact, as there is no .shutdown() callback in the relevant snd_soc_ops. Still, return 0 explicitly on success to match what ASoC expects and ensure the DAI link is correctly marked as started. Signed-off-by: bui duc phuc --- sound/soc/rockchip/rk3399_gru_sound.c | 9 +++++++-- 1 file changed, 7 insertions(+), 2 deletions(-) diff --git a/sound/soc/rockchip/rk3399_gru_sound.c b/sound/soc/rockchip/rk3399_gru_sound.c index 04e7bed8275d..0ec80a4b8c59 100644 --- a/sound/soc/rockchip/rk3399_gru_sound.c +++ b/sound/soc/rockchip/rk3399_gru_sound.c @@ -258,10 +258,15 @@ static int rockchip_sound_dmic_hw_params(struct snd_pcm_substream *substream, static int rockchip_sound_startup(struct snd_pcm_substream *substream) { struct snd_pcm_runtime *runtime = substream->runtime; + int ret; runtime->hw.formats = SNDRV_PCM_FMTBIT_S16_LE; - return snd_pcm_hw_constraint_minmax(runtime, SNDRV_PCM_HW_PARAM_RATE, - 8000, 96000); + ret = snd_pcm_hw_constraint_minmax(runtime, SNDRV_PCM_HW_PARAM_RATE, + 8000, 96000); + if (ret < 0) + return ret; + + return 0; } static const struct snd_soc_ops rockchip_sound_max98357a_ops = { -- 2.43.0 _______________________________________________ Linux-rockchip mailing list Linux-rockchip@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-rockchip