From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-dy1-f176.google.com (mail-dy1-f176.google.com [74.125.82.176]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 6FA8D435515 for ; Thu, 8 Oct 2026 10:45:13 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=74.125.82.176 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1791456314; cv=none; b=lH54Sg9tArCptxcvi6XZFHyQkyVB+F/x+ZA+mxbGUpvZNmqbjLyzJ2cA/q5OXCBCFTRmxw7epKHzNGfE6n9QWCkvHrH8smQvDzhG5FmndTlONTwPA7jOZRaKm4fx1RVa/sRssDjw9PlejSWsI7wl18Sfq+yRLn3Yqjn/8rUPx+o= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1791456314; c=relaxed/simple; bh=M7h07h5+dP8rjX/g2P5EgQzQZW5pCcmiayOZWTe/ZUU=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=l77h6IjcD8NODJY8FBxEV7b+ZtbH/EV5bio0kTsR4+glJTX5Fe+vTDngsEtjq7qFcpuBa8gl5Qbvpr2M5M5bNtH1PNsXVunFkJOqAcEGw5cp/qS1yOfocWB5Al0eLQltkamQLlR+SuaqyRSJE7Bpg5F9fynMDbHCp4rFwSWdlUg= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=bvOP8TWN; arc=none smtp.client-ip=74.125.82.176 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="bvOP8TWN" Received: by mail-dy1-f176.google.com with SMTP id 5a478bee46e88-3115c4451c8so4256423eec.1 for ; Thu, 08 Oct 2026 03:45:13 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1791456313; x=1792061113; darn=lists.linux.dev; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to:content-type; bh=ew3yWeVvT9O5tBkIFDkvF2j0W+vU1/CnrAg2Miccmy4=; b=bvOP8TWNqnp2otx6BXwDh+114Ks0gEHACRsnESCW8rIWxNsEutKtfJMCTcGVI2MUGF Jyaj9eb4v35NgFQtEoKsYjvUVGALEV7KkZr+JrCLgEVcMGzKa6/4p4p7yTLbfuIWsqnf RQ4AMar45lnxUSrzxv4tf5xW2WVq1L8jxOt/UvQCJFsc/ukc0wr0G135mWJdPn75UpLC lp7kwYpEazlnq3+DdwrpvRfoLU/iyyUNrhC98pQ/UIG6zs165nYlgxByheiQflTcs8S9 x7yyguZGeKGIXBhD7/2pdtQ+TUMoPzegobh+Xhv3tBSVmFlr1+WBYHznPcQhDnx+UDxh AnaQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20260707; t=1791456313; x=1792061113; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to:content-type; bh=ew3yWeVvT9O5tBkIFDkvF2j0W+vU1/CnrAg2Miccmy4=; b=tCVUG4ozUEmSHhZVQZpeCTOtMFg/HDkTJ/lPDOhbYobdeEyDA5DemWUrvgeKp7ZIkY Hr8zYzy+SQJGAjfsCwFdqT4uf+TGVPYrLx2h3SbH9Chv8jvtTHtBDSj3YOCIab9CMYFm 3bbxjqszmFhY8q860bucQTx0aDCSHLvAOXSsEwOixEp4KUVtV7SD0FfcdBIdHr3qYM7i x82JVOUxYP2i9Li3noUTKG7/XrmrjYpKi4DjBbK6ye3k3zZSn3D2+kvu33y0xiBTYXJF pm0SwFuiGuv4Jk+yP0yHCsKvBm8Jl7aM2ZsjkKNl2nQAFp7lCnE5b6zcKHmZcrwHccx4 HbUg== X-Forwarded-Encrypted: i=1; AKwUvBzirnCtwBV0EzpNaN5mtqElToJ2iKAwX5l1dGBT/t7xar3B+0iEbtRczasoxxoERx0j+yg/Xg==@lists.linux.dev X-Gm-Message-State: AFuF++mDaAfOjxyxY7PLVjFEZg2N0KoDuuZ1AAP7yFrPaoXP1hnyviuH ycm1PIAGGn3X9FApkMK19+SO4VWW0ZsFLPIz8q5VohVX67pOoqOzJJ1l X-Gm-Gg: AYBFou19LWnSk81PPp/zYcxtHssbvcVexj16/StDF5IO6i8BANk1x8rOdRC0xQOo18C ZuN2ZhPJMUrperaaqN2JBDym5YMKqu5/xIgVoybdler4KeVsGpt+H/oHljv+eUjenTWo04HnJ72 OoARxFMtDKDAvSnn9lG7DmpmHqdNcolhTQHMPkJEwmKbS3xBs1h/QTdOjVCc63K4H8tDiqZK40l aJebPgkkk8q7eQ9iWdDUDO9NbWpOY6zIHHwPlY6v6CAyWTWM3CHae2UxGy9nF7nHouSJrW/RGSt FVj0MpxfQlJa6Gb4qjURMt6yx+BRsugGVW82vOhL8wC+1/MsFt2Si55A78NDcdp8p+CYtz9o7Bx rethqOoqXbdu8KxqQ0nG38L5qCC5q3o+vDqMCcooipmyDm1Kib11jeJkI9WCbK/rrRMAnYkfRCZ cBnYvahj4bNhisBWTeR/XDAfjSC7pWqs34k7N+g5T5f4u1HJfqhhRGqNuNezrowaZLltoClIRMX 1AOVAybBwQ6CNCS8UMpN7NWQ4CHM1YQnYblAdExGfnkyAebYXcZQDNBrR2qk7h78/jp9um3+2Ae l/0mty+7rjbv3g== X-Received: by 2002:a05:7300:e9cf:20b0:339:851c:4c1 with SMTP id 5a478bee46e88-3517788c303mr2800571eec.18.1791456312416; Thu, 08 Oct 2026 03:45:12 -0700 (PDT) Received: from phuc-desktop.. ([183.91.15.56]) by smtp.gmail.com with ESMTPSA id 5a478bee46e88-3517810b895sm7496369eec.17.2026.10.08.03.44.59 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 08 Oct 2026 03:45:11 -0700 (PDT) From: phucduc.bui@gmail.com To: Vijendar Mukunda , Venkata Prasad Potturu , Liam Girdwood , Mark Brown , Jaroslav Kysela , Takashi Iwai , povik+lin@cutebit.org, Claudiu Beznea , Andrei Simion , Nicolas Ferre , Alexandre Belloni , David Rhodes , Richard Fitzgerald , Shengjiu Wang , Xiubo Li , Fabio Estevam , Nicolin Chen , Frank Li , Sascha Hauer , Pengutronix Kernel Team , Cezary Rojewski , Peter Ujfalusi , Bard Liao , Kai Vehmanen , Pierre-Louis Bossart , Kuninori Morimoto , Geert Uytterhoeven , Magnus Damm , Biju Das , Lad Prabhakar , Heiko Stuebner Cc: Kees Cook , Syed Saba Kareem , wangdicheng , Chris Bainbridge , Linus Walleij , Charles Keepax , Neo Chang , Krzysztof Kozlowski , u.kleine-koenig@baylibre.com, Pengpeng Hou , Cristian Ciocaltea , Hemanth Selam , Md Shofiqul Islam , Bjorn Helgaas , Zain Aboobacker , Sang-Heon Jeon , Ajit Kumar Pandey , Ravulapati Vishnu vardhan rao , Bo Shen , Vinod Koul , linux-sound@vger.kernel.org, asahi@lists.linux.dev, linux-arm-kernel@lists.infradead.org, patches@opensource.cirrus.com, linuxppc-dev@lists.ozlabs.org, imx@lists.linux.dev, linux-rockchip@lists.infradead.org, linux-renesas-soc@vger.kernel.org, linux-kernel@vger.kernel.org, bui duc phuc Subject: [PATCH 24/24] ASoC: rockchip: rockchip_max98090: Mark the link as started on success Date: Thu, 8 Oct 2026 17:38:31 +0700 Message-ID: <20261008103831.542533-25-phucduc.bui@gmail.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20261008103831.542533-1-phucduc.bui@gmail.com> References: <20261008103831.542533-1-phucduc.bui@gmail.com> Precedence: bulk X-Mailing-List: asahi@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit From: bui duc phuc snd_pcm_hw_constraint_minmax() may return 1, which is then returned from rk_aif1_startup(). ASoC only marks the DAI link as started when .startup() returns 0. This currently has no functional impact, as there is no .shutdown() callback in the relevant snd_soc_ops. Still, return 0 explicitly on success to match what ASoC expects and ensure the DAI link is correctly marked as started. Signed-off-by: bui duc phuc --- sound/soc/rockchip/rockchip_max98090.c | 10 ++++++++-- 1 file changed, 8 insertions(+), 2 deletions(-) diff --git a/sound/soc/rockchip/rockchip_max98090.c b/sound/soc/rockchip/rockchip_max98090.c index 426506a8e18e..d54c36682415 100644 --- a/sound/soc/rockchip/rockchip_max98090.c +++ b/sound/soc/rockchip/rockchip_max98090.c @@ -191,12 +191,18 @@ static int rk_aif1_hw_params(struct snd_pcm_substream *substream, static int rk_aif1_startup(struct snd_pcm_substream *substream) { + int ret; /* * Set period size to 240 because pl330 has issue * dealing with larger period in stress testing. */ - return snd_pcm_hw_constraint_minmax(substream->runtime, - SNDRV_PCM_HW_PARAM_PERIOD_SIZE, 240, 240); + ret = snd_pcm_hw_constraint_minmax(substream->runtime, + SNDRV_PCM_HW_PARAM_PERIOD_SIZE, + 240, 240); + if (ret < 0) + return ret; + + return 0; } static const struct snd_soc_ops rk_aif1_ops = { -- 2.43.0 From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id BFC10CA600E for ; Thu, 8 Oct 2026 10:45:19 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-ID:Date:Subject:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=29Y+XiKWwvPcHhN9hP1A5H2TvBOw+7wMIZl8ZSR56pQ=; b=yHeNoODaG0Pcy/ mvp7MIcRw2CxzzBOUkJfd05szh7Qx+2B3v4Ous4L+7Mhw0Wy9nGlrbXhTgdI9uc7Sa0QN/SLby8CT JCqwo8zYGCktdLaqJw5xQNtYAC11fRlNcR/PgOJ9PbEtqgdac/4LLUAIfIbZRA6uB9SqU+GxCU5J+ NZ1r8FiUPFrq6DGOTDFsM7ZLo53Ix26CHEdwz/imVDFMLKrCpFXnmiCEOvUc4VGZP2Sf+DqW5YAkG jg0xIBwZQUr7c6lg5FVLHT5IACdQWphixbWl9E2SAhkbAV+gUSN35KDl/jhAhO/0bsWDjjux11lmJ uhBg2M+16kaqgP13e3sw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.99.1 #2 (Red Hat Linux)) id 1xElcj-00000004Bfn-2a4B; Thu, 08 Oct 2026 10:45:17 +0000 Received: from mail-dy1-x1333.google.com ([2607:f8b0:4864:20::1333]) by bombadil.infradead.org with esmtps (Exim 4.99.1 #2 (Red Hat Linux)) id 1xElcf-00000004Bde-1nWn for linux-rockchip@lists.infradead.org; Thu, 08 Oct 2026 10:45:15 +0000 Received: by mail-dy1-x1333.google.com with SMTP id 5a478bee46e88-3518cbe59b0so252749eec.0 for ; Thu, 08 Oct 2026 03:45:13 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1791456312; x=1792061112; darn=lists.infradead.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to:content-type; bh=ew3yWeVvT9O5tBkIFDkvF2j0W+vU1/CnrAg2Miccmy4=; b=EQk8cmvJ8vt/c4jC9hB7A7Y7x8arRSivO5guZcPrmBmI3ppyrx4t0txusAB2OeaPuV 6dDb/jd+pROPo8ZVjTwp1cecndQRp77ZiJ63hq6YmEeEro4UbBZWbtl6pt6mKiAu+h8L bpzpAAc1479ujD5nFPQA/pHBW5IP8yva3ev/4QmJb+yfFm7p3CHJUhcEiZWQUMnAchCa K+S6KjPzBgTv7jiM7XlgeyIl65PMSEppA6yAhb+Bvksy12AvxjkIG0/8BLjtKi6a7hAa eu0BaYVaz/Li3+w9WCKkijjwc5hIl7Dq+hmhZYpMesuJ7SMeFzJZg19pjJaRPN0ppnvv wvPQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20260707; t=1791456313; x=1792061113; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to:content-type; bh=ew3yWeVvT9O5tBkIFDkvF2j0W+vU1/CnrAg2Miccmy4=; b=wwFaREqVOR5v7qrnWiFejK66guNtoqGBDU00nLsrGP6G661PIMQUtvEThXwINBqF3Q N/kZvP2+rWgQay2mKfzD3rgPzrGqJJXVVUnLnI/1S7vX2iPmtcggcYwD0koFQ5uXVBiP h3v3tcQIrXZ/A8w4uRl7QyRdiBEblVH/AXLjdb+5xrNu4BNk7wvuhJ0vFwQNSBPHSRlG AI/T57FRPgbFKZn1vzbueYaiJVQSak+kjdPEEzdfRHOXrsdIweL3KU5Y+ile19o4Fk1X OIO05OMUUMkB9INKHqkRyQWtjzt5gVD/U+1DmRYaQ6IyFgRS4aiz2U3kXiWfaZHEuuRQ /DEw== X-Forwarded-Encrypted: i=1; AKwUvBy4t4c7trRTlC+65YO2QxZrjpYHTNtn6ZgPr83qlo2JwwCLudbupgHGK7VEr6xu/Tn7Fh3hMLojvIZWdLsqlw==@lists.infradead.org X-Gm-Message-State: AFuF++k8fxV93GFqU+hbO6HciGrYVDvZf66cunSGox8l+5+vdxB6K9tK 9AZgArO3SXW7w7lO+CynWCabJR5t54kAq6iNzmVfDNM+4ZREUpqgikJv X-Gm-Gg: AYBFou37TGH4hL2HO5fe272zghcHl6+WTaswyTBE3CBaeTERUnIsQ1i4elAlDmBvVeR G3sON0X/XzXdYQceSXoRtNGcYq9uhw/CQaj2z1ojiR1NiW6z3EbmGFzvxmQMXzn8xXdfJxiQzAh SCHa3tgV6dJhWpj0Jymqx+CLJGkctnTjzg3k39RfOyYLvFuYJgVcXHKlJVU+l/Mu8Q+RpJy1b9V AC+xSYlefMcZjgt4DwSb2Wq/zdbPDq3OVOfDBifALiVE4K27OPW9L5NC1uTmqKyp5YZeVGc0gIU ehFMzKGcAgkDmyRSvVIPa4T3+B4cM7qFZ57aP/CS+pLgpet5kI4RUw+uGCOHV7SmbTegoelBsIx O1TuJVrn21JnWo7k0rdNVd1GAELnpzwPe0ThSs2K9nPUrGE0wvlNTRqXRdBkobOCsZdqdFYi8lv ZvHYvg9ofr2pQS02NJw8watzQl/zGIxvcOeoulv5aibc/zJb3ZudYH+ZEgE/SKExeOhf0cXYAa+ rkqUSNVOSdAQM/FDnqOyuRDa8yDstedQz9r9ORTxLeEkTaIeCQNK4Q+paw3ShXCrT90wJN7JlN/ Sv5ikHWrNcJMeA== X-Received: by 2002:a05:7300:e9cf:20b0:339:851c:4c1 with SMTP id 5a478bee46e88-3517788c303mr2800571eec.18.1791456312416; Thu, 08 Oct 2026 03:45:12 -0700 (PDT) Received: from phuc-desktop.. ([183.91.15.56]) by smtp.gmail.com with ESMTPSA id 5a478bee46e88-3517810b895sm7496369eec.17.2026.10.08.03.44.59 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 08 Oct 2026 03:45:11 -0700 (PDT) From: phucduc.bui@gmail.com To: Vijendar Mukunda , Venkata Prasad Potturu , Liam Girdwood , Mark Brown , Jaroslav Kysela , Takashi Iwai , povik+lin@cutebit.org, Claudiu Beznea , Andrei Simion , Nicolas Ferre , Alexandre Belloni , David Rhodes , Richard Fitzgerald , Shengjiu Wang , Xiubo Li , Fabio Estevam , Nicolin Chen , Frank Li , Sascha Hauer , Pengutronix Kernel Team , Cezary Rojewski , Peter Ujfalusi , Bard Liao , Kai Vehmanen , Pierre-Louis Bossart , Kuninori Morimoto , Geert Uytterhoeven , Magnus Damm , Biju Das , Lad Prabhakar , Heiko Stuebner Subject: [PATCH 24/24] ASoC: rockchip: rockchip_max98090: Mark the link as started on success Date: Thu, 8 Oct 2026 17:38:31 +0700 Message-ID: <20261008103831.542533-25-phucduc.bui@gmail.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20261008103831.542533-1-phucduc.bui@gmail.com> References: <20261008103831.542533-1-phucduc.bui@gmail.com> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.9.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20261008_034513_471408_2D7B1462 X-CRM114-Status: GOOD ( 14.48 ) X-BeenThere: linux-rockchip@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Upstream kernel work for Rockchip platforms List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: imx@lists.linux.dev, wangdicheng , Kees Cook , Sang-Heon Jeon , Pengpeng Hou , Bo Shen , Neo Chang , linux-rockchip@lists.infradead.org, bui duc phuc , Chris Bainbridge , Charles Keepax , linux-sound@vger.kernel.org, Ravulapati Vishnu vardhan rao , u.kleine-koenig@baylibre.com, Zain Aboobacker , Bjorn Helgaas , Md Shofiqul Islam , linux-arm-kernel@lists.infradead.org, Krzysztof Kozlowski , Ajit Kumar Pandey , patches@opensource.cirrus.com, Linus Walleij , linux-kernel@vger.kernel.org, linux-renesas-soc@vger.kernel.org, Vinod Koul , asahi@lists.linux.dev, Hemanth Selam , linuxppc-dev@lists.ozlabs.org, Syed Saba Kareem Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "Linux-rockchip" Errors-To: linux-rockchip-bounces+linux-rockchip=archiver.kernel.org@lists.infradead.org From: bui duc phuc snd_pcm_hw_constraint_minmax() may return 1, which is then returned from rk_aif1_startup(). ASoC only marks the DAI link as started when .startup() returns 0. This currently has no functional impact, as there is no .shutdown() callback in the relevant snd_soc_ops. Still, return 0 explicitly on success to match what ASoC expects and ensure the DAI link is correctly marked as started. Signed-off-by: bui duc phuc --- sound/soc/rockchip/rockchip_max98090.c | 10 ++++++++-- 1 file changed, 8 insertions(+), 2 deletions(-) diff --git a/sound/soc/rockchip/rockchip_max98090.c b/sound/soc/rockchip/rockchip_max98090.c index 426506a8e18e..d54c36682415 100644 --- a/sound/soc/rockchip/rockchip_max98090.c +++ b/sound/soc/rockchip/rockchip_max98090.c @@ -191,12 +191,18 @@ static int rk_aif1_hw_params(struct snd_pcm_substream *substream, static int rk_aif1_startup(struct snd_pcm_substream *substream) { + int ret; /* * Set period size to 240 because pl330 has issue * dealing with larger period in stress testing. */ - return snd_pcm_hw_constraint_minmax(substream->runtime, - SNDRV_PCM_HW_PARAM_PERIOD_SIZE, 240, 240); + ret = snd_pcm_hw_constraint_minmax(substream->runtime, + SNDRV_PCM_HW_PARAM_PERIOD_SIZE, + 240, 240); + if (ret < 0) + return ret; + + return 0; } static const struct snd_soc_ops rk_aif1_ops = { -- 2.43.0 _______________________________________________ Linux-rockchip mailing list Linux-rockchip@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-rockchip