From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-dy1-f174.google.com (mail-dy1-f174.google.com [74.125.82.174]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id F20203E9C11 for ; Thu, 8 Oct 2026 10:40:22 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=74.125.82.174 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1791456024; cv=none; b=FAd5lRjpTslE10UcMwngPJp7Hs2tnrV4tSyogyH1as0HQ5CNirfnQfsJ68vNikSY8niFvy2G/EL9h8VjgJc3fYAYb4K5FZLrpXxomuTWSnD0y9MmOsHC/Rns6vo9lOkZqUPMzMn0eMZ5Ge/80Y527TdmQGKBUpTOKDspS+Kd1bE= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1791456024; c=relaxed/simple; bh=aAJwqH/KKsd5BFgyPNOpN1XC3DMyvJ2Ee51+WOeaFBI=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=RpfSltvLFTiurgropqXOVBif8Wqk2UeqU3YfasPx4JX6DSUAQNWRrg7WQOAUgPhEpnqFhCX+wFY3JOPQU4Kh57toDU+z/jZ4Fgc6d+8kiPZ7EG/EGan+TuytHzFCp1OkJMuof9Q9YeYlbSOGjTdYmJ/YNSOhljhTgJe7q2IX9Ho= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=FAZBdd+N; arc=none smtp.client-ip=74.125.82.174 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="FAZBdd+N" Received: by mail-dy1-f174.google.com with SMTP id 5a478bee46e88-35120d43ecaso7719424eec.1 for ; Thu, 08 Oct 2026 03:40:22 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1791456022; x=1792060822; darn=lists.linux.dev; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to:content-type; bh=h9Ry8JRaSeFrVq0Ud0+uxs62YoBNOy3ejKA8MS9Fs2w=; b=FAZBdd+N01DkUu2hVTcRuAURqGbN6S6jJBDrK37WIHYIfe6NVAG23eNiYCE8t5oks0 nU9pEDnjm0js3nV9YXxMa+yMFoAALd8wrQCq+5cMU24TdWrip3JPOVgfXWj8pdNyh4va SjuitGiBuxGjqyDmLnBRfws9COeDDXmmoN3cXa/XFpM/YHS+evCsY70rYRI80LrhuL+U pbPszXJVxIohAHBDF0Z1QZcTTeuMzc1Uc8bra6wp8SJ2LDTFP/nK3GZWIB9lUQTdOhE7 6+TEKs3pmXdpZr8z8vGK2VJDwqTC01g1lCed8yxdWvXb1h0cgn9j4Hysp0FRFF9LJEOZ +uoA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20260707; t=1791456022; x=1792060822; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to:content-type; bh=h9Ry8JRaSeFrVq0Ud0+uxs62YoBNOy3ejKA8MS9Fs2w=; b=iwSDWJ9OdRXzXoz97Xp+CUEKul/nLyicdWBKqGfqfZQMx0ixpAOmmzm/TnL36UN3so oM32fM1JSWqMatHOA4TsxgfC0zHxSaNzxSXqgSe4F3mbLs2eZt7oVdcZFzcA5/RymKLK PS0oIWqO98ieDHaS8HHwXGNQjTBpZ0/E1xgEmuIMQKg4a13t9v2Uw6tOjLj7ZoMvhz8f L5/jl1PCcCNNdp8e1uBjVGZHJNVSdhNUwGX8rAHz10jgutt8IMNCitTyME7Z0lCtro7V hnPdJjH1cfyMYfOkPCdJ7vV+kkmrOT7aKYFjKHDzHzDa1yfgpk40x3sfzLDDVPTDfUDU wFGg== X-Forwarded-Encrypted: i=1; AKwUvBweRyaidKWMzzoi37JkBS96pt8H/bzZ8x4th3BGLPfspmJiA8c3mKD1H7fyp3EmOX5GNhE=@lists.linux.dev X-Gm-Message-State: AFuF++mFB2wbvEIETUGvQMMC5wZu2rOPDLCKqf6WXv+r0gXjSOPVJTQ3 /MkOwZgwAfPuJzpRFHWlBBmkTmKhR8dVOARBU+cHfa8Y2qKPJAWRND7j X-Gm-Gg: AYBFou2PlbhSaDLvlIYmfAtJoVOPRowptJU8Ggx7nT30Iublh5Gwkk7wxqlgjBUksqB f4Rr/tNqFYa7gS1OVyNctjduHtk56r6SRSjHOLvkvPbzQoOZOaXVMOn2+Ti+psHWeQ5mAfy5Qiy /8GXEm9d3okDAAhGJzkEXkv31q1SlEsac8lkQ0DkFBwnaJLEXqetm9WvLzEdO3OTWAw0RTWCzLE nRuSD9KwQGLFntlY+oyJgdupf6cTMofm9SPBasambpZQnZa3wKE4lAxfbCubbUy4HfZ/nb69wdz FzQ1K5mv7raelTon7HYYVeuq44F/zYwSq1GO3W1mouHcZS36URIKT7GKhQdq6VdfzwBu3edGVWu DU9949M3vhotF0/8hPR7NT5zL9wEPK7ON70WVEs4W0zyW4wsrlMZLE4joCZPy9fql2Cg1Idlr3Q 7JwxOdx/XOgahI/7ATikUKBSyARF1fH3EJNJH6+9pxh7fhRWxGDH7O57XafQzERwKuEH8wHD9Ro g/Z+2bP1s53CgjJEG2VSgt6PSEtAhLoPuGppua8xLCye6s0e1gAiZ+iZvJDaOg7Cd5zj1fuB3RX rZlQOO/moZJcT8zxvMnH4a7+ X-Received: by 2002:a05:693c:414b:20b0:351:1e2e:da4d with SMTP id 5a478bee46e88-3515def434bmr6671263eec.23.1791456022013; Thu, 08 Oct 2026 03:40:22 -0700 (PDT) Received: from phuc-desktop.. ([183.91.15.56]) by smtp.gmail.com with ESMTPSA id 5a478bee46e88-3517810b895sm7496369eec.17.2026.10.08.03.40.08 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 08 Oct 2026 03:40:20 -0700 (PDT) From: phucduc.bui@gmail.com To: Vijendar Mukunda , Venkata Prasad Potturu , Liam Girdwood , Mark Brown , Jaroslav Kysela , Takashi Iwai , povik+lin@cutebit.org, Claudiu Beznea , Andrei Simion , Nicolas Ferre , Alexandre Belloni , David Rhodes , Richard Fitzgerald , Shengjiu Wang , Xiubo Li , Fabio Estevam , Nicolin Chen , Frank Li , Sascha Hauer , Pengutronix Kernel Team , Cezary Rojewski , Peter Ujfalusi , Bard Liao , Kai Vehmanen , Pierre-Louis Bossart , Kuninori Morimoto , Geert Uytterhoeven , Magnus Damm , Biju Das , Lad Prabhakar , Heiko Stuebner Cc: Kees Cook , Syed Saba Kareem , wangdicheng , Chris Bainbridge , Linus Walleij , Charles Keepax , Neo Chang , Krzysztof Kozlowski , u.kleine-koenig@baylibre.com, Pengpeng Hou , Cristian Ciocaltea , Hemanth Selam , Md Shofiqul Islam , Bjorn Helgaas , Zain Aboobacker , Sang-Heon Jeon , Ajit Kumar Pandey , Ravulapati Vishnu vardhan rao , Bo Shen , Vinod Koul , linux-sound@vger.kernel.org, asahi@lists.linux.dev, linux-arm-kernel@lists.infradead.org, patches@opensource.cirrus.com, linuxppc-dev@lists.ozlabs.org, imx@lists.linux.dev, linux-rockchip@lists.infradead.org, linux-renesas-soc@vger.kernel.org, linux-kernel@vger.kernel.org, bui duc phuc Subject: [PATCH 05/24] ASoC: amd: renoir: Fix acp_pdm_dma_close() being skipped on rollback Date: Thu, 8 Oct 2026 17:38:12 +0700 Message-ID: <20261008103831.542533-6-phucduc.bui@gmail.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20261008103831.542533-1-phucduc.bui@gmail.com> References: <20261008103831.542533-1-phucduc.bui@gmail.com> Precedence: bulk X-Mailing-List: imx@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit From: bui duc phuc snd_pcm_hw_constraint_integer() may return 1, which is then returned from acp_pdm_dma_open(). ASoC only marks the component as opened when .open() returns 0, so .close() can be skipped on rollback. Return 0 explicitly on success. Fixes: 4a767b1d039a ("ASoC: amd: add acp3x pdm driver dma ops") Signed-off-by: bui duc phuc --- sound/soc/amd/renoir/acp3x-pdm-dma.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/sound/soc/amd/renoir/acp3x-pdm-dma.c b/sound/soc/amd/renoir/acp3x-pdm-dma.c index 3f59b753243d..c0481a9ba858 100644 --- a/sound/soc/amd/renoir/acp3x-pdm-dma.c +++ b/sound/soc/amd/renoir/acp3x-pdm-dma.c @@ -233,7 +233,7 @@ static int acp_pdm_dma_open(struct snd_soc_component *component, pdm_data->acp_base = adata->acp_base; runtime->private_data = pdm_data; - return ret; + return 0; } static int acp_pdm_dma_hw_params(struct snd_soc_component *component, -- 2.43.0 From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 5362CCA600B for ; Thu, 8 Oct 2026 10:40:28 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-ID:Date:Subject:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=zZ0o7NW1Qf0t4HRDLo6BV5ux06RFBgY061eoBTRLRD0=; b=Aw+SkrNmGJ2Sow MBeBC/M/9LE9nk93EvUSg7u5pdhR/1VZcQIMSfC5GB5zm1OZRmwPdsTQreqzTGeka6DQl7GbrsIjr KtV8Iv1qaOUDRHvhjVbNkcMV1xTJBA9u0b1BLymiX6nva3+szqaH3dTeLG6zaGJ5n5w56Xpnq2dOC 5jBtA9X4bJCBJQ7v46lRwQeogOpJZp4IdLMT863lTWSN/mTMAUM2WJebB0JeP0LqhxKxxi3B7a13M BIo1qtYY7jXAxyJsaAt+6MNoqRfHD5eRhpQZ+reKZWaIVaYPB/Nw3FMrQkT4d4MHyCtgr1x9Cyaih 0ey0VnLUyT7U2Zy5hOrg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.99.1 #2 (Red Hat Linux)) id 1xElY2-000000049dx-0Oqq; Thu, 08 Oct 2026 10:40:26 +0000 Received: from mail-dy1-x1333.google.com ([2607:f8b0:4864:20::1333]) by bombadil.infradead.org with esmtps (Exim 4.99.1 #2 (Red Hat Linux)) id 1xElXy-000000049cq-3ee4 for linux-rockchip@lists.infradead.org; Thu, 08 Oct 2026 10:40:24 +0000 Received: by mail-dy1-x1333.google.com with SMTP id 5a478bee46e88-34bb8b31647so7925304eec.0 for ; Thu, 08 Oct 2026 03:40:22 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1791456022; x=1792060822; darn=lists.infradead.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to:content-type; bh=h9Ry8JRaSeFrVq0Ud0+uxs62YoBNOy3ejKA8MS9Fs2w=; b=jiL/zILzAhRkao46+rwiJ29wKapEuKJUyBvTzV29j+SX2Fr0X7xS8s7+2yzDoll7Gn scyOIt034EylWYwUZZxu1O8UkDrgH1eZzDTaHj9vdOZD1CqCOZLWKqztrjZb/HMuGJ+k rCcjlD/s7OTnlCSYQAe4muaqmAPNaa5EQS1csf7GjiBQJiP2zJbR2TnbIqU2U6drkTkg cWGzwpRG/7jdHSqVjuNd6o2kFF8n7DMxUxgUiVjRgtb5KBn3fCxLxV2YcrY+DMZBjRWL 32lREx3IFSC6HPGmUVzbIuJbPM+f4Kv0O03qlrYmsSWtwoRChN3qRKA/bzgiA9fKSPvF ob6Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20260707; t=1791456022; x=1792060822; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to:content-type; bh=h9Ry8JRaSeFrVq0Ud0+uxs62YoBNOy3ejKA8MS9Fs2w=; b=tdw7mveOcomqjB7GSaA0XHMtLWG6p59sPhqKm2Z3q9lktdA411Ao/38k6E7ClA93MW QgaRomKnzGNYOZhPhSPta6iO9l1fMqU5kmHCJXC58T9GXLgyVvNeX4whZPFgvZgtbvDR YDreiJ0kkZbfPpcqAHYj0FIMcOhexrSai8ttZLBItvLbZ6Ux9vKmVFPtTvzM8l3puFaR wNRkOn5tE1WuUd2yPCtsPzUjDXCx5cgHCD4T86dYYqK2MvAyK+aahG5nTkmLK48/Qydq Zwek49ZKMbCkPZK1cK0BFrhZLGy79hlSEm/IZw+GQRLt0hlqAUTzrNuruMzhQPgbyEgu oVGg== X-Forwarded-Encrypted: i=1; AKwUvBxBpOa1Y1R27eZvfRvH4T9FKnia2+hOM1V4/QTPYnLdpr0vGFDJMrVyWM92sz7XjhQH21a+8/yKNyYDrDFDIA==@lists.infradead.org X-Gm-Message-State: AFuF++n+7O7m8Nyvh3AygDFo0Nitg+xwgv/bB6FTCcq5cjQJmspuxdCH ZM5iuP82YhpSVyhEhDjP3GGYmaRg8x0JsHnkp5tRQKGEmng/4VpYMurz X-Gm-Gg: AYBFou1lb6s1oQeVDklDRXVqHwnp31mQEbjGVJwO+xhmm3+1u/cITCI5om25ZvmaJfn FVovkQC2XeIYrF1IxWe4yskIHe8BuqAjmiF9JQAxazDkfpZFy9PTBIrvZnV8fJIga6o3jpHSsRc ftiEoeEG8P6yDKK46jkDPyreZm5Hw0sawifbZYU0S0KQaVbpn8L60+Ns5mUmuJ1FmmDWhi7RIUQ 9UIwmttBk2OvcXhjxjyOtqsMamDRUYWinpEV4rN7gfOUlgeSsEI0OC19cwnHDx6+XRYbrPR84g2 1IIWatQ5V1XYgSt2XPgkaNDCWj8mvFA/xpTcv36ayHbMPpF+eAB/HxvNCQ6tC8BfiDHH42vwkgk UZP7WhwGcNJeWqXkhc6BZijVJjYARdg4blaEr+b5jDJw7mfOPGI4wRAgRkxzAkgBiWTeFbeeuhY O6eYCRiFinjl37/pvgf4tXWbo6SE04KFt1HqJPV40AcHlfBWyPL9ZaU6OD5FNni80LlecpoIQZQ eyPYQXlpjZCNe0wT5M+rCiAIF+6RvC6VACigRAW8CrjOifGR9aJRixxWLrIZE77iLrX/AKZ/8lp qfYukYK6zFYkzdgRadEgSOnv X-Received: by 2002:a05:693c:414b:20b0:351:1e2e:da4d with SMTP id 5a478bee46e88-3515def434bmr6671263eec.23.1791456022013; Thu, 08 Oct 2026 03:40:22 -0700 (PDT) Received: from phuc-desktop.. ([183.91.15.56]) by smtp.gmail.com with ESMTPSA id 5a478bee46e88-3517810b895sm7496369eec.17.2026.10.08.03.40.08 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 08 Oct 2026 03:40:20 -0700 (PDT) From: phucduc.bui@gmail.com To: Vijendar Mukunda , Venkata Prasad Potturu , Liam Girdwood , Mark Brown , Jaroslav Kysela , Takashi Iwai , povik+lin@cutebit.org, Claudiu Beznea , Andrei Simion , Nicolas Ferre , Alexandre Belloni , David Rhodes , Richard Fitzgerald , Shengjiu Wang , Xiubo Li , Fabio Estevam , Nicolin Chen , Frank Li , Sascha Hauer , Pengutronix Kernel Team , Cezary Rojewski , Peter Ujfalusi , Bard Liao , Kai Vehmanen , Pierre-Louis Bossart , Kuninori Morimoto , Geert Uytterhoeven , Magnus Damm , Biju Das , Lad Prabhakar , Heiko Stuebner Subject: [PATCH 05/24] ASoC: amd: renoir: Fix acp_pdm_dma_close() being skipped on rollback Date: Thu, 8 Oct 2026 17:38:12 +0700 Message-ID: <20261008103831.542533-6-phucduc.bui@gmail.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20261008103831.542533-1-phucduc.bui@gmail.com> References: <20261008103831.542533-1-phucduc.bui@gmail.com> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.9.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20261008_034022_911681_0E4405D9 X-CRM114-Status: GOOD ( 12.09 ) X-BeenThere: linux-rockchip@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Upstream kernel work for Rockchip platforms List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: imx@lists.linux.dev, wangdicheng , Kees Cook , Sang-Heon Jeon , Pengpeng Hou , Bo Shen , Neo Chang , linux-rockchip@lists.infradead.org, bui duc phuc , Chris Bainbridge , Charles Keepax , linux-sound@vger.kernel.org, Ravulapati Vishnu vardhan rao , u.kleine-koenig@baylibre.com, Zain Aboobacker , Bjorn Helgaas , Md Shofiqul Islam , linux-arm-kernel@lists.infradead.org, Krzysztof Kozlowski , Ajit Kumar Pandey , patches@opensource.cirrus.com, Linus Walleij , linux-kernel@vger.kernel.org, linux-renesas-soc@vger.kernel.org, Vinod Koul , asahi@lists.linux.dev, Hemanth Selam , linuxppc-dev@lists.ozlabs.org, Syed Saba Kareem Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "Linux-rockchip" Errors-To: linux-rockchip-bounces+linux-rockchip=archiver.kernel.org@lists.infradead.org From: bui duc phuc snd_pcm_hw_constraint_integer() may return 1, which is then returned from acp_pdm_dma_open(). ASoC only marks the component as opened when .open() returns 0, so .close() can be skipped on rollback. Return 0 explicitly on success. Fixes: 4a767b1d039a ("ASoC: amd: add acp3x pdm driver dma ops") Signed-off-by: bui duc phuc --- sound/soc/amd/renoir/acp3x-pdm-dma.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/sound/soc/amd/renoir/acp3x-pdm-dma.c b/sound/soc/amd/renoir/acp3x-pdm-dma.c index 3f59b753243d..c0481a9ba858 100644 --- a/sound/soc/amd/renoir/acp3x-pdm-dma.c +++ b/sound/soc/amd/renoir/acp3x-pdm-dma.c @@ -233,7 +233,7 @@ static int acp_pdm_dma_open(struct snd_soc_component *component, pdm_data->acp_base = adata->acp_base; runtime->private_data = pdm_data; - return ret; + return 0; } static int acp_pdm_dma_hw_params(struct snd_soc_component *component, -- 2.43.0 _______________________________________________ Linux-rockchip mailing list Linux-rockchip@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-rockchip