From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id B94B4CA6007 for ; Thu, 8 Oct 2026 10:40:55 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-ID:Date:Subject:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=Bg9yJgDq5kOuDjadTdiRfix6geH67FnxuuN4dCD+9Tc=; b=YYZd0p4+2YZ4ul AiHm/neu6TNjDC0qX0OAZiyjGliVl6wTOcIgeFCIouOLWUmJ3eIP0DQqttnXhC6CN3tCvlTT+HoRm bh82wTJdy/I7AV2o62xfd6pXOovZzLqdfht60i6wec9yZYTNwHFKlWuW8U8qqUoUFIlL58d7T3Qqq B8ICOyYq0W1L0GTYpGQ1iEHZ+3sA9iSSMf7JLrPu6tZeRZ6nNqoDyDkhtcaGDHiwS4OD0YnD8YjCB wHsK+bJNvBSbrvVi5E1UVF7t2M4/RnmhWRKo7QHiBVtsnefQ1DYss9Pd1xmKi2HrnCqEDbfnA5ODP 87TrLCRg5j85hI3CCXUw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.99.1 #2 (Red Hat Linux)) id 1xElYT-000000049nN-2Vwm; Thu, 08 Oct 2026 10:40:53 +0000 Received: from mail-dy1-x1334.google.com ([2607:f8b0:4864:20::1334]) by bombadil.infradead.org with esmtps (Exim 4.99.1 #2 (Red Hat Linux)) id 1xElYR-000000049mU-3npv for linux-rockchip@lists.infradead.org; Thu, 08 Oct 2026 10:40:53 +0000 Received: by mail-dy1-x1334.google.com with SMTP id 5a478bee46e88-35120d43ecaso7720253eec.1 for ; Thu, 08 Oct 2026 03:40:51 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1791456051; x=1792060851; darn=lists.infradead.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to:content-type; bh=A3hFCOdGFcpARJPE61Pz7wx4lXLyiEMweFG5G2TuDs0=; b=FuHsv3EGXUd22g0plp7KlKVqoJAPwFJm6nA/4wW32vEYBG3pNcyawNfq5hjl1LyXr8 Ne3CAksln9SAwbIzyusWx2dCDihFe9kmnVKaALFhFk8rNfICUZVL6XJKr60Q+9if/dSq J6uJWGnYGadR9oXRLkAygKwEBqjdyhL5mDpIFzaOmW81tVYOgQ7jDyRTMaWhF25VXHM+ XYENFq7aPhQ9xx8UGdhS+KlTs8yR5i+vhMLCBZlKygY/DbMKTdH26enGhZIL6rgn6fa8 HVLZiyXadlxsoVieD/fyXYjhXqGxx+8yCDEFkxrIdj7p5fL2K3imqKO6SIZef+MJyRTU SK7A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20260707; t=1791456051; x=1792060851; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to:content-type; bh=A3hFCOdGFcpARJPE61Pz7wx4lXLyiEMweFG5G2TuDs0=; b=ZpB+MDlQdUX2FIqlzNQfVzPvP59/uT1+8lDzYYq1ap7byf/Hh9XC5E70uZ/HhU/Zez UKOAI0BTx0hXgqbRBtW4jplBFWeiGCeuNI7RnVQFT4mN6b0mhjGJgiZBrHIB9rs+XBJb H44hK0/nNYeSMoRLBKDajUB0h97dTPfDLFWjwJTHtFeaZxA/30FniX2MRo2UdTJ+MSzP 79WZm08LzoqPEjSrB1lwYZdRel3pQqP7hsFC53amnllZ5lYPeS/rA4OjD8lFJuBq7bVJ I1vnapPyvra4SCPzfzGSwy1h3aCP15xyESO2A6zTZpkFtRGfQvcSu1wRFnMUrmOtoRyG Reag== X-Forwarded-Encrypted: i=1; AKwUvBw4LrdEdgimnj8NojuYLxSdt3F7rWJro8VGmH9eDd/oJaTTVpBO4DFdQIlV2Lm5YHdgK5uZvsD0vCpQ9pQ/lw==@lists.infradead.org X-Gm-Message-State: AFuF++nVPrzWYacR8T8MryhhqG0EPZJsgsDDQmTFAh+PKW9DPEwREUCQ vJw9Ga1RhHtLbDtftJ073IF6CIDlQlf8rfSDp6Tqv2t0cwTQMcDRKqk9 X-Gm-Gg: AYBFou1OIXLb7zyrCjf1jSZ5qKpKXDEamezaHxE6qHGZWaSBJ8dppj8t+w2E1Bt9FhV FAE7lpUbkud2g+L0DkbqRsF7xpNk4OFX4dSEkPZRdA9kS9jZ2Vz99s/0Gh47233M+ZP1+lHC0ob s5sb07pngDrTv3c6mNNStXquygvDdgulSLKeCt+Pi9asmDrhXNqR98fJYKGv5fbCUSckkKS5ZE+ es7VYih+CXbPcoXWVrhNqhQT5zjsssmL3GcrlhbD3LmDgkbV4vS9QBkkhCSiwttFdxoGQGXYZng JwRQaCyFTETFtQU9hG7JoNDA1JLUfESMljYdNLMS8xmu9ZykFl7GnlebcHZzBVU7lGHI8kFelZ0 +h2ec2LQWNiIcPklCtL/dfcv0HOF8OtSzEa8t3WQp1OG8S+Coepv1VzjMWwbaBWJcMFFO6632uE BEgMTLwUF4dQPK7+iQ9FRcHpPmjtjP3rfKMERnHGBhQXUSoxXDw25JxVXh/ToZ0zTMeFP7Pdfnr 0Z6nTUepQTvPjOmMZQlLl4L5Wv/wQkScApEr5szIZuNN5PGf/YkYIBWAIJ+VwcZb7fFqFxw5If0 pwxnOTLRSrUxJTsUH6x67pmI X-Received: by 2002:a05:693c:41d2:10b0:351:62fe:62 with SMTP id 5a478bee46e88-35162fe0200mr5293677eec.19.1791456050997; Thu, 08 Oct 2026 03:40:50 -0700 (PDT) Received: from phuc-desktop.. ([183.91.15.56]) by smtp.gmail.com with ESMTPSA id 5a478bee46e88-3517810b895sm7496369eec.17.2026.10.08.03.40.37 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 08 Oct 2026 03:40:49 -0700 (PDT) From: phucduc.bui@gmail.com To: Vijendar Mukunda , Venkata Prasad Potturu , Liam Girdwood , Mark Brown , Jaroslav Kysela , Takashi Iwai , povik+lin@cutebit.org, Claudiu Beznea , Andrei Simion , Nicolas Ferre , Alexandre Belloni , David Rhodes , Richard Fitzgerald , Shengjiu Wang , Xiubo Li , Fabio Estevam , Nicolin Chen , Frank Li , Sascha Hauer , Pengutronix Kernel Team , Cezary Rojewski , Peter Ujfalusi , Bard Liao , Kai Vehmanen , Pierre-Louis Bossart , Kuninori Morimoto , Geert Uytterhoeven , Magnus Damm , Biju Das , Lad Prabhakar , Heiko Stuebner Subject: [PATCH 07/24] ASoC: amd: yc: Fix acp6x_pdm_dma_close() being skipped on rollback Date: Thu, 8 Oct 2026 17:38:14 +0700 Message-ID: <20261008103831.542533-8-phucduc.bui@gmail.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20261008103831.542533-1-phucduc.bui@gmail.com> References: <20261008103831.542533-1-phucduc.bui@gmail.com> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.9.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20261008_034051_952020_356235BD X-CRM114-Status: GOOD ( 11.99 ) X-BeenThere: linux-rockchip@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Upstream kernel work for Rockchip platforms List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: imx@lists.linux.dev, wangdicheng , Kees Cook , Sang-Heon Jeon , Pengpeng Hou , Bo Shen , Neo Chang , linux-rockchip@lists.infradead.org, bui duc phuc , Chris Bainbridge , Charles Keepax , linux-sound@vger.kernel.org, Ravulapati Vishnu vardhan rao , u.kleine-koenig@baylibre.com, Zain Aboobacker , Bjorn Helgaas , Md Shofiqul Islam , linux-arm-kernel@lists.infradead.org, Krzysztof Kozlowski , Ajit Kumar Pandey , patches@opensource.cirrus.com, Linus Walleij , linux-kernel@vger.kernel.org, linux-renesas-soc@vger.kernel.org, Vinod Koul , asahi@lists.linux.dev, Hemanth Selam , linuxppc-dev@lists.ozlabs.org, Syed Saba Kareem Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "Linux-rockchip" Errors-To: linux-rockchip-bounces+linux-rockchip=archiver.kernel.org@lists.infradead.org From: bui duc phuc snd_pcm_hw_constraint_integer() may return 1, which is then returned from acp6x_pdm_dma_open(). ASoC only marks the component as opened when .open() returns 0, so .close() can be skipped on rollback. Return 0 explicitly on success. Fixes: ceb4fcc13ae5 ("ASoC: amd: add acp6x pdm driver dma ops") Signed-off-by: bui duc phuc --- sound/soc/amd/yc/acp6x-pdm-dma.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/sound/soc/amd/yc/acp6x-pdm-dma.c b/sound/soc/amd/yc/acp6x-pdm-dma.c index 40c4d833f4ed..afa9f66533e3 100644 --- a/sound/soc/amd/yc/acp6x-pdm-dma.c +++ b/sound/soc/amd/yc/acp6x-pdm-dma.c @@ -209,7 +209,7 @@ static int acp6x_pdm_dma_open(struct snd_soc_component *component, pdm_data->acp6x_base = adata->acp6x_base; runtime->private_data = pdm_data; - return ret; + return 0; } static int acp6x_pdm_dma_hw_params(struct snd_soc_component *component, -- 2.43.0 _______________________________________________ Linux-rockchip mailing list Linux-rockchip@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-rockchip From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-dy1-f170.google.com (mail-dy1-f170.google.com [74.125.82.170]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 0189F3BB133 for ; Thu, 8 Oct 2026 10:40:51 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=74.125.82.170 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1791456053; cv=none; b=oGki7NDv5ZWCqMOUwKKL8vWIQ1F0fxQh17e0JFOFQCO4XHOy/8Hgzx6l6N+lQ7bxg8VrPrQ+scq8lk6kPkqa6pTkItfWPMS4XMa72Tn6Y1OX7+/TFo+ofhkEZGnZfI1unCZlDomJwMt9t38GQd60O5ZtNavGG7VDO/BrCaUdxIM= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1791456053; c=relaxed/simple; bh=sAh2gdTD9duOj8WLvoGxiHxj5o2kOrdYeBV4NBuiVSQ=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=Bo3bFv7YX+HJZ+vFF9mlBmZS2ZOu86XwkJviT5OI9pwomEhetJB1F5rvMALdmaE9SFQEAuPUOZ73BLg43UW4u5jM73FFyQaf6qSkgYOKntGVAe1TCkIcbxOfopro3KbjUZN0d2306pLuUWGdXwJvg/9GER52Ju8aH0LJG+OM3w4= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=O5Cfxy5m; arc=none smtp.client-ip=74.125.82.170 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="O5Cfxy5m" Received: by mail-dy1-f170.google.com with SMTP id 5a478bee46e88-35120d43ecaso7720257eec.1 for ; Thu, 08 Oct 2026 03:40:51 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1791456051; x=1792060851; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to:content-type; bh=A3hFCOdGFcpARJPE61Pz7wx4lXLyiEMweFG5G2TuDs0=; b=O5Cfxy5mIDM8VmdPakK61HLiUvgqI+Gp3+lLOxj/cd0sCfTrDvMpdFI6ogQxuIq8XH Vdi3eEgcyRUK+LH4FbR1IdwdpmNtKK5yU6yldJyOFUe1PTHmanBZmOmWOjVUWUonCnNO gQTfYYn2l34y8ZVivQxY6QYgGM6sbAQ9dr4wIhXp6IibsLRzTWkA40LMaEce11NBsaN6 /KZbcr0ioMroT4PD44mIezUxdy9oxMYi8cYWxvDAYsqQIPI/GG0S1WYoN9dh+11FiGoC ltyhheaKCTnp0bXTj8G9st6NLuVZnEYudEpINBFw+NnoEYaSe/eGs1i2CirtozcW1Hll 5Tgw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20260707; t=1791456051; x=1792060851; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to:content-type; bh=A3hFCOdGFcpARJPE61Pz7wx4lXLyiEMweFG5G2TuDs0=; b=uR0wmbL45LvtBH1FXrLTVilY964QXxJSimnSU0YOZWqBY3gO8BwuXF0+VCu77NUNVu 27vYiwSfZ9oDe8FFf3KKj+wwsWPLoh/HTN0wVUp2FBq+bbRuOduE3mToI78Yrumkwp8U 204nEt67wVfFtxSTcZtJ/jMAPsUEcoeY3QrXVr5qGyx24OpEHL/hNYGnyOf7pA3uWpXI Bg+3/RgEiuYcsWr/tr/2LiGdtlYYaN8G2DNrCP7rmrXmZB8iPpPvslyXwi1VWpC4gLGv dNxkQT41V0puYgBZNpo8rPtar+Yv+KP9XmK+kmOE3DZtLAzAQ4iqT19gSJSumFiMAlUh Kzfw== X-Forwarded-Encrypted: i=1; AKwUvBz0podOPOIL8bhMVgWpm6coyR/dyBa6G07BRGKjKd4/WtyVcIiI5jhFcCAFj3BeB18AemkivCY7Tvs/7BcxvtCpQw==@vger.kernel.org X-Gm-Message-State: AFuF++mDIVZjg+6I2pICq7zul+0+/u8qWOtVG/BpTFmAPVqxgPqcPYQC DhCDVxZcsJ30sKqjN+qjkVvs3ToLSN2NAf1EuwF3tYnybav+lTcnJAt5 X-Gm-Gg: AYBFou3YxJn1qbnTQJlSW6gOU0ImD59JYIJZbsG4LHauAfRxWQe7d7X/1wqc2lt+6vv m+q+/BYbZz/ItcjEhF9PV6g0MYaQkyyn/Oa83KitO59EPZ1zjXwi+mOJKwvUkEmwsAL6jAV38Z5 1I2AsDSqQ4SPQkd7Lv+aLKTi9q2dGz0zTco5z4Fn920iNA5MTh5kV+rr8BqOFDJHCHx88aixVdv z0owY8oojs98/eFH+uExEq7JUu4X26zy7b7K/haAu6V6TOAAKbqUxLn+utMsL8xn6OrYdJNpi4t mGB/4cn1hJaBYAB4vemWDGTtEKnMzwEzNi+EZNW6EVGnHlFjKHfgHPSQ9nIREFC9FyektgeXgde ISEHWTrxco7Wtd3cEs2+lCtUZKF/atkicyZNBevkXl9U3MW6WAYfMaQFTGsifRdsqecKve+bW+c 8vFsr8IeXuxXlrDJdMvX81xuEAa2A9cBIMdXnrJZFrI54CwlXRNAXWV548FemAcjGMdAvCWpoxk 3mCOXDUDkYcawYsnCdvwGaqqVmqaPDmWz2phWe2RxD8qI7MU325zRRh1wQZTqJsCFfjyNVQ/DiG BobpdCyJcFgj/75o8oKANIKS X-Received: by 2002:a05:693c:41d2:10b0:351:62fe:62 with SMTP id 5a478bee46e88-35162fe0200mr5293677eec.19.1791456050997; Thu, 08 Oct 2026 03:40:50 -0700 (PDT) Received: from phuc-desktop.. ([183.91.15.56]) by smtp.gmail.com with ESMTPSA id 5a478bee46e88-3517810b895sm7496369eec.17.2026.10.08.03.40.37 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 08 Oct 2026 03:40:49 -0700 (PDT) From: phucduc.bui@gmail.com To: Vijendar Mukunda , Venkata Prasad Potturu , Liam Girdwood , Mark Brown , Jaroslav Kysela , Takashi Iwai , povik+lin@cutebit.org, Claudiu Beznea , Andrei Simion , Nicolas Ferre , Alexandre Belloni , David Rhodes , Richard Fitzgerald , Shengjiu Wang , Xiubo Li , Fabio Estevam , Nicolin Chen , Frank Li , Sascha Hauer , Pengutronix Kernel Team , Cezary Rojewski , Peter Ujfalusi , Bard Liao , Kai Vehmanen , Pierre-Louis Bossart , Kuninori Morimoto , Geert Uytterhoeven , Magnus Damm , Biju Das , Lad Prabhakar , Heiko Stuebner Cc: Kees Cook , Syed Saba Kareem , wangdicheng , Chris Bainbridge , Linus Walleij , Charles Keepax , Neo Chang , Krzysztof Kozlowski , u.kleine-koenig@baylibre.com, Pengpeng Hou , Cristian Ciocaltea , Hemanth Selam , Md Shofiqul Islam , Bjorn Helgaas , Zain Aboobacker , Sang-Heon Jeon , Ajit Kumar Pandey , Ravulapati Vishnu vardhan rao , Bo Shen , Vinod Koul , linux-sound@vger.kernel.org, asahi@lists.linux.dev, linux-arm-kernel@lists.infradead.org, patches@opensource.cirrus.com, linuxppc-dev@lists.ozlabs.org, imx@lists.linux.dev, linux-rockchip@lists.infradead.org, linux-renesas-soc@vger.kernel.org, linux-kernel@vger.kernel.org, bui duc phuc Subject: [PATCH 07/24] ASoC: amd: yc: Fix acp6x_pdm_dma_close() being skipped on rollback Date: Thu, 8 Oct 2026 17:38:14 +0700 Message-ID: <20261008103831.542533-8-phucduc.bui@gmail.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20261008103831.542533-1-phucduc.bui@gmail.com> References: <20261008103831.542533-1-phucduc.bui@gmail.com> Precedence: bulk X-Mailing-List: linux-renesas-soc@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit From: bui duc phuc snd_pcm_hw_constraint_integer() may return 1, which is then returned from acp6x_pdm_dma_open(). ASoC only marks the component as opened when .open() returns 0, so .close() can be skipped on rollback. Return 0 explicitly on success. Fixes: ceb4fcc13ae5 ("ASoC: amd: add acp6x pdm driver dma ops") Signed-off-by: bui duc phuc --- sound/soc/amd/yc/acp6x-pdm-dma.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/sound/soc/amd/yc/acp6x-pdm-dma.c b/sound/soc/amd/yc/acp6x-pdm-dma.c index 40c4d833f4ed..afa9f66533e3 100644 --- a/sound/soc/amd/yc/acp6x-pdm-dma.c +++ b/sound/soc/amd/yc/acp6x-pdm-dma.c @@ -209,7 +209,7 @@ static int acp6x_pdm_dma_open(struct snd_soc_component *component, pdm_data->acp6x_base = adata->acp6x_base; runtime->private_data = pdm_data; - return ret; + return 0; } static int acp6x_pdm_dma_hw_params(struct snd_soc_component *component, -- 2.43.0