Re: [PATCH v8 11/15] s390: Distinguish hardware and software PTEs

[kernel test robot <lkp@intel.com>]

Hi Alexander,

kernel test robot noticed the following build errors:

[auto build test ERROR on linus/master]
[also build test ERROR on v7.3-rc6]
[cannot apply to akpm-mm/mm-everything s390/features kvms390/next next-20261006]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch#_base_tree_information]

url:    https://github.com/intel-lab-lkp/linux/commits/Alexander-Gordeev/mm-introduce-hw_pte_t-for-PTE-table-storage/20261007-134144
base:   linus/master
patch link:    https://lore.kernel.org/r/c22ed0a2d9ff0f4fff69a17332a377c460d993dc.1791365932.git.agordeev%40linux.ibm.com
patch subject: [PATCH v8 11/15] s390: Distinguish hardware and software PTEs
config: s390-allmodconfig (https://download.01.org/0day-ci/archive/20261008/202610081806.wcWlNqQf-lkp@intel.com/config)
compiler: clang version 24.0.0git (https://github.com/llvm/llvm-project 80cd965b6323b208519f8ab1d5ee86e4ea9862f4)
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20261008/202610081806.wcWlNqQf-lkp@intel.com/reproduce)

If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@intel.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202610081806.wcWlNqQf-lkp@intel.com/

All errors (new ones prefixed by >>):

>> mm/damon/vaddr.c:303:45: error: incompatible pointer types passing 'pte_t *' to parameter of type 'hw_pte_t *' (aka 'struct __hw_pte_t *') [-Wincompatible-pointer-types]
     303 |         *entry = huge_ptep_get_and_clear(mm, addr, pte, psize);
         |                                                    ^~~
   arch/s390/include/asm/hugetlb.h:34:40: note: passing argument to parameter 'ptep' here
      34 |                                             unsigned long addr, hw_pte_t *ptep,
         |                                                                           ^
   mm/damon/vaddr.c:305:28: error: incompatible pointer types passing 'pte_t *' to parameter of type 'hw_pte_t *' (aka 'struct __hw_pte_t *') [-Wincompatible-pointer-types]
     305 |         set_huge_pte_at(mm, addr, pte, *entry, psize);
         |                                   ^~~
   arch/s390/include/asm/hugetlb.h:22:18: note: passing argument to parameter 'ptep' here
      22 |                      hw_pte_t *ptep, pte_t pte, unsigned long sz);
         |                                ^
>> mm/damon/vaddr.c:318:40: error: incompatible pointer types passing 'hw_pte_t *' (aka 'struct __hw_pte_t *') to parameter of type 'pte_t *' [-Wincompatible-pointer-types]
     318 |         referenced = damon_hugetlb_ptep_mkold(pte, mm, vma, addr, &entry);
         |                                               ^~~
   mm/damon/vaddr.c:296:45: note: passing argument to parameter 'pte' here
     296 | static bool damon_hugetlb_ptep_mkold(pte_t *pte, struct mm_struct *mm,
         |                                             ^
   3 errors generated.


vim +303 mm/damon/vaddr.c

3f49584b262cf8 SeongJae Park        2021-09-07  294  
49f4203aae06ba Baolin Wang          2022-01-14  295  #ifdef CONFIG_HUGETLB_PAGE
39c0ceedd54557 SJ Park              2026-09-07  296  static bool damon_hugetlb_ptep_mkold(pte_t *pte, struct mm_struct *mm,
39c0ceedd54557 SJ Park              2026-09-07  297  		struct vm_area_struct *vma, unsigned long addr, pte_t *entry)
39c0ceedd54557 SJ Park              2026-09-07  298  {
39c0ceedd54557 SJ Park              2026-09-07  299  	unsigned long psize = huge_page_size(hstate_vma(vma));
39c0ceedd54557 SJ Park              2026-09-07  300  
39c0ceedd54557 SJ Park              2026-09-07  301  	if (!pte_young(*entry))
39c0ceedd54557 SJ Park              2026-09-07  302  		return false;
39c0ceedd54557 SJ Park              2026-09-07 @303  	*entry = huge_ptep_get_and_clear(mm, addr, pte, psize);
39c0ceedd54557 SJ Park              2026-09-07  304  	*entry = pte_mkold(*entry);
39c0ceedd54557 SJ Park              2026-09-07  305  	set_huge_pte_at(mm, addr, pte, *entry, psize);
39c0ceedd54557 SJ Park              2026-09-07  306  	return true;
39c0ceedd54557 SJ Park              2026-09-07  307  }
39c0ceedd54557 SJ Park              2026-09-07  308  
6ecdfd6e16f5f4 Muhammad Usama Anjum 2026-10-07  309  static void damon_hugetlb_mkold(hw_pte_t *pte, struct mm_struct *mm,
49f4203aae06ba Baolin Wang          2022-01-14  310  				struct vm_area_struct *vma, unsigned long addr)
49f4203aae06ba Baolin Wang          2022-01-14  311  {
49f4203aae06ba Baolin Wang          2022-01-14  312  	bool referenced = false;
e6c0c03245b14d Christophe Leroy     2024-07-02  313  	pte_t entry = huge_ptep_get(mm, addr, pte);
6b7cea90c82e10 Kefeng Wang          2022-12-30  314  	struct folio *folio = pfn_folio(pte_pfn(entry));
49f4203aae06ba Baolin Wang          2022-01-14  315  
6b7cea90c82e10 Kefeng Wang          2022-12-30  316  	folio_get(folio);
49f4203aae06ba Baolin Wang          2022-01-14  317  
39c0ceedd54557 SJ Park              2026-09-07 @318  	referenced = damon_hugetlb_ptep_mkold(pte, mm, vma, addr, &entry);
49f4203aae06ba Baolin Wang          2022-01-14  319  	if (mmu_notifier_clear_young(mm, addr,
49f4203aae06ba Baolin Wang          2022-01-14  320  				     addr + huge_page_size(hstate_vma(vma))))
49f4203aae06ba Baolin Wang          2022-01-14  321  		referenced = true;
49f4203aae06ba Baolin Wang          2022-01-14  322  
49f4203aae06ba Baolin Wang          2022-01-14  323  	if (referenced)
6b7cea90c82e10 Kefeng Wang          2022-12-30  324  		folio_set_young(folio);
49f4203aae06ba Baolin Wang          2022-01-14  325  
6b7cea90c82e10 Kefeng Wang          2022-12-30  326  	folio_set_idle(folio);
6b7cea90c82e10 Kefeng Wang          2022-12-30  327  	folio_put(folio);
49f4203aae06ba Baolin Wang          2022-01-14  328  }
49f4203aae06ba Baolin Wang          2022-01-14  329  

--
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki