All of lore.kernel.org
 help / color / mirror / Atom feed
From: Darrell Gum <d@rrell.co>
To: "Francisco Beltrán Millalén" <fbeltranmillalen@gmail.com>
Cc: Bjorn Helgaas <bhelgaas@google.com>,
	linux-pci@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] PCI: Extend Apple Thunderbolt power quirk to Alpine Ridge
Date: Thu,  8 Oct 2026 11:55:42 -0700	[thread overview]
Message-ID: <20261008185543.85892-1-d@rrell.co> (raw)
In-Reply-To: <20260924132815.24430-1-fbeltranmillalen@gmail.com>

On Thu, 24 Sep 2026 10:28:15 -0300, Francisco Beltrán Millalén wrote:
> On Macs with an Alpine Ridge Thunderbolt 3 controller, suspending to RAM
[...]

Tested on a second MacBookPro14,3 on 7.2.5 (Omarchy's linux-omarchy
7.2.5-3). It has two Alpine Ridge 4C controllers, with upstream
bridges 8086:1578 at 04:00.0 and 7a:00.0. Your PCI/PM v2 series (with
e18d1abc3bff) and the Apple native PME patch were applied as well.
The full report is in reply to the series:
https://lore.kernel.org/all/20260930141914.6678-1-fbeltranmillalen@gmail.com/

For this patch:

- The quirk fired on both upstream bridges ("quirk: cutting power to
  Thunderbolt controller...").
- pm_test=platform passes. The stock kernel hard-hung there 3 out of
  3 times, with or without brcmfmac loaded.
- Real S3 resumed on every attempt, about half a dozen cycles
  including lid closes on battery. noirq resume is about 16 s, with
  about 11 s of it in each upstream bridge.
- With a USB 3 stick attached on the 7a:00.0 side (xHCI 7d:00.0),
  the quirk logged for both bridges during a lid-close S3. The stick
  was still there after resume: no disconnect logged, still at
  5000 Mbps, filesystem readable. A replug about 2 min later
  re-enumerated it at SuperSpeed.
- On that cycle the empty side's xHCI logged "xhci_hcd 0000:07:00.0:
  xHC error in resume, USBSTS 0x401, Reinit" and recovered.

The patches were tested together, not bisected. Only one S3 cycle
had a device attached (a USB stick, no real Thunderbolt device). The
no-wake-on-plug trade-off is untested here.

Tested-by: Darrell Gum <d@rrell.co>

  parent reply	other threads:[~2026-10-08 18:55 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-09-24 13:28 [PATCH] PCI: Extend Apple Thunderbolt power quirk to Alpine Ridge Francisco Beltrán Millalén
2026-09-24 13:34 ` sashiko-bot
2026-10-08 18:55 ` Darrell Gum [this message]
2026-10-09  2:51   ` Francisco Beltrán Millalén
2026-10-08 23:17 ` Bjorn Helgaas
2026-10-09  2:50   ` Francisco Beltrán Millalén

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20261008185543.85892-1-d@rrell.co \
    --to=d@rrell.co \
    --cc=bhelgaas@google.com \
    --cc=fbeltranmillalen@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-pci@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.