Re: [RFC: DMA_PMD 09/22] iommu/dma: Add DMA_PMD arena allocator

[kernel test robot <lkp@intel.com>]

Hi Luigi,

[This is a private test report for your RFC patch.]
kernel test robot noticed the following build warnings:

[auto build test WARNING on akpm-mm/mm-everything]
[also build test WARNING on tnguy-next-queue/dev-queue tnguy-net-queue/dev-queue linus/master v7.3-rc6 next-20261006]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch#_base_tree_information]

url:    https://github.com/intel-lab-lkp/linux/commits/Luigi-Rizzo/iommu-dma-introduce-CONFIG_DMA_PMD-and-metadata-table/20261003-212220
base:   https://git.kernel.org/pub/scm/linux/kernel/git/akpm/mm.git mm-everything
patch link:    https://lore.kernel.org/r/20261003212241.3432303-10-lrizzo%40google.com
patch subject: [RFC: DMA_PMD 09/22] iommu/dma: Add DMA_PMD arena allocator
config: x86_64-randconfig-1007-20261008 (https://download.01.org/0day-ci/archive/20261008/202610081920.PAsvlocm-lkp@intel.com/config)
compiler: gcc-14 (Debian 14.2.0-19) 14.2.0
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20261008/202610081920.PAsvlocm-lkp@intel.com/reproduce)

If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@intel.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202610081920.PAsvlocm-lkp@intel.com/

All warnings (new ones prefixed by >>):

   drivers/iommu/dma-pmd-kunit.c: In function 'test_arena_alloc_and_free':
   drivers/iommu/dma-pmd-kunit.c:171:32: error: 'struct device' has no member named 'numa_node'
     171 |         struct device dev = { .numa_node = NUMA_NO_NODE };
         |                                ^~~~~~~~~
   In file included from include/linux/nodemask.h:93,
                    from include/linux/numa.h:6,
                    from include/linux/cpumask.h:15,
                    from arch/x86/include/asm/paravirt.h:19,
                    from arch/x86/include/asm/irqflags.h:100,
                    from include/linux/irqflags.h:18,
                    from include/linux/spinlock.h:59,
                    from include/linux/kref.h:16,
                    from include/kunit/test.h:22,
                    from drivers/iommu/dma-pmd-kunit.c:5:
   include/linux/nodemask_types.h:15:25: error: initialization of 'const char *' from 'int' makes pointer from integer without a cast [-Wint-conversion]
      15 | #define NUMA_NO_NODE    (-1)
         |                         ^
   drivers/iommu/dma-pmd-kunit.c:171:44: note: in expansion of macro 'NUMA_NO_NODE'
     171 |         struct device dev = { .numa_node = NUMA_NO_NODE };
         |                                            ^~~~~~~~~~~~
   include/linux/nodemask_types.h:15:25: note: (near initialization for 'dev.kobj.name')
      15 | #define NUMA_NO_NODE    (-1)
         |                         ^
   drivers/iommu/dma-pmd-kunit.c:171:44: note: in expansion of macro 'NUMA_NO_NODE'
     171 |         struct device dev = { .numa_node = NUMA_NO_NODE };
         |                                            ^~~~~~~~~~~~
>> drivers/iommu/dma-pmd-kunit.c:171:29: warning: missing braces around initializer [-Wmissing-braces]
     171 |         struct device dev = { .numa_node = NUMA_NO_NODE };
         |                             ^


vim +171 drivers/iommu/dma-pmd-kunit.c

   168	
   169	static void test_arena_alloc_and_free(struct kunit *test)
   170	{
 > 171		struct device dev = { .numa_node = NUMA_NO_NODE };
   172		void *v1, *v2, *v3, *vl1;
   173		dma_addr_t d1, d2, d3, dl1;
   174	
   175		KUNIT_EXPECT_NULL(test,
   176				  dma_pmd_arena_alloc(NULL, SZ_4K, &d1, NUMA_NO_NODE));
   177	
   178		v1 = dma_pmd_arena_alloc(&dev, SZ_64K, &d1, NUMA_NO_NODE);
   179		KUNIT_ASSERT_NOT_NULL(test, v1);
   180		v2 = dma_pmd_arena_alloc(&dev, SZ_64K, &d2, NUMA_NO_NODE);
   181		KUNIT_ASSERT_NOT_NULL(test, v2);
   182		KUNIT_EXPECT_PTR_EQ(test, v2, v1 + SZ_64K);
   183		KUNIT_EXPECT_EQ(test, d2, d1 + SZ_64K);
   184	
   185		/* Freeing v1 unreserves [0, 64K); next 64K alloc reuses it. */
   186		KUNIT_EXPECT_TRUE(test, dma_pmd_arena_free(&dev, SZ_64K, v1, d1));
   187		v3 = dma_pmd_arena_alloc(&dev, SZ_64K, &d3, NUMA_NO_NODE);
   188		KUNIT_EXPECT_PTR_EQ(test, v3, v1);
   189		KUNIT_EXPECT_EQ(test, d3, d1);
   190	
   191		/*
   192		 * Allocate 3MB (spans 2 contiguous fully_empty slots in ARENA_REGION);
   193		 * the trailing 1MB in the second slot is marked partial_empty and can
   194		 * satisfy a <= 1MB allocation before both are freed.
   195		 */
   196		vl1 = dma_pmd_arena_alloc(&dev, SZ_2M + SZ_1M, &dl1, NUMA_NO_NODE);
   197		KUNIT_ASSERT_NOT_NULL(test, vl1);
   198		KUNIT_EXPECT_TRUE(test, dma_pmd_arena_free(&dev, SZ_2M + SZ_1M, vl1, dl1));
   199		KUNIT_EXPECT_TRUE(test, dma_pmd_arena_free(&dev, SZ_64K, v2, d2));
   200		KUNIT_EXPECT_TRUE(test, dma_pmd_arena_free(&dev, SZ_64K, v3, d3));
   201	}
   202	

--
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki