From: Sebastian Andrzej Siewior <bigeasy@linutronix.de>
To: Petr Mladek <pmladek@suse.com>
Cc: John Ogness <john.ogness@linutronix.de>,
Sergey Senozhatsky <senozhatsky@chromium.org>,
Steven Rostedt <rostedt@goodmis.org>,
Pavel Tikhomirov <ptikhomirov@virtuozzo.com>,
Oleg Nesterov <oleg@redhat.com>,
Christian Brauner <brauner@kernel.org>,
oe-lkp@lists.linux.dev, lkp@intel.com,
linux-serial@vger.kernel.org, oliver.sang@intel.com,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] nbcon/reboot: Flush nbcon consoles synchronously on reboot
Date: Fri, 9 Oct 2026 08:51:52 +0200 [thread overview]
Message-ID: <20261009065152.udyfFRHx@linutronix.de> (raw)
In-Reply-To: <20261008150852.8286-1-pmladek@suse.com>
On 2026-10-08 17:08:52 [+0200], Petr Mladek wrote:
> NBCON consoles emit messages in a dedicated kthreads when the system
> is working properly. printk() tries to flush them synchronously in
> explicitly marked emergency context and in panic().
>
> Another situation where printk() could not rely on kthreads are the various
> reboot and halt code paths. They can be detected by the `system_state`
> variable.
>
> Let's default to NBCON_PRIO_EMERGENCY for the post-running states.
> printk() will automatically try flushing the consoles synchronously.
> Also do not rely on printk() and explicitly flush the consoles
> after these states are set.
while this seems okay, didn't we have pr_flush() to flush the output on
shutdown/ reboot?
> Note that suspend code paths have already been handled, see
> console_suspend_all() and console_suspend().
>
> Reported-by: kernel test robot <lkp@intel.com>
> Closes: https://lore.kernel.org/all/202608061008.48a1e76e-lkp@intel.com/
> Suggested-by: John Ogness <john.ogness@linutronix.de>
> Signed-off-by: Petr Mladek <pmladek@suse.com>
Sebastian
next prev parent reply other threads:[~2026-10-09 6:51 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-10-08 15:08 [PATCH] nbcon/reboot: Flush nbcon consoles synchronously on reboot Petr Mladek
2026-10-08 15:16 ` sashiko-bot
2026-10-08 15:19 ` Bradley Morgan
2026-10-09 9:16 ` Petr Mladek
2026-10-09 10:52 ` Sebastian Andrzej Siewior
2026-10-09 6:51 ` Sebastian Andrzej Siewior [this message]
2026-10-09 9:08 ` Petr Mladek
2026-10-09 12:59 ` Sebastian Andrzej Siewior
2026-10-09 13:28 ` John Ogness
2026-10-09 15:27 ` Petr Mladek
2026-10-12 13:26 ` John Ogness
2026-10-12 14:14 ` John Ogness
2026-10-12 13:20 ` John Ogness
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20261009065152.udyfFRHx@linutronix.de \
--to=bigeasy@linutronix.de \
--cc=brauner@kernel.org \
--cc=john.ogness@linutronix.de \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-serial@vger.kernel.org \
--cc=lkp@intel.com \
--cc=oe-lkp@lists.linux.dev \
--cc=oleg@redhat.com \
--cc=oliver.sang@intel.com \
--cc=pmladek@suse.com \
--cc=ptikhomirov@virtuozzo.com \
--cc=rostedt@goodmis.org \
--cc=senozhatsky@chromium.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.