From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-alma10-1.taild15c8.ts.net [100.103.45.18]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 975B23431F8; Fri, 9 Oct 2026 14:36:21 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=100.103.45.18 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1791556582; cv=none; b=UxeMcUSbP6CSFQxSsGA/052MoSD7hTjAFjlq1etV/KITsnGYhZ+42VOKoK5UxqX2vD2RcooSjeKI0qD2CIIYBUSWZur6rqgfqm41bSFNdeJTl+sncAoh3nLJlFDejQq86j9W2/jzenRM2p+iln85uPIzXytw+4WPnLDmcgJ0ZZ4= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1791556582; c=relaxed/simple; bh=ibr9yWmej47yrAG4ItEaRY8OSeNn2feqNSmRd1WdEp8=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=tpgdKegzxCx0rhueCPTWFIoGjw4BwoT/eXAWC0wOSvQFWFbVHIK7882/1DBc6s0hEpNW8AnkxqD6zyvZrT4la5cTyjZfhhgmuzvsj4YOpEUTy1pZg00n9CZYrty9xtYwF8AFJ0ghFwfcxX/jaXZZEPjFbGKfnh1YsjsAolFWDGQ= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b=SQAkCkye; arc=none smtp.client-ip=100.103.45.18 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b="SQAkCkye" Received: by smtp.kernel.org (Postfix) with ESMTPSA id EC31D1F000FF; Fri, 9 Oct 2026 14:36:20 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linuxfoundation.org; s=korg; t=1791556581; bh=rJkFqVeDQi739NTIkDr/tA/QMN7tuPwrtHasELv890A=; h=From:To:Cc:Subject:Date:In-Reply-To:References; b=SQAkCkyeMJczd1KGLiC9W/TzJV0t7o0D85NgiDYY1EVWhcnZid3MzQbYTqVJc5lTY 42Z76Fg5yltcZ7OWiWMr25H98zJ08uUHc4V5nc23k49wdc6Urc7dy9k7BnWz4Xd8eA 923HDBbGrTYUDmJ7kDmTPdIYbv/bBcytng9eUtQY= From: Greg Kroah-Hartman To: stable@vger.kernel.org Cc: Greg Kroah-Hartman , patches@lists.linux.dev, stable@kernel.org, Viken Dadhaniya , Konrad Dybcio Subject: [PATCH 7.2 204/428] soc: qcom: geni-se: Correct QUP Core ICC vote constants Date: Fri, 9 Oct 2026 16:09:01 +0200 Message-ID: <20261009140950.611372510@linuxfoundation.org> X-Mailer: git-send-email 2.56.0 In-Reply-To: <20261009140946.008206689@linuxfoundation.org> References: <20261009140946.008206689@linuxfoundation.org> User-Agent: quilt/0.69 X-stable: review X-Patchwork-Hint: ignore Precedence: bulk X-Mailing-List: patches@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit 7.2-stable review patch. If anyone has any objections, please let me know. ------------------ From: Viken Dadhaniya commit 1cd9b1be5a9c56fd69e3f555b200a1844f9b873e upstream. The GENI_TO_CORE ("qup-core") ICC vote selects the QUP Core 2X clock rate. The CORE_2X_*_MHZ constants are expressed in Bps, but their values are several orders of magnitude too small. For example, the 50 MHz threshold is represented by 2500 rather than 25000000 Bps. As a result, clients using these constants can severely under-vote the QUP Core clock. Correct the constants to their intended Bps thresholds so that the ICC provider selects the corresponding QUP Core 2X clock rate. Drop the unused definitions. Fixes: 58ffbba6a399 ("soc: qcom: geni: Support for ICC voting") Cc: stable@kernel.org Signed-off-by: Viken Dadhaniya Reviewed-by: Konrad Dybcio Link: https://patch.msgid.link/20260915-correct-icc-bandwidth-vote-constants-v2-1-f78eb611204e@oss.qualcomm.com Signed-off-by: Greg Kroah-Hartman --- include/linux/soc/qcom/geni-se.h | 15 +++++---------- 1 file changed, 5 insertions(+), 10 deletions(-) --- a/include/linux/soc/qcom/geni-se.h +++ b/include/linux/soc/qcom/geni-se.h @@ -309,17 +309,12 @@ struct geni_se { #define QUP_SE_VERSION_2_5 0x20050000 /* - * Define bandwidth thresholds that cause the underlying Core 2X interconnect - * clock to run at the named frequency. These baseline values are recommended - * by the hardware team, and are not dynamically scaled with GENI bandwidth - * beyond basic on/off. + * QUP Core 2X clock votes used by GENI clients through the "qup-core" ICC + * path. Values are in Bps and must be converted with Bps_to_icc() before + * setting avg_bw. */ -#define CORE_2X_19_2_MHZ 960 -#define CORE_2X_50_MHZ 2500 -#define CORE_2X_100_MHZ 5000 -#define CORE_2X_150_MHZ 7500 -#define CORE_2X_200_MHZ 10000 -#define CORE_2X_236_MHZ 16383 +#define CORE_2X_19_2_MHZ 9600000 +#define CORE_2X_50_MHZ 25000000 #define GENI_DEFAULT_BW Bps_to_icc(1000)