From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-alma10-1.taild15c8.ts.net [100.103.45.18]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id C2A674E3EF6; Fri, 9 Oct 2026 14:20:03 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=100.103.45.18 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1791555611; cv=none; b=UdRvWVqAvTC18Ffvj8qUPZ67qjZm2w4KJjkFk8zsoMbTeQEDt/suSF9VAt1LFV8b4Dk/vyjf3jSZ/H8uR57a2OsNrkrpusi+Fdm2wEjMYAdbmjezqOBzzkqWy25wz6G/qmVB71NRH6tnB6sze8dxazhV8sdvUR0JMt+P5ZDmkLI= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1791555611; c=relaxed/simple; bh=SlujE9HNPsudBHQASUSXlp3YOb2Uqr6SRopUnGJsy/M=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=Jj82s9rWIKfMd0oJda28siIHbOwEJAI1WnmUAuga/wlSSJA+CsZcO/Y1XAsMi5P9QEhb6EyLTp7ZSTBO3H4VwzljDGZk2ceUbQ6kCpy0xJmZLc3TTfr12GJLVi/oO/EUXgeTYBceZWKUwUCB08nQ4Q+a5uLpJ0UxAf2PlesdUl8= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b=jqq8cC7K; arc=none smtp.client-ip=100.103.45.18 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b="jqq8cC7K" Received: by smtp.kernel.org (Postfix) with ESMTPSA id A34F01F00899; Fri, 9 Oct 2026 14:20:02 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linuxfoundation.org; s=korg; t=1791555603; bh=q6ZJv1xYTb64xJpzRx49pzyqmYzJ7ZqgEsolRoBC/VY=; h=From:To:Cc:Subject:Date:In-Reply-To:References; b=jqq8cC7KKld+saQp/8qUcgIVrt0tW8XTa9M6e+C5Q1p60zhRRj6vxfHgmETtNG0PO CUUj0kiVFBBXREYcSW9n4LiLyII8KApP4RGup5Sy71B4ta5UvPL2AVaADN87JubUnR oNfoBZEchA1gKRV/grnBzEgLDrMshrKGz8KvIRmI= From: Greg Kroah-Hartman To: stable@vger.kernel.org Cc: Greg Kroah-Hartman , patches@lists.linux.dev, Sai Teja Aluvala , Luiz Augusto von Dentz , Sasha Levin Subject: [PATCH 6.18 086/403] Bluetooth: btintel: validate DDC record lengths Date: Fri, 9 Oct 2026 16:07:27 +0200 Message-ID: <20261009140954.105388034@linuxfoundation.org> X-Mailer: git-send-email 2.56.0 In-Reply-To: <20261009140952.119038291@linuxfoundation.org> References: <20261009140952.119038291@linuxfoundation.org> User-Agent: quilt/0.69 X-stable: review X-Patchwork-Hint: ignore Precedence: bulk X-Mailing-List: patches@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit 6.18-stable review patch. If anyone has any objections, please let me know. ------------------ From: Sai Teja Aluvala [ Upstream commit c9c15d4d8956df8c564f7c210e4dc5b9b820d97a ] Parse DDC record lengths in unsigned storage so 0xFF does not wrap. Reject records smaller than the mandatory three-byte header, records exceeding U8_MAX, and records exceeding remaining firmware bytes before issuing Intel_Write_DDC. This issue was reported by Claude Mythos. Fixes: 145f2368c5fd ("Bluetooth: btintel: Add Device Configuration support") Signed-off-by: Sai Teja Aluvala Signed-off-by: Luiz Augusto von Dentz Signed-off-by: Sasha Levin --- drivers/bluetooth/btintel.c | 12 ++++++++++-- 1 file changed, 10 insertions(+), 2 deletions(-) diff --git a/drivers/bluetooth/btintel.c b/drivers/bluetooth/btintel.c index 0e5c2d3893717..3b516ef5848dc 100644 --- a/drivers/bluetooth/btintel.c +++ b/drivers/bluetooth/btintel.c @@ -393,8 +393,16 @@ int btintel_load_ddc_config(struct hci_dev *hdev, const char *ddc_name) /* DDC file contains one or more DDC structure which has * Length (1 byte), DDC ID (2 bytes), and DDC value (Length - 2). */ - while (fw->size > fw_ptr - fw->data) { - u8 cmd_plen = fw_ptr[0] + sizeof(u8); + while (fw->size > (size_t)(fw_ptr - fw->data)) { + size_t remaining = fw->size - (fw_ptr - fw->data); + unsigned int cmd_plen = fw_ptr[0] + 1U; + + if (cmd_plen < 3 || cmd_plen > U8_MAX || cmd_plen > remaining) { + bt_dev_err(hdev, "Malformed DDC record (plen=%u, remaining=%zu)", + cmd_plen, remaining); + release_firmware(fw); + return -EINVAL; + } skb = __hci_cmd_sync(hdev, 0xfc8b, cmd_plen, fw_ptr, HCI_INIT_TIMEOUT); -- 2.53.0