From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-alma10-1.taild15c8.ts.net [100.103.45.18]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 49A82274FDF; Fri, 9 Oct 2026 14:53:01 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=100.103.45.18 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1791557582; cv=none; b=s6PO7IvFHBDewbsvEIGfwCKIootAN2ilChG2AUhyny6Kq0YfNmt0EhuoY/YkA/fTTN8d0MbeMhYO8mvjwZWvvtFfY8L3My0ke7fFzB/bFBySUY6oGF34MnxTl+LlztgeUInEOVUDymjIiZ4SdDyzPoH98sfQU39sLA2/l2txLiw= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1791557582; c=relaxed/simple; bh=S23p0d6YYJgHQrRh2o2TRzfc58rO4Yght36CSfqTR3U=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=OJsUla5kEqjkK6pFFYJoS7T1A1QKi3lYkyNHv8tX6wtU+b4zK2XnYb82x8N7rvPzHInULasBbALLZ+J0QvJ/Ybs2/nisKwNSt2sgrO/wT8TELu9WIoFTRREbJg0pHGUbWVUC90QheRCP3Nf3+hr97loQQuU2vfLtkDiXxBJ4p4E= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b=JkdlGvJq; arc=none smtp.client-ip=100.103.45.18 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b="JkdlGvJq" Received: by smtp.kernel.org (Postfix) with ESMTPSA id A2BD11F000FF; Fri, 9 Oct 2026 14:53:00 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linuxfoundation.org; s=korg; t=1791557581; bh=uMAFoJRyelrQjEN6AYmg4HNrIPfaO+E5+RJQZyqVxw4=; h=From:To:Cc:Subject:Date:In-Reply-To:References; b=JkdlGvJqLHOJ+UYtV5uQVBkDtFXDlvgZzIDn6/c7fDY/ouECxyDbsgSps8i9N4U26 RCfv+d3sOEVlLDtZzrLeU8rrzzCJpp14gHeSDvHZ0KkPz/oFQ4MVmt/0N8VzkHNC79 UtOFl/vJXzBBFJexfW1xH1ODAn2cHxl2ksB5pqdo= From: Greg Kroah-Hartman To: stable@vger.kernel.org Cc: Greg Kroah-Hartman , patches@lists.linux.dev, Cong Nguyen , Jonathan Cameron Subject: [PATCH 7.2 410/428] iio: proximity: pulsedlight: fix iio_device left registered on PM setup failure Date: Fri, 9 Oct 2026 16:12:27 +0200 Message-ID: <20261009140955.231990692@linuxfoundation.org> X-Mailer: git-send-email 2.56.0 In-Reply-To: <20261009140946.008206689@linuxfoundation.org> References: <20261009140946.008206689@linuxfoundation.org> User-Agent: quilt/0.69 X-stable: review X-Patchwork-Hint: ignore Precedence: bulk X-Mailing-List: patches@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit 7.2-stable review patch. If anyone has any objections, please let me know. ------------------ From: Cong Nguyen commit 4daa9ca557b4b98ae1ad38a6d1deaa3e31eb8edf upstream. pm_runtime_set_active() failing in probe() jumps to error_unreg_buffer, which only calls iio_triggered_buffer_cleanup() -- it does not undo the iio_device_register() that already succeeded a few lines above. probe() then returns the error, the devm-managed indio_dev is freed, but the iio core still has it registered: the sysfs/chardev nodes stay live and point at freed memory. Add an error_unreg_dev label that unregisters the iio device before falling through to the existing buffer cleanup, mirroring the teardown order already used in lidar_remove(). Fixes: 4ac4e086fd8c ("iio: pulsedlight-lidar-lite: add runtime PM") Assisted-by: Claude:claude-opus-4 Signed-off-by: Cong Nguyen Cc: stable@vger.kernel.org Signed-off-by: Jonathan Cameron Signed-off-by: Greg Kroah-Hartman --- drivers/iio/proximity/pulsedlight-lidar-lite-v2.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) --- a/drivers/iio/proximity/pulsedlight-lidar-lite-v2.c +++ b/drivers/iio/proximity/pulsedlight-lidar-lite-v2.c @@ -294,12 +294,14 @@ static int lidar_probe(struct i2c_client ret = pm_runtime_set_active(&client->dev); if (ret) - goto error_unreg_buffer; + goto error_unreg_dev; pm_runtime_enable(&client->dev); pm_runtime_idle(&client->dev); return 0; +error_unreg_dev: + iio_device_unregister(indio_dev); error_unreg_buffer: iio_triggered_buffer_cleanup(indio_dev);