All of lore.kernel.org
 help / color / mirror / Atom feed
From: Jason Gunthorpe <jgg@nvidia.com>
To: "Christian König" <christian.koenig@amd.com>
Cc: Diederik de Haas <diederik@cknow-tech.com>,
	Karl Mehltretter <kmehltretter@gmail.com>,
	Sumit Semwal <sumit.semwal@linaro.org>,
	Andrew Morton <akpm@linux-foundation.org>,
	Rob Clark <rob.clark@oss.qualcomm.com>,
	Jianfeng Liu <liujianfeng1994@gmail.com>,
	Andy Shevchenko <andriy.shevchenko@linux.intel.com>,
	Vinod Koul <vkoul@kernel.org>,
	Bjorn Andersson <andersson@kernel.org>,
	linux-media@vger.kernel.org, dri-devel@lists.freedesktop.org,
	linaro-mm-sig@lists.linaro.org, linux-kernel@vger.kernel.org,
	Alistair Popple <apopple@nvidia.com>,
	Leon Romanovsky <leonro@nvidia.com>
Subject: Re: [RFC PATCH 2/3] dma-buf: add a warn-only mode to DMABUF_DEBUG
Date: Fri, 9 Oct 2026 11:24:38 -0300	[thread overview]
Message-ID: <20261009142438.GD13920@nvidia.com> (raw)
In-Reply-To: <50f74418-a1b9-4d93-a9a9-02bb7cbf4544@amd.com>

On Fri, Oct 09, 2026 at 03:21:47PM +0200, Christian König wrote:

> >> [ 1268.968710] CPU: 6 UID: 1000 PID: 29025 Comm: sway Not tainted 7.3-rc6+unreleased-arm64-cknow #1 PREEMPTLAZY  Debian 7.3~rc6-3
> >> [ 1268.968715] Hardware name: FriendlyElec NanoPC-T6 Plus (DT)
> >> [ 1268.968717] Call trace:
> >> [ 1268.968719]  show_stack+0x20/0x38 (C)
> >> [ 1268.968726]  dump_stack_lvl+0x60/0x80
> >> [ 1268.968730]  sg_dmabuf_cpu_access_warn.part.0+0x24/0x30
> >> [ 1268.968734]  sg_dmabuf_cpu_access_warn+0x34/0x38
> >> [ 1268.968739]  iommu_map_sg+0xc8/0x1e0
> >> [ 1268.968745]  rockchip_gem_iommu_map+0x8c/0x128 [rockchipdrm]
> >> [ 1268.968757]  rockchip_gem_prime_import_sg_table+0x58/0x160 [rockchipdrm]
> >> [ 1268.968761]  drm_gem_prime_import_dev+0xa8/0x1d0 [drm]
> >> [ 1268.968776]  drm_gem_prime_fd_to_handle+0x1a4/0x280 [drm]
> > 
> > So.. This is the exact same thing I need for iommufd.
> > 
> > rockchip is managing its own iommu domain and you cannot map to an
> > iommu domain without using a physical address.
> > 
> > Of course it is *completely* illegal to call iommu_map_sgtable() in the
> > importer side of a dmabuf.
> 
> Yeah we are deprecating this for the last ~5 years now. This bubbled
> up because I change to DMA-buf debug code to be enabled by default
> on DEBUG_KERNEL.
> 
> Rob is now working on a solution right now for MSM which should be
> used for rockchip as well.

So is Rob's plan is to remove the iommu_domains, somehow? Lately we've
been NAK'ing alot of the DT hacking that people have been doing in
other devices along those lines, so I wonder what that will look like.

It is probably easier to just fix things so the importer can get
things into an iommu_domain..

Jason

  reply	other threads:[~2026-10-09 14:24 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-10-05  6:41 [RFC PATCH 0/3] dma-buf: warn-only mode for DMABUF_DEBUG Karl Mehltretter
2026-10-05  6:41 ` [RFC PATCH 1/3] dma-buf: keep the DMA flags in the DMABUF_DEBUG copy Karl Mehltretter
2026-10-09 13:29   ` Christian König
2026-10-05  6:41 ` [RFC PATCH 2/3] dma-buf: add a warn-only mode to DMABUF_DEBUG Karl Mehltretter
2026-10-07 12:02   ` Diederik de Haas
2026-10-09 12:53     ` Jason Gunthorpe
2026-10-09 13:21       ` Christian König
2026-10-09 14:24         ` Jason Gunthorpe [this message]
2026-10-09 13:29       ` Diederik de Haas
2026-10-09 13:29         ` Diederik de Haas
2026-10-09 12:42   ` Jason Gunthorpe
2026-10-09 13:18     ` Christian König
2026-10-05  6:41 ` [RFC PATCH 3/3] dma-buf: test the debug scatterlist wrapper Karl Mehltretter
2026-10-12  8:12 ` [RFC PATCH 0/3] dma-buf: warn-only mode for DMABUF_DEBUG Thorsten Leemhuis
2026-10-12 18:51   ` Karl Mehltretter
2026-10-13 11:47     ` Sumit Semwal
2026-10-13 14:16     ` Sumit Semwal

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20261009142438.GD13920@nvidia.com \
    --to=jgg@nvidia.com \
    --cc=akpm@linux-foundation.org \
    --cc=andersson@kernel.org \
    --cc=andriy.shevchenko@linux.intel.com \
    --cc=apopple@nvidia.com \
    --cc=christian.koenig@amd.com \
    --cc=diederik@cknow-tech.com \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=kmehltretter@gmail.com \
    --cc=leonro@nvidia.com \
    --cc=linaro-mm-sig@lists.linaro.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-media@vger.kernel.org \
    --cc=liujianfeng1994@gmail.com \
    --cc=rob.clark@oss.qualcomm.com \
    --cc=sumit.semwal@linaro.org \
    --cc=vkoul@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.