From: Luka Gejak <luka.gejak@linux.dev>
To: Ping-Ke Shih <pkshih@realtek.com>
Cc: linux-wireless@vger.kernel.org, linux-kernel@vger.kernel.org,
Bitterblue Smith <rtl8821cerfe2@gmail.com>,
Luka Gejak <luka.gejak@linux.dev>
Subject: [PATCH rtw-next] wifi: rtw88: 8723b: don't set channel_invalid in query_phy_status()
Date: Fri, 9 Oct 2026 17:58:38 +0200 [thread overview]
Message-ID: <20261009155838.169058-1-luka.gejak@linux.dev> (raw)
rtw8723b_query_phy_status() sets pkt_stat->channel_invalid, which makes
rtw_update_rx_freq_for_invalid() call rtw_update_rx_freq_from_ie() and
overwrite rx_status->freq with rtwdev->hal.current_channel.
rtw_update_channel() keeps the center channel in that field, not the
primary one, so on a 40 MHz connection mac80211 is handed a frequency it
rejects in ieee80211_rx_beacon_freq_valid() and reports beacon loss for
beacons the driver did receive. Only beacons go through that check, so
data traffic is unaffected.
Remove it now, so that the non-SDIO members of the 8723B family do not
report beacon loss once they are supported. SDIO is unaffected, because
rtw_sdio_rx_skb() copies the status into the skb before the update runs.
Reported-by: Bitterblue Smith <rtl8821cerfe2@gmail.com>
Signed-off-by: Luka Gejak <luka.gejak@linux.dev>
---
drivers/net/wireless/realtek/rtw88/rtw8723b.c | 7 -------
1 file changed, 7 deletions(-)
diff --git a/drivers/net/wireless/realtek/rtw88/rtw8723b.c b/drivers/net/wireless/realtek/rtw88/rtw8723b.c
index 8bb9c03d769c..0c37e981ec84 100644
--- a/drivers/net/wireless/realtek/rtw88/rtw8723b.c
+++ b/drivers/net/wireless/realtek/rtw88/rtw8723b.c
@@ -1303,13 +1303,6 @@ static void rtw8723b_query_phy_status_ofdm(struct rtw_dev *rtwdev, void *phy_raw
static void rtw8723b_query_phy_status(struct rtw_dev *rtwdev, u8 *phy_status,
struct rtw_rx_pkt_stat *pkt_stat)
{
- /*
- * The 8723B PHY status does not report the channel, so we must
- * mark it invalid to allow mac80211/rtw88 to parse it from the IE
- * during scanning.
- */
- pkt_stat->channel_invalid = true;
-
if (pkt_stat->rate <= DESC_RATE11M)
rtw8723b_query_phy_status_cck(rtwdev, phy_status, pkt_stat);
else
--
2.55.0
next reply other threads:[~2026-10-09 15:59 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-10-09 15:58 Luka Gejak [this message]
2026-10-12 5:26 ` [PATCH rtw-next] wifi: rtw88: 8723b: don't set channel_invalid in query_phy_status() Ping-Ke Shih
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20261009155838.169058-1-luka.gejak@linux.dev \
--to=luka.gejak@linux.dev \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-wireless@vger.kernel.org \
--cc=pkshih@realtek.com \
--cc=rtl8821cerfe2@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.