From: Sasha Levin <sashal@kernel.org>
To: Dennis Piecha <d.piecha@ymail.com>,
Oleksij Rempel <o.rempel@pengutronix.de>,
"patchwork-bot+netdevbpf@kernel.org"
<patchwork-bot+netdevbpf@kernel.org>
Cc: Sasha Levin <sashal@kernel.org>,
"andrew@lunn.ch" <andrew@lunn.ch>,
"nic_swsd@realtek.com" <nic_swsd@realtek.com>,
"davem@davemloft.net" <davem@davemloft.net>,
"edumazet@kernel.org" <edumazet@kernel.org>,
"kuba@kernel.org" <kuba@kernel.org>,
"pabeni@redhat.com" <pabeni@redhat.com>,
"stable@vger.kernel.org" <stable@vger.kernel.org>,
"kernel@pengutronix.de" <kernel@pengutronix.de>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"netdev@vger.kernel.org" <netdev@vger.kernel.org>,
Heiner Kallweit <hkallweit1@gmail.com>
Subject: Re: [PATCH net v1 1/1] r8169: disable EEE on RTL8168h/8111h
Date: Sat, 10 Oct 2026 02:16:07 -0400 [thread overview]
Message-ID: <20261010021227-rc-0004@kernel.org> (raw)
In-Reply-To: <9777c133-0d46-4efe-88d7-8a519f38b0f8@gmail.com>
On Wed, Oct 07, 2026 at 08:01:06AM +0200, Heiner Kallweit wrote:
> On 06.10.2026 13:19, Dennis Piecha wrote:
>> defaults, no workaround. Before, on 6.18.52 without the patch, it
>> stalled every 7-20 minutes.
>
> I'm pretty sure that EEE was active for this chip version in earlier times.
> Are you sure it's not an issue on the link partner side? Did you test with a
> switch between your system and the FRITZ!Box?
Stable takes this for 6.18 and 7.2 because 202fef9bbbf5 ("net: phy: realtek:
fix EEE advertisement write on the internal PHY MMD path") reached 7.2 and
6.18.46+, and Dennis saw the stall on 6.18.52. EEE was not effectively
advertised on these chips in those trees before that change (the advertisement
write was a no-op), so your recollection holds for older kernels but not for
these trees.
It only affects RTL_GIGA_MAC_VER_46, so the downside if the link partner is at
fault is lost EEE power saving. We will follow any revert or rework upstream.
--
Thanks,
Sasha
prev parent reply other threads:[~2026-10-10 6:16 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-09-25 7:10 [PATCH net v1 1/1] r8169: disable EEE on RTL8168h/8111h Oleksij Rempel
2026-10-01 0:30 ` patchwork-bot+netdevbpf
2026-10-06 11:19 ` Dennis Piecha
2026-10-07 6:01 ` Heiner Kallweit
2026-10-10 6:16 ` Sasha Levin [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20261010021227-rc-0004@kernel.org \
--to=sashal@kernel.org \
--cc=andrew@lunn.ch \
--cc=d.piecha@ymail.com \
--cc=davem@davemloft.net \
--cc=edumazet@kernel.org \
--cc=hkallweit1@gmail.com \
--cc=kernel@pengutronix.de \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=nic_swsd@realtek.com \
--cc=o.rempel@pengutronix.de \
--cc=pabeni@redhat.com \
--cc=patchwork-bot+netdevbpf@kernel.org \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.