From: kernel test robot <lkp@intel.com>
To: oe-kbuild@lists.linux.dev
Cc: lkp@intel.com, Dan Carpenter <error27@gmail.com>
Subject: drivers/tty/amiserial.c:456 rs_startup() warn: missing error code 'retval'
Date: Sat, 10 Oct 2026 07:04:34 +0200 [thread overview]
Message-ID: <202610100610.G565RJsp-lkp@intel.com> (raw)
Unfiltered warning: this smatch report is sent as-is and has not been
reviewed for false positives, so please treat it with due skepticism.
BCC: lkp@intel.com
CC: oe-kbuild-all@lists.linux.dev
CC: linux-kernel@vger.kernel.org
TO: Josh Poimboeuf <jpoimboe@kernel.org>
CC: Peter Zijlstra <peterz@infradead.org>
Hi Josh,
FYI, the error/warning was bisected to this commit, please ignore it if it's irrelevant.
tree: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master
head: 3857c2fe5449541e24afc5efdb0f81a8a8f9a3a0
commit: 845c09e4744f111eae894ad3b67a369bb43d50fb tty: amiserial: Fix namespace collision and startup() section placement with -ffunction-sections
date: 11 months ago
:::::: branch date: 5 hours ago
:::::: commit date: 11 months ago
config: m68k-randconfig-r2201-20261010 (https://download.01.org/0day-ci/archive/20261010/202610100610.G565RJsp-lkp@intel.com/config)
compiler: m68k-linux-gcc (GCC) 8.5.0
smatch: v0.5.0-9187-g5189e3fb
If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Fixes: 845c09e4744f ("tty: amiserial: Fix namespace collision and startup() section placement with -ffunction-sections")
| Reported-by: kernel test robot <lkp@intel.com>
| Reported-by: Dan Carpenter <error27@gmail.com>
| Closes: https://lore.kernel.org/r/202610100610.G565RJsp-lkp@intel.com/
New smatch warnings:
drivers/tty/amiserial.c:456 rs_startup() warn: missing error code 'retval'
Old smatch warnings:
drivers/tty/amiserial.c:343 check_modem_status() error: we previously assumed 'port->tty' could be null (see line 338)
drivers/tty/amiserial.c:687 change_speed() warn: inconsistent indenting
vim +/retval +456 drivers/tty/amiserial.c
^1da177e4c3f415 drivers/char/amiserial.c Linus Torvalds 2005-04-16 425
^1da177e4c3f415 drivers/char/amiserial.c Linus Torvalds 2005-04-16 426 /*
^1da177e4c3f415 drivers/char/amiserial.c Linus Torvalds 2005-04-16 427 * -------------------------------------------------------------------
^1da177e4c3f415 drivers/char/amiserial.c Linus Torvalds 2005-04-16 428 * Here ends the serial interrupt routines.
^1da177e4c3f415 drivers/char/amiserial.c Linus Torvalds 2005-04-16 429 * -------------------------------------------------------------------
^1da177e4c3f415 drivers/char/amiserial.c Linus Torvalds 2005-04-16 430 */
^1da177e4c3f415 drivers/char/amiserial.c Linus Torvalds 2005-04-16 431
^1da177e4c3f415 drivers/char/amiserial.c Linus Torvalds 2005-04-16 432 /*
^1da177e4c3f415 drivers/char/amiserial.c Linus Torvalds 2005-04-16 433 * ---------------------------------------------------------------
^1da177e4c3f415 drivers/char/amiserial.c Linus Torvalds 2005-04-16 434 * Low level utility subroutines for the serial driver: routines to
^1da177e4c3f415 drivers/char/amiserial.c Linus Torvalds 2005-04-16 435 * figure out the appropriate timeout for an interrupt chain, routines
^1da177e4c3f415 drivers/char/amiserial.c Linus Torvalds 2005-04-16 436 * to initialize and startup a serial port, and routines to shutdown a
^1da177e4c3f415 drivers/char/amiserial.c Linus Torvalds 2005-04-16 437 * serial port. Useful stuff like that.
^1da177e4c3f415 drivers/char/amiserial.c Linus Torvalds 2005-04-16 438 * ---------------------------------------------------------------
^1da177e4c3f415 drivers/char/amiserial.c Linus Torvalds 2005-04-16 439 */
^1da177e4c3f415 drivers/char/amiserial.c Linus Torvalds 2005-04-16 440
845c09e4744f111 drivers/tty/amiserial.c Josh Poimboeuf 2025-11-20 441 static int rs_startup(struct tty_struct *tty, struct serial_state *info)
^1da177e4c3f415 drivers/char/amiserial.c Linus Torvalds 2005-04-16 442 {
01bd730d92bd002 drivers/tty/amiserial.c Jiri Slaby 2012-03-05 443 struct tty_port *port = &info->tport;
^1da177e4c3f415 drivers/char/amiserial.c Linus Torvalds 2005-04-16 444 unsigned long flags;
^1da177e4c3f415 drivers/char/amiserial.c Linus Torvalds 2005-04-16 445 int retval=0;
^1da177e4c3f415 drivers/char/amiserial.c Linus Torvalds 2005-04-16 446 unsigned long page;
^1da177e4c3f415 drivers/char/amiserial.c Linus Torvalds 2005-04-16 447
^1da177e4c3f415 drivers/char/amiserial.c Linus Torvalds 2005-04-16 448 page = get_zeroed_page(GFP_KERNEL);
^1da177e4c3f415 drivers/char/amiserial.c Linus Torvalds 2005-04-16 449 if (!page)
^1da177e4c3f415 drivers/char/amiserial.c Linus Torvalds 2005-04-16 450 return -ENOMEM;
^1da177e4c3f415 drivers/char/amiserial.c Linus Torvalds 2005-04-16 451
^1da177e4c3f415 drivers/char/amiserial.c Linus Torvalds 2005-04-16 452 local_irq_save(flags);
^1da177e4c3f415 drivers/char/amiserial.c Linus Torvalds 2005-04-16 453
d41861ca19c9e96 drivers/tty/amiserial.c Peter Hurley 2016-04-09 454 if (tty_port_initialized(port)) {
^1da177e4c3f415 drivers/char/amiserial.c Linus Torvalds 2005-04-16 455 free_page(page);
^1da177e4c3f415 drivers/char/amiserial.c Linus Torvalds 2005-04-16 @456 goto errout;
^1da177e4c3f415 drivers/char/amiserial.c Linus Torvalds 2005-04-16 457 }
^1da177e4c3f415 drivers/char/amiserial.c Linus Torvalds 2005-04-16 458
^1da177e4c3f415 drivers/char/amiserial.c Linus Torvalds 2005-04-16 459 if (info->xmit.buf)
^1da177e4c3f415 drivers/char/amiserial.c Linus Torvalds 2005-04-16 460 free_page(page);
^1da177e4c3f415 drivers/char/amiserial.c Linus Torvalds 2005-04-16 461 else
^1da177e4c3f415 drivers/char/amiserial.c Linus Torvalds 2005-04-16 462 info->xmit.buf = (unsigned char *) page;
^1da177e4c3f415 drivers/char/amiserial.c Linus Torvalds 2005-04-16 463
:::::: The code at line 456 was first introduced by commit
:::::: 1da177e4c3f41524e886b7f1b8a0c1fc7321cac2 Linux-2.6.12-rc2
:::::: TO: Linus Torvalds <torvalds@ppc970.osdl.org>
:::::: CC: Linus Torvalds <torvalds@ppc970.osdl.org>
--
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki
next reply other threads:[~2026-10-10 5:04 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-10-10 5:04 kernel test robot [this message]
-- strict thread matches above, loose matches on Subject: below --
2026-05-13 13:14 drivers/tty/amiserial.c:456 rs_startup() warn: missing error code 'retval' kernel test robot
2026-01-14 15:51 kernel test robot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=202610100610.G565RJsp-lkp@intel.com \
--to=lkp@intel.com \
--cc=error27@gmail.com \
--cc=oe-kbuild@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.