Re: [PATCH net v5 0/2] tun: fix re-attaching the socket filter

[Simon Horman <horms@kernel.org>]

On Thu, Oct 08, 2026 at 04:04:18PM +0800, Rongguang Wei wrote:
> From: Rongguang Wei <weirongguang@kylinos.cn>
> 
> This is v5 of the series that fixes attaching a queue to a TAP device which
> re-installs the socket filter of a persistent device.
> 
> Patch 1 keeps a copy of the program in the kernel when it is configured,
> instead of reading tun->fprog from user space again on every later attach,
> and fixes the inverted error check in tun_attach(). The two changes are
> one patch on purpose: with only the kernel copy every re-attach returns 0
> without publishing the queue, and with only the check fixed a re-attach
> that used to succeed without a filter starts to fail. IFF_NOFILTER keeps
> working and is no longer needed as a workaround.
> 
> Patch 2 adds selftests: it re-attaches a queue after the buffer the program
> was copied from was made unreadable, attaches a second queue from a fresh
> socket to check that the filter is rebuilt from the kernel copy, and checks
> that a rejected TUNATTACHFILTER keeps the saved program, plus the ways to
> attach a queue without a filter.
> 
> Thanks to Willem de Bruijn for the reviews, and to the CI reviews for
> the comments they raised.
> 
> Rongguang Wei (2):
>   tun: keep a kernel copy of the socket filter program
>   selftests: net: add TAP socket filter attach tests

...

Hi Rongguang,

Unfortunately this patch-set did not apply cleanly to net,
and thus our CI did not run.

Please rebase and repost.

--
pw-bot: changes-requested