Re: [PATCH] crypto: aes - Add import_core/export_core to cmac/xcbc/cbcmac

[kernel test robot <lkp@intel.com>]

Hi Herbert,

kernel test robot noticed the following build warnings:

[auto build test WARNING on herbert-cryptodev-2.6/master]
[also build test WARNING on herbert-crypto-2.6/master linus/master v7.3-rc6 next-20261008]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch#_base_tree_information]

url:    https://github.com/intel-lab-lkp/linux/commits/Herbert-Xu/crypto-aes-Add-import_core-export_core-to-cmac-xcbc-cbcmac/20261009-224555
base:   https://git.kernel.org/pub/scm/linux/kernel/git/herbert/cryptodev-2.6.git master
patch link:    https://lore.kernel.org/r/asjT87HAZ_UUbbvm%40gondor.apana.org.au
patch subject: [PATCH] crypto: aes - Add import_core/export_core to cmac/xcbc/cbcmac
config: sparc-defconfig (https://download.01.org/0day-ci/archive/20261010/202610100824.r4C5Hjk0-lkp@intel.com/config)
compiler: sparc-linux-gcc (GCC) 16.1.0
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20261010/202610100824.r4C5Hjk0-lkp@intel.com/reproduce)

If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@intel.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202610100824.r4C5Hjk0-lkp@intel.com/

All warnings (new ones prefixed by >>):

>> crypto/aes.c:234:12: warning: 'crypto_cbcmac_import' defined but not used [-Wunused-function]
     234 | static int crypto_cbcmac_import(struct shash_desc *desc, const void *in)
         |            ^~~~~~~~~~~~~~~~~~~~
>> crypto/aes.c:223:12: warning: 'crypto_cbcmac_export' defined but not used [-Wunused-function]
     223 | static int crypto_cbcmac_export(struct shash_desc *desc, void *out)
         |            ^~~~~~~~~~~~~~~~~~~~


vim +/crypto_cbcmac_import +234 crypto/aes.c

   222	
 > 223	static int crypto_cbcmac_export(struct shash_desc *desc, void *out)
   224	{
   225		struct aes_cbcmac_ctx *ctx = AES_CBCMAC_CTX(desc);
   226		unsigned int partial = ctx->partial_len;
   227		u8 *p = out;
   228	
   229		memset(p + AES_BLOCK_SIZE, 0, AES_BLOCK_SIZE);
   230		p[AES_BLOCK_SIZE * 2] = partial;
   231		return crypto_cbcmac_export_core(desc, p);
   232	}
   233	
 > 234	static int crypto_cbcmac_import(struct shash_desc *desc, const void *in)
   235	{
   236		struct aes_cbcmac_ctx *ctx = AES_CBCMAC_CTX(desc);
   237		unsigned int partial;
   238		const u8 *p = in;
   239	
   240		crypto_cbcmac_import_core(desc, p);
   241		p += AES_BLOCK_SIZE;
   242		partial = p[AES_BLOCK_SIZE];
   243		if (partial > AES_BLOCK_SIZE)
   244			return -EOVERFLOW;
   245		crypto_xor(ctx->h, p, partial);
   246		ctx->partial_len = partial;
   247		return 0;
   248	}
   249	

--
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki