From: Stephen Hemminger <stephen@networkplumber.org>
To: Roman Khromenok <roma55592@yandex.ru>
Cc: dev@dpdk.org
Subject: Re: [PATCH 2/2] test: check newer SFF compliance codes
Date: Sat, 10 Oct 2026 11:23:47 -0700 [thread overview]
Message-ID: <20261010112347.74d942a8@phoenix.local> (raw)
In-Reply-To: <b388a9625bafdfc95adbf1b9812c89c1fd910829.1791574390.git.roma55592@yandex.ru>
On Fri, 9 Oct 2026 21:34:27 +0200
Roman Khromenok <roma55592@yandex.ru> wrote:
> Check the SFF-8472 Fibre Channel 1600, 3200 MBytes/s and 64GFC
> codes, with 64GFC reported only when byte 10 refers to byte 62,
> and the SFF-8636 SAS 24.0G, 12.0G and Fibre Channel 3200 MBytes/s
> codes.
>
> Add a helper to look for a value of a field reported more than
> once, such as "Transceiver type".
>
> Signed-off-by: Roman Khromenok <roma55592@yandex.ru>
> ---
More AI feedback.
[PATCH 2/2] test: check newer SFF compliance codes
Info:
- Each test sets both new bits of a pair at once (byte 10 = 0x28,
byte 133 = 0xc0), so a swapped mapping (1600 vs 3200, 24G vs
12G) still passes. Set one bit and check the other is absent:
data[133] = 0x80; /* SAS 24.0G only */
...
CHECK_FIELD_VALUE("Transceiver type", "SAS 24.0G");
CHECK_NO_FIELD_VALUE("Transceiver type", "SAS 12.0G");
Same for byte 10: 0x20 alone for 1600, then 0x08 alone for 3200.
next prev parent reply other threads:[~2026-10-10 18:32 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-10-09 19:34 [PATCH 1/2] ethdev: decode newer SFF compliance codes Roman Khromenok
2026-10-09 19:34 ` [PATCH 2/2] test: check " Roman Khromenok
2026-10-10 18:23 ` Stephen Hemminger [this message]
2026-10-10 18:23 ` [PATCH 1/2] ethdev: decode " Stephen Hemminger
2026-10-10 18:42 ` [PATCH v2 " Roman Khromenok
2026-10-10 18:42 ` [PATCH v2 2/2] test: check " Roman Khromenok
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20261010112347.74d942a8@phoenix.local \
--to=stephen@networkplumber.org \
--cc=dev@dpdk.org \
--cc=roma55592@yandex.ru \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.