From: Andrew Morton <akpm@linux-foundation.org>
To: "Qi Zheng" <zhengqi.arch@bytedance.com>
Cc: "kernel test robot" <yi1.lai@intel.com>, <oe-lkp@lists.linux.dev>,
<lkp@intel.com>, "Baolin Wang" <baolin.wang@linux.alibaba.com>,
"Christian Brauner" <brauner@kernel.org>,
"David Hildenbrand" <david@kernel.org>,
"Hugh Dickins" <hughd@google.com>,
"Johannes Weiner" <hannes@cmpxchg.org>,
"Michal Hocko" <mhocko@kernel.org>,
"Muchun Song" <muchun.song@linux.dev>,
"Roman Gushchin" <roman.gushchin@linux.dev>,
"Shakeel Butt" <shakeel.butt@linux.dev>,
"Qinyun Tan" <qinyuntan@linux.alibaba.com>, <linux-mm@kvack.org>
Subject: Re: [linux-next:master] [mm] b9b1861d4f: WARNING:possible_circular_locking_dependency_detected
Date: Sat, 10 Oct 2026 16:16:22 -0700 [thread overview]
Message-ID: <20261010161622.3a460fdbcd6765adb5c1eb7f@linux-foundation.org> (raw)
In-Reply-To: <36a0604d-b0ff-4f14-9203-0ffb36e0917b@bytedance.com>
On Fri, 9 Oct 2026 15:58:46 +0800 "Qi Zheng" <zhengqi.arch@bytedance.com> wrote:
> Could you please help test whether the following change makes the
> lockdep warning go away?
>
> diff --git a/mm/shmem.c b/mm/shmem.c
> index 5a9bcc7c66926..8ee767dccc1f6 100644
> --- a/mm/shmem.c
> +++ b/mm/shmem.c
> @@ -5162,6 +5162,8 @@ static const struct dentry_operations
> shmem_ci_dentry_ops = {
> };
> #endif
>
> +static struct lock_class_key shmem_unused_huge_lock_key;
> +
This could be local to shmem_fill_super().
And inside #ifdef CONFIG_TRANSPARENT_HUGEPAGE somehow.
> static int shmem_fill_super(struct super_block *sb, struct fs_context *fc)
> {
> struct shmem_options *ctx = fc->fs_private;
> @@ -5243,7 +5245,8 @@ static int shmem_fill_super(struct super_block
> *sb, struct fs_context *fc)
> goto failed;
>
> #ifdef CONFIG_TRANSPARENT_HUGEPAGE
> - if (list_lru_init_memcg(&sbinfo->shrinklist, sb->s_shrink))
> + if (list_lru_init_memcg_key(&sbinfo->shrinklist, sb->s_shrink,
> + &shmem_unused_huge_lock_key))
> goto failed;
> #endif
>
Thanks, I'll await a formal (non-wordwrapped!) patch.
next prev parent reply other threads:[~2026-10-10 23:16 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-10-09 6:46 [linux-next:master] [mm] b9b1861d4f: WARNING:possible_circular_locking_dependency_detected kernel test robot
2026-10-09 7:58 ` Qi Zheng
2026-10-10 2:07 ` kernel test rebot
2026-10-10 23:16 ` Andrew Morton [this message]
2026-10-11 4:50 ` Qi Zheng
2026-10-11 4:59 ` [PATCH] mm: shmem: assign a lock class to the unused huge shrinklist Qi Zheng
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20261010161622.3a460fdbcd6765adb5c1eb7f@linux-foundation.org \
--to=akpm@linux-foundation.org \
--cc=baolin.wang@linux.alibaba.com \
--cc=brauner@kernel.org \
--cc=david@kernel.org \
--cc=hannes@cmpxchg.org \
--cc=hughd@google.com \
--cc=linux-mm@kvack.org \
--cc=lkp@intel.com \
--cc=mhocko@kernel.org \
--cc=muchun.song@linux.dev \
--cc=oe-lkp@lists.linux.dev \
--cc=qinyuntan@linux.alibaba.com \
--cc=roman.gushchin@linux.dev \
--cc=shakeel.butt@linux.dev \
--cc=yi1.lai@intel.com \
--cc=zhengqi.arch@bytedance.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.