From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wm1-f45.google.com (mail-wm1-f45.google.com [209.85.128.45]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id ECD554BA1D3 for ; Sat, 10 Oct 2026 19:39:01 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.45 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1791661144; cv=none; b=OmkBo8YcjLeQAylL4sp20+UFPVseRKYgbs48aBLw1899J2F3m6zVqZG0PkpUT6KSCEdiCKtfCZbOhcwLgJxe3NzMRvQ7PQmnZ+V1RL7VsC5ZvAMy3sKie4vCh9T+bIAwAg3zm1/EAp+goxmBhj1hhY7AXhkOcvHctC/AB472m0U= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1791661144; c=relaxed/simple; bh=OUtfSIkkGgQjaN26hrQZj38jSK5FxxSgBi0/gGt+mJA=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=OEbiRUKo457EDOR69UzRhVYX7zoqnykRJ6SR2krfAyjG2Fb0SiGVA8G51alrx5FMEnSv8MXuBgrurU2BvRW8DgOzDFJznfY0JpfTpzSSIushegkvcfHy8tOdXIfkNnlce6WrVViCYw8hbRmLLTudj0BeVPu6hMqt/v30l4l7YrU= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=U7edwQeh; arc=none smtp.client-ip=209.85.128.45 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="U7edwQeh" Received: by mail-wm1-f45.google.com with SMTP id 5b1f17b1804b1-4a16aaf2067so9544675e9.0 for ; Sat, 10 Oct 2026 12:39:01 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1791661140; x=1792265940; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to:content-type; bh=BUMpjdK4jS9gtVb1V1R5qKUt2mxSNbNvfXMFgIuSSog=; b=U7edwQeh0PuPwuGoeIMWLrUf9RiK+w8NWV10ZdFsmJ7ZJ6vhrHClkHpvFJ9+hvgodg t8d+1tI1SpabUMzBODzyNSFpwTWf72QMl8CdAd5YYg4+vk9xd7ILoUsdZwg2r1u7niXf q2g0/If4KTQXfaLPc6tp/3yqx37eUuDi3u8rcnt7awYpmpLmXeuVfQgHvjfrMTaTVYpA bIH5JgFnZfDSznfHwKSUp1aeocBqxDyjNPdFm0MtcBcNfb797YM7ygU9apcD8dSAs11n ux0fAe4nDlmLzNuqwik/VDh2ZBxSMwVHGy3NqBtfNddJUGaBsodyyoaV56ZCX8SBnCeY mHyw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20260707; t=1791661140; x=1792265940; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to:content-type; bh=BUMpjdK4jS9gtVb1V1R5qKUt2mxSNbNvfXMFgIuSSog=; b=n68PdrDnPMMJ1dl0/Wk/GJrs8IM+8bepu7EACMFh6ATZa4LaNQL3UblLzx7sKCnWsZ HirQfuNs8IXnW1UFdNTr0BOpkZCGaP7/nvz07JxY/iKGVS4kFZhIB602vAF8w6lQ7EN0 oPl9q3+8r+ZjADMckfXCmV3e4GnrclNknN2BMEGhcG3yYg0kO6YeVnY1tZcS0wgwX8RX Oye1LMR3yVuNcxWZVfjwTR+sP13ITKJpi5HPXA4ESdYyyyS1FLAwAH15VQKGxIInEwZJ gcWZW7TtZj/9t5Pr/5OaktrUAi8H8NwWws/mHi2BcuT6fVqpZVsnvY2wCIebyQIV3OUQ CleQ== X-Gm-Message-State: AFq9FYLdrspcoTqRXKHsBsx8ym0md8O8etE/BxDQlkaQ+RLw2KEWydOL doSFaGUp45VkaH1PCenlBNw8rTb4WEgMCbVRo3rtCsV3a3HRtZVrXlUh X-Gm-Gg: AYBFou1DFGqf/2AJOunF+qHTLhSpfFnA066Cj4yVoOueZT3O9Cq9fWZcyUf5bDCdbDO 1nMwdPtjDH/aIuhFj98noqfjePkr8F4hnHThavAoZ15Aeo5mcz9pINfEjjfrZx2RXPJdM7WTZMX PqYfdSqwEdme1wOOOJ8wiNQJvbRVQp3HZUcwCPEoNLzn4XHFfDDsymliKTAQqzBclaaslj+fLzk VAvJF/KH7/yxGaqG3zLGquCdPnUeJrES/yB2xFbVKk72snapfGG6WgUzi0lfKPOse/OQkRQSfbc BUFseMTflRddf3xD/yihv4Vdfg8DCx7PUqtjctuvdEVMtzXTgqV3kB4lNC73dwuFFeloxSt7LIj WBGG8vCdki/G5EmBXq7UwbVj7CoFwhx3d4t8mPqahCX/sgsU5WWDpiw0G1qPqLcV2BIaVXImVD3 p9XJUg3Otrhk5T4hWhCZm287itMG4er043c0Ih9128qA1A4qxqc9kyAKYYehnNBxFZSivSWTqNd gdg5WLaq5KRXcYKeY11AROzud9ODo3d X-Received: by 2002:a05:600c:a00c:b0:49f:fe90:de63 with SMTP id 5b1f17b1804b1-4a18e4e0a3emr109134025e9.28.1791661139935; Sat, 10 Oct 2026 12:38:59 -0700 (PDT) Received: from localhost.localdomain ([67.209.128.125]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-48db94e3519sm11123224f8f.16.2026.10.10.12.38.58 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 10 Oct 2026 12:38:59 -0700 (PDT) From: "Pavel Kossenko (kotekompotek)" To: Corentin Chary , "Luke D . Jones" , Denis Benato , Hans de Goede , =?UTF-8?q?Ilpo=20J=C3=A4rvinen?= Cc: platform-driver-x86@vger.kernel.org, linux-kernel@vger.kernel.org, "Pavel Kossenko (kotekompotek)" Subject: [PATCH 1/2] platform/x86: asus-laptop: Unregister the wimax rfkill on exit Date: Sun, 11 Oct 2026 00:38:36 +0500 Message-ID: <20261010193837.1120-2-kotekompotek@gmail.com> X-Mailer: git-send-email 2.47.0.windows.2 In-Reply-To: <20261010193837.1120-1-kotekompotek@gmail.com> References: <20261010193837.1120-1-kotekompotek@gmail.com> Precedence: bulk X-Mailing-List: platform-driver-x86@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit asus_rfkill_init() registers an "asus-wimax" rfkill switch on machines that implement WM_RSTS, but asus_rfkill_exit() never unregisters it. The rfkill device is leaked when the driver is removed, and also when probe fails after asus_rfkill_init() has succeeded. Add the missing asus_rfkill_terminate() call. It is a no-op when the switch was never registered. Fixes: 3c8671ffd334 ("asus-laptop: add rfkill interfaces for wlan and wwan") Assisted-by: Claude Opus 5.5 Signed-off-by: Pavel Kossenko (kotekompotek) --- drivers/platform/x86/asus-laptop.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/platform/x86/asus-laptop.c b/drivers/platform/x86/asus-laptop.c index de607ed..8e69f02 100644 --- a/drivers/platform/x86/asus-laptop.c +++ b/drivers/platform/x86/asus-laptop.c @@ -1332,6 +1332,7 @@ static void asus_rfkill_terminate(struct asus_rfkill *rfk) static void asus_rfkill_exit(struct asus_laptop *asus) { + asus_rfkill_terminate(&asus->wimax); asus_rfkill_terminate(&asus->wwan); asus_rfkill_terminate(&asus->bluetooth); asus_rfkill_terminate(&asus->wlan); -- 2.47.0.windows.2