Re: [RFC PATCH v1 8/8] nfs: allow P2PDMA pages for O_DIRECT on RDMA mounts

[kernel test robot <lkp@intel.com>]

Hi Pranjal,

[This is a private test report for your RFC patch.]
kernel test robot noticed the following build errors:

[auto build test ERROR on next-20261006]
[cannot apply to linux-review/Pranjal-Shrivastava/nfs-make-nfs_page-pin-aware/20260814-143251 trondmy-nfs/linux-next v7.3-rc6 v7.3-rc5 v7.3-rc4 linus/master v7.3-rc6]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch#_base_tree_information]

url:    https://github.com/intel-lab-lkp/linux/commits/Pranjal-Shrivastava/sunrpc-introduce-XDRBUF_P2PDMA-flag/20261006-233241
base:   next-20261006
patch link:    https://lore.kernel.org/r/20261006233248.705086-9-praan%40google.com
patch subject: [RFC PATCH v1 8/8] nfs: allow P2PDMA pages for O_DIRECT on RDMA mounts
config: nios2-defconfig (https://download.01.org/0day-ci/archive/20261010/202610102028.Yv2iFdar-lkp@intel.com/config)
compiler: nios2-linux-gcc (GCC) 11.5.0
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20261010/202610102028.Yv2iFdar-lkp@intel.com/reproduce)

If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@intel.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202610102028.Yv2iFdar-lkp@intel.com/

All errors (new ones prefixed by >>):

   fs/nfs/direct.c: In function 'nfs_direct_extract_pages':
>> fs/nfs/direct.c:171:14: error: implicit declaration of function 'pnfs_enabled_sb' [-Werror=implicit-function-declaration]
     171 |             !pnfs_enabled_sb(server))
         |              ^~~~~~~~~~~~~~~
   cc1: some warnings being treated as errors


vim +/pnfs_enabled_sb +171 fs/nfs/direct.c

   154	
   155	static ssize_t nfs_direct_extract_pages(struct nfs_direct_req *dreq,
   156						struct iov_iter *iter,
   157						size_t size, loff_t *pos,
   158						struct list_head *list)
   159	{
   160		struct nfs_server *server = NFS_SERVER(dreq->inode);
   161		bool pinned = iov_iter_extract_will_pin(iter);
   162		iov_iter_extraction_t flags = 0;
   163		struct page **pagevec = NULL;
   164		ssize_t result, bytes = 0;
   165		int err = 0;
   166		unsigned int npages, i;
   167		size_t pgbase;
   168	
   169		/* Allow P2PDMA pages only on RDMA mounts that do not use pNFS */
   170		if (server->nfs_client->cl_proto == XPRT_TRANSPORT_RDMA &&
 > 171		    !pnfs_enabled_sb(server))
   172			flags = ITER_ALLOW_P2PDMA;
   173	
   174		result = iov_iter_extract_pages(iter, &pagevec, size, ~0U, flags,
   175						&pgbase);
   176		if (result <= 0)
   177			return result;
   178	
   179		npages = (result + pgbase + PAGE_SIZE - 1) >> PAGE_SHIFT;
   180		for (i = 0; i < npages; i++) {
   181			struct nfs_page *req;
   182			unsigned int req_len = min_t(size_t, result - bytes, PAGE_SIZE - pgbase);
   183	
   184			req = nfs_page_create_from_page(dreq->ctx, pagevec[i],
   185							pinned, pgbase, *pos,
   186							req_len);
   187			if (IS_ERR(req)) {
   188				err = PTR_ERR(req);
   189				break;
   190			}
   191	
   192			list_add_tail(&req->wb_list, list);
   193			pgbase = 0;
   194			bytes += req_len;
   195			*pos += req_len;
   196		}
   197	
   198		if (i < npages) {
   199			iov_iter_revert(iter, result - bytes);
   200			nfs_direct_release_pages(pagevec + i, npages - i, pinned);
   201		}
   202	
   203		kvfree(pagevec);
   204		return bytes ? bytes : err;
   205	}
   206	

--
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki