All of lore.kernel.org
 help / color / mirror / Atom feed
From: Karlos Abel <kabel@voidship.net>
To: Dmitry Torokhov <dmitry.torokhov@gmail.com>
Cc: linux-input@vger.kernel.org, linux-kernel@vger.kernel.org,
	sashiko-bot@kernel.org
Subject: [PATCH v3 0/2] Input: discard pre-registration events and test state seeding
Date: Sat, 10 Oct 2026 18:58:06 -0400	[thread overview]
Message-ID: <20261010225808.36404-1-kabel@voidship.net> (raw)

This series prevents input handlers from receiving buffered initialization
events after device registration. On a ThinkPad T14 Gen 6, a later LED
update flushed a stale SW_RFKILL_ALL event seeded by thinkpad_acpi.
The fix drops the pending events and their timestamp before handlers
attach, while retaining the seeded switch and absolute-axis state.

Patch 1 contains the runtime fix. Patch 2 adds KUnit coverage for
registration with and without event-buffer resizing. The test uses a
virtual SW_DOCK device and performs no real radio operations.

Tested on mainline 3857c2fe5449541e24afc5efdb0f81a8a8f9a3a0:
 - V3 with both patches: all six input-core KUnit tests pass under UML,
   with CONFIG_PROVE_LOCKING and CONFIG_DEBUG_SPINLOCK enabled. No
   compiler warnings or lockdep diagnostics were reported.
 - The unchanged tests previously failed against the unmodified input
   core: four passed and two failed. The non-resizing case replayed one
   stale switch event; both cases retained the initialization timestamp.

Earlier versions using a scoped spinlock guard were also tested with
QEMU/KVM on Arch 7.2.7 and on the ThinkPad. V3 uses the same underlying
lock/unlock operations but has not been rerun on physical hardware.

AI assistance: OpenAI Codex assisted source analysis, the fix, regression
tests and this text. The submitter performed the physical hardware
comparisons.

Previous version:
 Message-ID: <20261010191033.23577-1-kabel@voidship.net>
Review addressed:
 Message-ID: <sashiko-outbox-166847@kernel.org>

Changes in v3:
 - Use an explicit spin_lock_irq()/spin_unlock_irq() pair instead of
   adding scoped cleanup to the goto-based registration path.
 - Include the spinlock declarations directly.
 - Patch 2 is unchanged from v2.

Changes in v2:
 - Check absinfo allocation before test event seeding.
 - Unregister the test handler before unregistering its device.

Karlos Abel (2):
  Input: discard pre-registration events before attaching handlers
  Input: test state seeding across device registration

 drivers/input/input.c            |   7 ++
 drivers/input/tests/input_test.c | 171 +++++++++++++++++++++++++++++++++++++++
 2 files changed, 178 insertions(+)

base-commit: 3857c2fe5449541e24afc5efdb0f81a8a8f9a3a0

             reply	other threads:[~2026-10-10 22:58 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-10-10 22:58 Karlos Abel [this message]
2026-10-10 22:58 ` [PATCH v3 1/2] Input: discard pre-registration events before attaching handlers Karlos Abel
2026-10-10 22:58 ` [PATCH v3 2/2] Input: test state seeding across device registration Karlos Abel

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20261010225808.36404-1-kabel@voidship.net \
    --to=kabel@voidship.net \
    --cc=dmitry.torokhov@gmail.com \
    --cc=linux-input@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=sashiko-bot@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.