From: Joshua Crofts <joshua.crofts1@gmail.com>
To: Arnav Kapoor <kapoorarnav43@gmail.com>
Cc: "Jean-Baptiste Maneyrol" <jean-baptiste.maneyrol@tdk.com>,
"Jonathan Cameron" <jic23@kernel.org>,
"David Lechner" <dlechner@baylibre.com>,
"Nuno Sá" <nuno.sa@analog.com>,
"Andy Shevchenko" <andy@kernel.org>,
linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] iio: imu: inv_mpu6050: fix kernel-doc warnings
Date: Sun, 11 Oct 2026 19:33:57 +0200 [thread overview]
Message-ID: <20261011193357.51c393e4@systembl0wer> (raw)
In-Reply-To: <20261011045754.358335-1-kapoorarnav43@gmail.com>
On Sun, 11 Oct 2026 10:27:49 +0530
Arnav Kapoor <kapoorarnav43@gmail.com> wrote:
> scripts/kernel-doc -Wall reports several warnings for the inv_mpu6050
> driver:
>
> - inv_mpu_magn_get_scale() only describes @st, not @chan, @val and @val2.
> - Eight functions use "Returns ..." in the body instead of a "Return:"
> section, and inv_mpu6050_set_enable() and
> inv_mpu_data_rdy_trigger_set_state() do not describe their return
> value at all, e.g.:
>
> Warning: .../inv_mpu_aux.c:87 No description found for return value
> of 'inv_mpu_aux_init'
>
> - int_pin_cfg in struct inv_mpu6050_reg_map is documented with a ';'
> instead of a ':' after the name, so kernel-doc does not see it, and
> user_ctrl in struct inv_mpu6050_chip_config and startup_time in
> struct inv_mpu6050_hw are not documented.
>
> Describe the missing parameters, members and return values, and convert
> the return value descriptions to "Return:" sections. Where the return
> value was described before the long description, move it after it, so
> the description is not parsed as part of the return value section.
>
> With this change, scripts/kernel-doc -Wall reports no warnings for
> drivers/iio/imu/inv_mpu6050/. Comment-only change.
>
> Assisted-by: LLM
> Signed-off-by: Arnav Kapoor <kapoorarnav43@gmail.com>
> ---
Reviewed-by: Joshua Crofts <joshua.crofts1@gmail.com>
--
Kind regards,
Joshua Crofts
prev parent reply other threads:[~2026-10-11 17:34 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-10-11 4:57 [PATCH] iio: imu: inv_mpu6050: fix kernel-doc warnings Arnav Kapoor
2026-10-11 17:33 ` Joshua Crofts [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20261011193357.51c393e4@systembl0wer \
--to=joshua.crofts1@gmail.com \
--cc=andy@kernel.org \
--cc=dlechner@baylibre.com \
--cc=jean-baptiste.maneyrol@tdk.com \
--cc=jic23@kernel.org \
--cc=kapoorarnav43@gmail.com \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=nuno.sa@analog.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.