Re: [PATCH v3 2/3] dt-bindings: input: touchscreen: add Nsiway NS2009

[Conor Dooley <conor@kernel.org>]

[-- Attachment #1: Type: text/plain, Size: 4018 bytes --]

On Mon, Oct 12, 2026 at 12:17:08PM +0000, Miotsuki Mizuno wrote:
> From: Mizuno Miotsuki <founder@crepuse.com>
> 
> Describe the Nsiway NS2009 four-wire resistive touchscreen controller
> with optional pen interrupt, power and reference supplies, and touch
> resistance measurement properties. Include one complete example.
> 
> Signed-off-by: Mizuno Miotsuki <founder@crepuse.com>
> ---
>  .../input/touchscreen/nsiway,ns2009.yaml      | 78 +++++++++++++++++++
>  MAINTAINERS                                   |  6 ++
>  2 files changed, 84 insertions(+)
>  create mode 100644 Documentation/devicetree/bindings/input/touchscreen/nsiway,ns2009.yaml
> 
> diff --git a/Documentation/devicetree/bindings/input/touchscreen/nsiway,ns2009.yaml b/Documentation/devicetree/bindings/input/touchscreen/nsiway,ns2009.yaml
> new file mode 100644
> index 000000000000..caea15b5c5a3
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/input/touchscreen/nsiway,ns2009.yaml
> @@ -0,0 +1,78 @@
> +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/input/touchscreen/nsiway,ns2009.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: Nsiway NS2009 resistive touchscreen controller
> +
> +maintainers:
> +  - Mizuno Miotsuki <founder@crepuse.com>
> +
> +description:
> +  Nsiway NS2009 is an I2C four-wire resistive touchscreen controller with
> +  a 12-bit ADC, an active-low pen interrupt and touch resistance measurement.
> +
> +allOf:
> +  - $ref: touchscreen.yaml#
> +
> +properties:
> +  compatible:
> +    const: nsiway,ns2009
> +
> +  reg:
> +    maxItems: 1
> +
> +  interrupts:
> +    maxItems: 1
> +    description:
> +      Active-low pen interrupt output. Optional when the signal is not
> +      connected.
> +
> +  wakeup-source:
> +    type: boolean
> +
> +  vdd-supply:
> +    description: Main power supply.
> +
> +  vref-supply:
> +    description: External ADC reference voltage supply.
> +
> +  touchscreen-min-pressure:
> +    minimum: 1
> +    maximum: 4095
> +    default: 80
> +    description:
> +      Minimum raw Z1 reading considered a touch. This is a contact detection
> +      threshold, not a calibrated pressure value. Boards may require a higher
> +      empirically determined threshold than the historical driver default.
> +
> +required:
> +  - compatible
> +  - reg

Sounds like vdd-supply should also be required. I assume vref-supply is
optional?

Looks okay otherwise.
pw-bot: changes-requested

Thanks,
Conor.

> +
> +unevaluatedProperties: false
> +
> +examples:
> +  - |
> +    #include <dt-bindings/interrupt-controller/irq.h>
> +
> +    i2c {
> +        #address-cells = <1>;
> +        #size-cells = <0>;
> +
> +        touchscreen@48 {
> +            compatible = "nsiway,ns2009";
> +            reg = <0x48>;
> +            interrupt-parent = <&gpio1>;
> +            interrupts = <7 IRQ_TYPE_LEVEL_LOW>;
> +            wakeup-source;
> +            vdd-supply = <&vdd>;
> +            vref-supply = <&vref>;
> +            touchscreen-x-plate-ohms = <400>;
> +            touchscreen-min-pressure = <150>;
> +            touchscreen-max-pressure = <4095>;
> +            touchscreen-fuzz-pressure = <16>;
> +            touchscreen-inverted-y;
> +        };
> +    };
> diff --git a/MAINTAINERS b/MAINTAINERS
> index f53047aa8d3c..696f2badc49c 100644
> --- a/MAINTAINERS
> +++ b/MAINTAINERS
> @@ -19467,6 +19467,12 @@ S:	Maintained
>  F:	Documentation/core-api/symbol-namespaces.rst
>  F:	scripts/nsdeps
>  
> +NSIWAY NS2009 TOUCHSCREEN CONTROLLER
> +M:	Mizuno Miotsuki <founder@crepuse.com>
> +L:	linux-input@vger.kernel.org
> +S:	Maintained
> +F:	Documentation/devicetree/bindings/input/touchscreen/nsiway,ns2009.yaml
> +
>  NTB AMD DRIVER
>  M:	Basavaraj Natikar <Basavaraj.Natikar@amd.com>
>  M:	Shyam Sundar S K <Shyam-sundar.S-k@amd.com>
> -- 
> 2.56.0
> 

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]