From: Conor Dooley <conor@kernel.org>
To: Antoniu Miclaus <antoniu.miclaus@analog.com>
Cc: "Nuno Sá" <nuno.sa@analog.com>,
"Michael Hennerich" <Michael.Hennerich@analog.com>,
"Jonathan Cameron" <jic23@kernel.org>,
"David Lechner" <dlechner@baylibre.com>,
"Rob Herring" <robh@kernel.org>,
"Krzysztof Kozlowski" <krzk+dt@kernel.org>,
"Conor Dooley" <conor+dt@kernel.org>,
"Jonathan Corbet" <corbet@lwn.net>,
"Shuah Khan" <skhan@linuxfoundation.org>,
"Randy Dunlap" <rdunlap@infradead.org>,
"Marcelo Schmitt" <marcelo.schmitt@analog.com>,
"Joshua Crofts" <joshua.crofts1@gmail.com>,
"Radu Sabau" <radu.sabau@analog.com>,
"Janani Sunil" <janani.sunil@analog.com>,
"Salih Erim" <salih.erim@amd.com>,
"Jishnu Prakash" <jishnu.prakash@oss.qualcomm.com>,
"Jakub Szczudlo" <jakubszczudlo40@gmail.com>,
linux@analog.com, linux-iio@vger.kernel.org,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-doc@vger.kernel.org
Subject: Re: [PATCH 2/4] dt-bindings: iio: adc: adi,ade9000: add adi,ade9039 compatible
Date: Mon, 12 Oct 2026 19:59:48 +0100 [thread overview]
Message-ID: <20261012-thinly-debrief-615f863ffa77@spud> (raw)
In-Reply-To: <20261012111342.48040-3-antoniu.miclaus@analog.com>
[-- Attachment #1: Type: text/plain, Size: 4349 bytes --]
On Mon, Oct 12, 2026 at 02:13:38PM +0300, Antoniu Miclaus wrote:
> The ADE9039 is a polyphase energy metering device from the same family as
> the ADE9000. It is register compatible with the ADE9000 for everything the
> driver uses, provides the same on-chip dip/swell detection, and shares the
> full-scale codes of the ADE9078.
>
> It computes only fundamental reactive power and has no total reactive power
> register, which is noted in the description. Like the ADE9078 it supports a
AFAICT, this first sentence here is what prevents using a fallback,
could you be more clear about that please?
Otherwise,
Acked-by: Conor Dooley <conor.dooley@microchip.com>
pw-bot: not-applicable
Thanks,
Conor.
> maximum serial clock frequency of 10 MHz rather than 20 MHz, so extend the
> existing spi-max-frequency constraint to cover it.
>
> Signed-off-by: Antoniu Miclaus <antoniu.miclaus@analog.com>
> ---
> .../bindings/iio/adc/adi,ade9000.yaml | 29 +++++++++++--------
> 1 file changed, 17 insertions(+), 12 deletions(-)
>
> diff --git a/Documentation/devicetree/bindings/iio/adc/adi,ade9000.yaml b/Documentation/devicetree/bindings/iio/adc/adi,ade9000.yaml
> index bcc166aad713..70106dd052ce 100644
> --- a/Documentation/devicetree/bindings/iio/adc/adi,ade9000.yaml
> +++ b/Documentation/devicetree/bindings/iio/adc/adi,ade9000.yaml
> @@ -5,26 +5,28 @@
> $id: http://devicetree.org/schemas/iio/adc/adi,ade9000.yaml#
> $schema: http://devicetree.org/meta-schemas/core.yaml#
>
> -title: Analog Devices ADE9000/ADE9078/ADE9430 High Performance, Polyphase Energy Metering
> +title: Analog Devices ADE9000/ADE9078/ADE9430/ADE9039 High Performance, Polyphase Energy Metering
>
> maintainers:
> - Antoniu Miclaus <antoniu.miclaus@analog.com>
>
> description: |
> - The ADE9000, ADE9078 and ADE9430 are highly accurate, fully integrated,
> - multiphase energy and power quality monitoring devices. Superior analog
> - performance and a digital signal processing (DSP) core enable accurate energy
> - monitoring over a wide dynamic range. An integrated high end reference ensures
> - low drift over temperature with a combined drift of less than ±25 ppm/°C
> - maximum for the entire channel including a programmable gain amplifier (PGA)
> - and an analog-to-digital converter (ADC). The ADE9078 and ADE9430 do not
> - provide the on-chip dip/swell detection available on the ADE9000, and the
> - ADE9430 has no on-chip digital integrator (it uses an external analog
> - integrator for Rogowski coils).
> + The ADE9000, ADE9078, ADE9430 and ADE9039 are highly accurate, fully
> + integrated, multiphase energy and power quality monitoring devices. Superior
> + analog performance and a digital signal processing (DSP) core enable accurate
> + energy monitoring over a wide dynamic range. An integrated high end reference
> + ensures low drift over temperature with a combined drift of less than
> + ±25 ppm/°C maximum for the entire channel including a programmable gain
> + amplifier (PGA) and an analog-to-digital converter (ADC). The ADE9078 and
> + ADE9430 do not provide the on-chip dip/swell detection available on the
> + ADE9000 and the ADE9039, and the ADE9430 has no on-chip digital integrator
> + (it uses an external analog integrator for Rogowski coils). The ADE9039 only
> + computes fundamental reactive power and has no total reactive power register.
>
> https://www.analog.com/media/en/technical-documentation/data-sheets/ADE9000.pdf
> https://www.analog.com/media/en/technical-documentation/data-sheets/ADE9078.pdf
> https://www.analog.com/media/en/technical-documentation/data-sheets/ADE9430.pdf
> + https://www.analog.com/media/en/technical-documentation/data-sheets/ADE9039.pdf
>
> $ref: /schemas/spi/spi-peripheral-props.yaml#
>
> @@ -32,6 +34,7 @@ properties:
> compatible:
> enum:
> - adi,ade9000
> + - adi,ade9039
> - adi,ade9078
> - adi,ade9430
>
> @@ -79,7 +82,9 @@ allOf:
> properties:
> compatible:
> contains:
> - const: adi,ade9078
> + enum:
> + - adi,ade9039
> + - adi,ade9078
> then:
> properties:
> spi-max-frequency:
> --
> 2.43.0
>
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]
next prev parent reply other threads:[~2026-10-12 18:59 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-10-12 11:13 [PATCH 0/4] iio: adc: ade9000: add support for ADE9039 Antoniu Miclaus
2026-10-12 11:13 ` [PATCH 1/4] iio: adc: ade9000: parameterise the reactive power channel Antoniu Miclaus
2026-10-12 13:51 ` Joshua Crofts
2026-10-12 11:13 ` [PATCH 2/4] dt-bindings: iio: adc: adi,ade9000: add adi,ade9039 compatible Antoniu Miclaus
2026-10-12 13:46 ` Joshua Crofts
2026-10-12 18:59 ` Conor Dooley [this message]
2026-10-12 11:13 ` [PATCH 3/4] iio: adc: ade9000: add support for ADE9039 Antoniu Miclaus
2026-10-12 13:50 ` Joshua Crofts
2026-10-12 11:13 ` [PATCH 4/4] docs: iio: ade9000: document ADE9039 support Antoniu Miclaus
2026-10-12 13:49 ` Joshua Crofts
2026-10-13 9:51 ` [PATCH 0/4] iio: adc: ade9000: add support for ADE9039 Nuno Sá
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20261012-thinly-debrief-615f863ffa77@spud \
--to=conor@kernel.org \
--cc=Michael.Hennerich@analog.com \
--cc=antoniu.miclaus@analog.com \
--cc=conor+dt@kernel.org \
--cc=corbet@lwn.net \
--cc=devicetree@vger.kernel.org \
--cc=dlechner@baylibre.com \
--cc=jakubszczudlo40@gmail.com \
--cc=janani.sunil@analog.com \
--cc=jic23@kernel.org \
--cc=jishnu.prakash@oss.qualcomm.com \
--cc=joshua.crofts1@gmail.com \
--cc=krzk+dt@kernel.org \
--cc=linux-doc@vger.kernel.org \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@analog.com \
--cc=marcelo.schmitt@analog.com \
--cc=nuno.sa@analog.com \
--cc=radu.sabau@analog.com \
--cc=rdunlap@infradead.org \
--cc=robh@kernel.org \
--cc=salih.erim@amd.com \
--cc=skhan@linuxfoundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.