All of lore.kernel.org
 help / color / mirror / Atom feed
From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: khaliforce <kforce@gmail.com>
Cc: "Ilpo Järvinen" <ilpo.jarvinen@linux.intel.com>,
	"Andy Shevchenko" <andriy.shevchenko@linux.intel.com>,
	"Jiri Slaby" <jirislaby@kernel.org>,
	linux-kernel@vger.kernel.org, linux-serial@vger.kernel.org
Subject: Re: [PATCH] serial: 8250_dw: retain programmed timing for BUSY waits
Date: Mon, 12 Oct 2026 08:33:48 +0200	[thread overview]
Message-ID: <2026101202-bride-friction-454e@gregkh> (raw)
In-Reply-To: <1791785420.8010663.945898876521967.uart-busy-frame-time@gmail.com>

On Mon, Oct 12, 2026 at 06:10:20AM -0000, khaliforce wrote:
> +	if (d->data.frame_time && d->data.frame_time_uartclk && p->uartclk) {
> +		scaled_frame_time = (u64)frame_time * d->data.frame_time_uartclk;
> +		scaled_frame_time = DIV_ROUND_UP_ULL(scaled_frame_time, p->uartclk);
> +		frame_time = min_t(u64, scaled_frame_time, U32_MAX);

This looks like a LLM wrote this, as min_t() is what they love to use.
Are you sure this is correct?

thanks,

greg k-h

  parent reply	other threads:[~2026-10-12  6:33 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-10-12  6:10 [PATCH] serial: 8250_dw: retain programmed timing for BUSY waits khaliforce
2026-10-12  6:24 ` sashiko-bot
2026-10-12  6:31 ` Greg Kroah-Hartman
2026-10-12  6:33 ` Greg Kroah-Hartman [this message]
2026-10-12 12:08 ` Ilpo Järvinen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=2026101202-bride-friction-454e@gregkh \
    --to=gregkh@linuxfoundation.org \
    --cc=andriy.shevchenko@linux.intel.com \
    --cc=ilpo.jarvinen@linux.intel.com \
    --cc=jirislaby@kernel.org \
    --cc=kforce@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-serial@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.