[snitzer:kernel-7.3/main 105/167] include/linux/atomic/atomic-arch-fallback.h:259:14: error: invalid use of void expression

[kernel test robot <lkp@intel.com>]

tree:   https://git.kernel.org/pub/scm/linux/kernel/git/snitzer/linux.git kernel-7.3/main
head:   790d686a2be11b8bd1a028272f63bd49da1f7666
commit: 3cb87e25d0dce98de0172c4925acca4a481c39c5 [105/167] NFSv4/flexfiles: move layoutstats accounting to a per-stripe lock
config: sh-allmodconfig (https://download.01.org/0day-ci/archive/20261012/202610120616.f9AEpmNF-lkp@intel.com/config)
compiler: sh4-linux-gcc (GCC) 16.1.0
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20261012/202610120616.f9AEpmNF-lkp@intel.com/reproduce)

If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@intel.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202610120616.f9AEpmNF-lkp@intel.com/

All errors (new ones prefixed by >>):

   In file included from include/linux/atomic.h:80,
                    from include/asm-generic/bitops/atomic.h:5,
                    from arch/sh/include/asm/bitops.h:23,
                    from include/linux/bitops.h:67,
                    from include/linux/kernel.h:23,
                    from include/linux/uio.h:8,
                    from include/linux/socket.h:8,
                    from include/uapi/linux/in.h:25,
                    from include/linux/in.h:19,
                    from include/linux/nfs_fs.h:22,
                    from fs/nfs/flexfilelayout/flexfilelayout.c:10:
   fs/nfs/flexfilelayout/flexfilelayout.c: In function 'nfs4_ff_layoutstat_start_io':
>> include/linux/atomic/atomic-arch-fallback.h:259:14: error: invalid use of void expression
     259 |         ___r = raw_cmpxchg64((_ptr), ___o, (_new)); \
         |              ^
   include/linux/atomic/atomic-instrumented.h:4918:9: note: in expansion of macro 'raw_try_cmpxchg64'
    4918 |         raw_try_cmpxchg64(__ai_ptr, __ai_oldp, __VA_ARGS__); \
         |         ^~~~~~~~~~~~~~~~~
   fs/nfs/flexfilelayout/flexfilelayout.c:760:16: note: in expansion of macro 'try_cmpxchg64'
     760 |         return try_cmpxchg64(&ffl->last_report_time, &last_report, now);
         |                ^~~~~~~~~~~~~
--
   In file included from include/linux/atomic.h:80,
                    from include/asm-generic/bitops/atomic.h:5,
                    from arch/sh/include/asm/bitops.h:23,
                    from include/linux/bitops.h:67,
                    from include/linux/kernel.h:23,
                    from include/linux/uio.h:8,
                    from include/linux/socket.h:8,
                    from include/uapi/linux/in.h:25,
                    from include/linux/in.h:19,
                    from include/linux/nfs_fs.h:22,
                    from flexfilelayout.c:10:
   flexfilelayout.c: In function 'nfs4_ff_layoutstat_start_io':
>> include/linux/atomic/atomic-arch-fallback.h:259:14: error: invalid use of void expression
     259 |         ___r = raw_cmpxchg64((_ptr), ___o, (_new)); \
         |              ^
   include/linux/atomic/atomic-instrumented.h:4918:9: note: in expansion of macro 'raw_try_cmpxchg64'
    4918 |         raw_try_cmpxchg64(__ai_ptr, __ai_oldp, __VA_ARGS__); \
         |         ^~~~~~~~~~~~~~~~~
   flexfilelayout.c:760:16: note: in expansion of macro 'try_cmpxchg64'
     760 |         return try_cmpxchg64(&ffl->last_report_time, &last_report, now);
         |                ^~~~~~~~~~~~~


vim +259 include/linux/atomic/atomic-arch-fallback.h

29f006fdefe6f88 include/linux/atomic-arch-fallback.h        Peter Zijlstra 2020-08-29  249  
9257959a6e5b4fc include/linux/atomic/atomic-arch-fallback.h Mark Rutland   2023-06-05  250  #if defined(arch_try_cmpxchg64)
9257959a6e5b4fc include/linux/atomic/atomic-arch-fallback.h Mark Rutland   2023-06-05  251  #define raw_try_cmpxchg64 arch_try_cmpxchg64
9257959a6e5b4fc include/linux/atomic/atomic-arch-fallback.h Mark Rutland   2023-06-05  252  #elif defined(arch_try_cmpxchg64_relaxed)
9257959a6e5b4fc include/linux/atomic/atomic-arch-fallback.h Mark Rutland   2023-06-05  253  #define raw_try_cmpxchg64(...) \
9257959a6e5b4fc include/linux/atomic/atomic-arch-fallback.h Mark Rutland   2023-06-05  254  	__atomic_op_fence(arch_try_cmpxchg64, __VA_ARGS__)
9257959a6e5b4fc include/linux/atomic/atomic-arch-fallback.h Mark Rutland   2023-06-05  255  #else
9257959a6e5b4fc include/linux/atomic/atomic-arch-fallback.h Mark Rutland   2023-06-05  256  #define raw_try_cmpxchg64(_ptr, _oldp, _new) \
0aa7be05d83cc58 include/linux/atomic/atomic-arch-fallback.h Uros Bizjak    2022-05-15  257  ({ \
0aa7be05d83cc58 include/linux/atomic/atomic-arch-fallback.h Uros Bizjak    2022-05-15  258  	typeof(*(_ptr)) *___op = (_oldp), ___o = *___op, ___r; \
9257959a6e5b4fc include/linux/atomic/atomic-arch-fallback.h Mark Rutland   2023-06-05 @259  	___r = raw_cmpxchg64((_ptr), ___o, (_new)); \
0aa7be05d83cc58 include/linux/atomic/atomic-arch-fallback.h Uros Bizjak    2022-05-15  260  	if (unlikely(___r != ___o)) \
0aa7be05d83cc58 include/linux/atomic/atomic-arch-fallback.h Uros Bizjak    2022-05-15  261  		*___op = ___r; \
0aa7be05d83cc58 include/linux/atomic/atomic-arch-fallback.h Uros Bizjak    2022-05-15  262  	likely(___r == ___o); \
0aa7be05d83cc58 include/linux/atomic/atomic-arch-fallback.h Uros Bizjak    2022-05-15  263  })
9257959a6e5b4fc include/linux/atomic/atomic-arch-fallback.h Mark Rutland   2023-06-05  264  #endif
0aa7be05d83cc58 include/linux/atomic/atomic-arch-fallback.h Uros Bizjak    2022-05-15  265  

:::::: The code at line 259 was first introduced by commit
:::::: 9257959a6e5b4fca6fc8e985790bff62c2046f20 locking/atomic: scripts: restructure fallback ifdeffery

:::::: TO: Mark Rutland <mark.rutland@arm.com>
:::::: CC: Peter Zijlstra <peterz@infradead.org>

--
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki