From: Ido Schimmel <idosch@nvidia.com>
To: Jin Li <jinli@lanxincomputing.com>
Cc: Shuah Khan <shuah@kernel.org>, David Ahern <dsahern@kernel.org>,
"David S . Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
Simon Horman <horms@kernel.org>,
netdev@vger.kernel.org, linux-kselftest@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] selftests: net: forwarding: bridge_vlan_mcast: Allow default startup query interval to vary by HZ
Date: Mon, 12 Oct 2026 14:54:14 +0300 [thread overview]
Message-ID: <20261012115414.GA704996@shredder> (raw)
In-Reply-To: <20261009104109.754133-1-jinli@lanxincomputing.com>
Subject prefix should be "[PATCH net-next]" given that this never
worked. See:
https://docs.kernel.org/next/process/maintainer-netdev.html
On Fri, Oct 09, 2026 at 10:41:09AM +0000, Jin Li wrote:
> The mcast_startup_query_interval default value is calculated as
> 125 * HZ / 4. With CONFIG_HZ=250, this results in 3124 instead of
> 3125 due to integer truncation. The test currently hardcodes 3125,
> which fails on kernels built with CONFIG_HZ=250.
>
> Allow a +/- 1 tolerance for the default value check to account for
> this rounding, while still catching genuine regressions in the
> default value.
>
> Signed-off-by: Jin Li <jinli@lanxincomputing.com>
> ---
> tools/testing/selftests/net/forwarding/bridge_vlan_mcast.sh | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/tools/testing/selftests/net/forwarding/bridge_vlan_mcast.sh b/tools/testing/selftests/net/forwarding/bridge_vlan_mcast.sh
> index c4cd2078a8db..e72680869721 100755
> --- a/tools/testing/selftests/net/forwarding/bridge_vlan_mcast.sh
> +++ b/tools/testing/selftests/net/forwarding/bridge_vlan_mcast.sh
> @@ -383,7 +383,7 @@ vlmc_startup_query_test()
>
> echo -n $goutput |
> jq -e ".[].vlans[] | select(.vlan == 10 and \
> - .mcast_startup_query_interval == 3125) " &>/dev/null
> + .mcast_startup_query_interval >= 3124 and .mcast_startup_query_interval <= 3126) " &>/dev/null
Maintain the same type of indentation (tabs) as the current line and
fold it:
diff --git a/tools/testing/selftests/net/forwarding/bridge_vlan_mcast.sh b/tools/testing/selftests/net/forwarding/bridge_vlan_mcast.sh
index c4cd2078a8db..c07c2af5df94 100755
--- a/tools/testing/selftests/net/forwarding/bridge_vlan_mcast.sh
+++ b/tools/testing/selftests/net/forwarding/bridge_vlan_mcast.sh
@@ -383,7 +383,8 @@ vlmc_startup_query_test()
echo -n $goutput |
jq -e ".[].vlans[] | select(.vlan == 10 and \
- .mcast_startup_query_interval == 3125) " &>/dev/null
+ .mcast_startup_query_interval >= 3124 and \
+ .mcast_startup_query_interval <= 3126) " &>/dev/null
check_err $? "Wrong default mcast_startup_query_interval global vlan option value"
log_test "Vlan mcast_startup_query_interval global option default value"
prev parent reply other threads:[~2026-10-12 11:56 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-10-09 10:41 [PATCH] selftests: net: forwarding: bridge_vlan_mcast: Allow default startup query interval to vary by HZ Jin Li
2026-10-12 11:54 ` Ido Schimmel [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20261012115414.GA704996@shredder \
--to=idosch@nvidia.com \
--cc=davem@davemloft.net \
--cc=dsahern@kernel.org \
--cc=edumazet@google.com \
--cc=horms@kernel.org \
--cc=jinli@lanxincomputing.com \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-kselftest@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=shuah@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.