From: Sang-Heon Jeon <ekffu200098@gmail.com>
To: Alexander Gordeev <agordeev@linux.ibm.com>,
Heiko Carstens <hca@linux.ibm.com>,
Vasily Gorbik <gor@linux.ibm.com>
Cc: Christian Borntraeger <borntraeger@linux.ibm.com>,
linux-s390@vger.kernel.org, Sven Schnelle <svens@linux.ibm.com>
Subject: [PATCH] s390/sclp: Remove redundant memset after memblock_alloc_low
Date: Tue, 13 Oct 2026 00:04:02 +0900 [thread overview]
Message-ID: <20261012150404.555918-1-ekffu200098@gmail.com> (raw)
memblock_alloc_low() returns zeroed memory, so the memset after the
allocation in sclp_early_get_core_info() is redundant.
So remove the memset.
No functional change.
Signed-off-by: Sang-Heon Jeon <ekffu200098@gmail.com>
---
drivers/s390/char/sclp_early.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/s390/char/sclp_early.c b/drivers/s390/char/sclp_early.c
index 22dd797e6229..821b61727d1f 100644
--- a/drivers/s390/char/sclp_early.c
+++ b/drivers/s390/char/sclp_early.c
@@ -138,7 +138,6 @@ int __init sclp_early_get_core_info(struct sclp_core_info *info)
if (!sccb)
return -ENOMEM;
- memset(sccb, 0, length);
sccb->header.length = length;
sccb->header.control_mask[2] = 0x80;
if (sclp_early_cmd(SCLP_CMDW_READ_CPU_INFO, sccb)) {
base-commit: 9fd7fca66735307fd7afa3450882a55ef80f2add
--
2.43.0
next reply other threads:[~2026-10-12 15:04 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-10-12 15:04 Sang-Heon Jeon [this message]
2026-10-12 15:09 ` [PATCH] s390/sclp: Remove redundant memset after memblock_alloc_low sashiko-bot
2026-10-12 15:18 ` Alexander Gordeev
2026-10-13 1:50 ` Sang-Heon Jeon
2026-10-13 9:05 ` Heiko Carstens
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20261012150404.555918-1-ekffu200098@gmail.com \
--to=ekffu200098@gmail.com \
--cc=agordeev@linux.ibm.com \
--cc=borntraeger@linux.ibm.com \
--cc=gor@linux.ibm.com \
--cc=hca@linux.ibm.com \
--cc=linux-s390@vger.kernel.org \
--cc=svens@linux.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.