From: kernel test robot <lkp@intel.com>
To: oe-kbuild@lists.linux.dev
Cc: lkp@intel.com, Dan Carpenter <error27@gmail.com>
Subject: [gerg-m68knommu:armnommu 3/3] drivers/mtd/maps/pismo.c:243 pismo_probe() error: we previously assumed 'pdata' could be null (see line 226)
Date: Mon, 12 Oct 2026 18:39:40 +0200 [thread overview]
Message-ID: <202610121829.Uh5Yrm1s-lkp@intel.com> (raw)
Unfiltered warning: this smatch report is sent as-is and has not been
reviewed for false positives, so please treat it with due skepticism.
BCC: lkp@intel.com
CC: oe-kbuild-all@lists.linux.dev
CC: linux-m68k@lists.linux-m68k.org
CC: uclinux-dev@uclinux.org
TO: Greg Ungerer <gerg@uclinux.org>
Hi Greg,
First bad commit (maybe != root cause):
tree: https://git.kernel.org/pub/scm/linux/kernel/git/gerg/m68knommu.git armnommu
head: dd5d1340f9d2226762be6e009f9dcc3d8639d1a2
commit: dd5d1340f9d2226762be6e009f9dcc3d8639d1a2 [3/3] ARM: versatile: support configuring versatile machine for no-MMU
:::::: branch date: 13 hours ago
:::::: commit date: 13 hours ago
config: arm-randconfig-r2201-20261012 (https://download.01.org/0day-ci/archive/20261012/202610121829.Uh5Yrm1s-lkp@intel.com/config)
compiler: arm-linux-gnueabi-gcc (GCC) 10.5.0
smatch: v0.5.0-9187-g5189e3fb
If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@intel.com>
| Reported-by: Dan Carpenter <error27@gmail.com>
| Closes: https://lore.kernel.org/r/202610121829.Uh5Yrm1s-lkp@intel.com/
smatch warnings:
drivers/mtd/maps/pismo.c:243 pismo_probe() error: we previously assumed 'pdata' could be null (see line 226)
vim +/pdata +243 drivers/mtd/maps/pismo.c
f6a8c60960bbea Russell King - ARM Linux 2009-11-29 208
0b79d5d1e5982b Uwe Kleine-König 2023-02-26 209 static int pismo_probe(struct i2c_client *client)
f6a8c60960bbea Russell King - ARM Linux 2009-11-29 210 {
f6a8c60960bbea Russell King - ARM Linux 2009-11-29 211 struct pismo_pdata *pdata = client->dev.platform_data;
f6a8c60960bbea Russell King - ARM Linux 2009-11-29 212 struct pismo_eeprom eeprom;
f6a8c60960bbea Russell King - ARM Linux 2009-11-29 213 struct pismo_data *pismo;
f6a8c60960bbea Russell King - ARM Linux 2009-11-29 214 int ret, i;
f6a8c60960bbea Russell King - ARM Linux 2009-11-29 215
752031210ca145 Wolfram Sang 2019-07-22 216 if (!i2c_check_functionality(client->adapter, I2C_FUNC_I2C)) {
f6a8c60960bbea Russell King - ARM Linux 2009-11-29 217 dev_err(&client->dev, "functionality mismatch\n");
f6a8c60960bbea Russell King - ARM Linux 2009-11-29 218 return -EIO;
f6a8c60960bbea Russell King - ARM Linux 2009-11-29 219 }
f6a8c60960bbea Russell King - ARM Linux 2009-11-29 220
bf4afc53b77aea Linus Torvalds 2026-02-21 221 pismo = kzalloc_obj(*pismo);
f6a8c60960bbea Russell King - ARM Linux 2009-11-29 222 if (!pismo)
f6a8c60960bbea Russell King - ARM Linux 2009-11-29 223 return -ENOMEM;
f6a8c60960bbea Russell King - ARM Linux 2009-11-29 224
f6a8c60960bbea Russell King - ARM Linux 2009-11-29 225 pismo->client = client;
f6a8c60960bbea Russell King - ARM Linux 2009-11-29 @226 if (pdata) {
f6a8c60960bbea Russell King - ARM Linux 2009-11-29 227 pismo->vpp = pdata->set_vpp;
f6a8c60960bbea Russell King - ARM Linux 2009-11-29 228 pismo->vpp_data = pdata->vpp_data;
f6a8c60960bbea Russell King - ARM Linux 2009-11-29 229 }
f6a8c60960bbea Russell King - ARM Linux 2009-11-29 230 i2c_set_clientdata(client, pismo);
f6a8c60960bbea Russell King - ARM Linux 2009-11-29 231
f6a8c60960bbea Russell King - ARM Linux 2009-11-29 232 ret = pismo_eeprom_read(client, &eeprom, 0, sizeof(eeprom));
f6a8c60960bbea Russell King - ARM Linux 2009-11-29 233 if (ret < 0) {
f6a8c60960bbea Russell King - ARM Linux 2009-11-29 234 dev_err(&client->dev, "error reading EEPROM: %d\n", ret);
395b228858778d Wolfram Sang 2010-03-20 235 goto exit_free;
f6a8c60960bbea Russell King - ARM Linux 2009-11-29 236 }
f6a8c60960bbea Russell King - ARM Linux 2009-11-29 237
f6a8c60960bbea Russell King - ARM Linux 2009-11-29 238 dev_info(&client->dev, "%.15s board found\n", eeprom.board);
f6a8c60960bbea Russell King - ARM Linux 2009-11-29 239
f6a8c60960bbea Russell King - ARM Linux 2009-11-29 240 for (i = 0; i < ARRAY_SIZE(eeprom.cs); i++)
f6a8c60960bbea Russell King - ARM Linux 2009-11-29 241 if (eeprom.cs[i].type != 0xff)
f6a8c60960bbea Russell King - ARM Linux 2009-11-29 242 pismo_add_one(pismo, i, &eeprom.cs[i],
f6a8c60960bbea Russell King - ARM Linux 2009-11-29 @243 pdata->cs_addrs[i]);
f6a8c60960bbea Russell King - ARM Linux 2009-11-29 244
f6a8c60960bbea Russell King - ARM Linux 2009-11-29 245 return 0;
395b228858778d Wolfram Sang 2010-03-20 246
395b228858778d Wolfram Sang 2010-03-20 247 exit_free:
395b228858778d Wolfram Sang 2010-03-20 248 kfree(pismo);
395b228858778d Wolfram Sang 2010-03-20 249 return ret;
f6a8c60960bbea Russell King - ARM Linux 2009-11-29 250 }
f6a8c60960bbea Russell King - ARM Linux 2009-11-29 251
:::::: The code at line 243 was first introduced by commit
:::::: f6a8c60960bbea378142d1fa1b3d111555ee41c7 mtd: Really add ARM pismo support
:::::: TO: Russell King - ARM Linux <linux@arm.linux.org.uk>
:::::: CC: David Woodhouse <David.Woodhouse@intel.com>
--
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki
next reply other threads:[~2026-10-12 16:40 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-10-12 16:39 kernel test robot [this message]
-- strict thread matches above, loose matches on Subject: below --
2025-01-06 10:59 [gerg-m68knommu:armnommu 3/3] drivers/mtd/maps/pismo.c:243 pismo_probe() error: we previously assumed 'pdata' could be null (see line 226) Dan Carpenter
2024-12-30 16:11 kernel test robot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=202610121829.Uh5Yrm1s-lkp@intel.com \
--to=lkp@intel.com \
--cc=error27@gmail.com \
--cc=oe-kbuild@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.